From: "Drew Adams" <drew.adams@oracle.com>
To: "'Stefan Monnier'" <monnier@iro.umontreal.ca>,
"'Juanma Barranquero'" <lekktu@gmail.com>
Cc: 11735@debbugs.gnu.org
Subject: bug#11735: 24.1.50; "Warning: Unknown defun property ... in ..."
Date: Tue, 19 Jun 2012 10:08:38 -0700 [thread overview]
Message-ID: <756D5F2362494551A6C983F58664ED63@us.oracle.com> (raw)
In-Reply-To: <jwvmx3zl0xn.fsf-monnier+emacs@gnu.org>
> Common Lisp does not try to enforce particular
> behaviors with respect to compilation warnings.
OK.
> >> Perhaps this kind of message is a candidate for a :debug
> >> warning level? I already said that it is useful for
> >> programmers. I do not see it as helpful for general users
> >> just loading a library. On the contrary: some might become
> >> confused, if not downright worried. That's all I'm trying to say.
>
> Just to put things in perspective, this message only occurs
> for uses of `declare' which use declarations not supported
> directly by Elisp (that's fairly uncommon)
Maybe not so uncommon for code that either is designed to work also with other
Emacsen (XEmacs? dunno) or for code that was originally taken from some other
Lisp.
The latter seems to be the case for `el-swank-fuzzy.el'.
> and only for those `declare's that are inside a `defun' rather
> than a `defun*' (even less common),
Less common: doubtful in the latter case I mentioned. `el-swank-fuzzy.el' is an
example here too. It uses both `defun*' and `defun', and it uses the
unsupported `declare' settings only with `defun'.
The point is not that that library is a model or does things the way they should
be done. The point is that that library is perhaps not atypical or rare as an
example of code that was moved to Emacs Lisp from Common Lisp.
The author presumably used `defun' when that was straightforward, and used
`defun*' when s?he needed Common Lisp `defun' thingies that are not available in
Emacs `defun'. (Doing that instead of just using `defun*' everywhere has the
advantage of making it clear which function definitions really need the added
juice of `defun*'.)
> and then only for code that's not byte-compiled.
> That's sufficiently rare that I'm not worried about it.
Maybe not worrying. But worth a bug report. And it would be good to give this
message a :debug warning level so it does not annoy or confuse users. Any
reason not to do that? At least as a wishlist item?
next prev parent reply other threads:[~2012-06-19 17:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-18 17:45 bug#11735: 24.1.50; "Warning: Unknown defun property ... in ..." Drew Adams
2012-06-18 20:37 ` Stefan Monnier
2012-06-18 20:49 ` Drew Adams
2012-06-18 21:11 ` Drew Adams
2012-06-18 21:43 ` Stefan Monnier
2012-06-18 22:03 ` Drew Adams
2012-06-19 0:59 ` Stefan Monnier
2012-06-19 2:45 ` Drew Adams
2012-06-19 11:54 ` Juanma Barranquero
2012-06-19 13:34 ` Drew Adams
2012-06-19 13:41 ` Juanma Barranquero
2012-06-19 16:36 ` Stefan Monnier
2012-06-19 17:08 ` Drew Adams [this message]
2012-06-19 21:37 ` Stefan Monnier
2012-06-19 22:01 ` Drew Adams
2014-02-09 3:40 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=756D5F2362494551A6C983F58664ED63@us.oracle.com \
--to=drew.adams@oracle.com \
--cc=11735@debbugs.gnu.org \
--cc=lekktu@gmail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.