From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#23750: 25.0.95; bug in url-retrieve or json.el Date: Tue, 21 Jun 2016 16:51:59 +0300 Message-ID: <7541b356-38a6-1bac-7914-3ec110d0c40b@yandex.ru> References: <358304f6-98e1-fa10-8805-aa9b73db406a@yandex.ru> <83k2hl828z.fsf@gnu.org> <83h9co8twu.fsf@gnu.org> <838ty07wno.fsf@gnu.org> <83r3br7gy0.fsf@gnu.org> <835e315a-e4c3-17a4-c2ee-7d8d5cc090b4@yandex.ru> <83porb6zpv.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------D9D53D7FA1120944BBD3CB51" X-Trace: ger.gmane.org 1466517447 27295 80.91.229.3 (21 Jun 2016 13:57:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 21 Jun 2016 13:57:27 +0000 (UTC) Cc: 23750@debbugs.gnu.org, monnier@IRO.UMontreal.CA, sdl.web@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jun 21 15:57:18 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bFMAw-0006uz-Tj for geb-bug-gnu-emacs@m.gmane.org; Tue, 21 Jun 2016 15:57:11 +0200 Original-Received: from localhost ([::1]:52017 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFMAw-0002Qh-6X for geb-bug-gnu-emacs@m.gmane.org; Tue, 21 Jun 2016 09:57:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53051) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFM6y-0007HV-Sh for bug-gnu-emacs@gnu.org; Tue, 21 Jun 2016 09:53:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bFM6w-0001fB-8Z for bug-gnu-emacs@gnu.org; Tue, 21 Jun 2016 09:53:04 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36499) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFM6w-0001f7-59 for bug-gnu-emacs@gnu.org; Tue, 21 Jun 2016 09:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bFM6v-0004AZ-Qt for bug-gnu-emacs@gnu.org; Tue, 21 Jun 2016 09:53:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 21 Jun 2016 13:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23750 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23750-submit@debbugs.gnu.org id=B23750.146651713015965 (code B ref 23750); Tue, 21 Jun 2016 13:53:01 +0000 Original-Received: (at 23750) by debbugs.gnu.org; 21 Jun 2016 13:52:10 +0000 Original-Received: from localhost ([127.0.0.1]:48836 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFM65-00049R-N8 for submit@debbugs.gnu.org; Tue, 21 Jun 2016 09:52:09 -0400 Original-Received: from mail-lb0-f174.google.com ([209.85.217.174]:35108) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFM63-00049F-UH for 23750@debbugs.gnu.org; Tue, 21 Jun 2016 09:52:08 -0400 Original-Received: by mail-lb0-f174.google.com with SMTP id o4so11356370lbp.2 for <23750@debbugs.gnu.org>; Tue, 21 Jun 2016 06:52:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to; bh=uoj1ozvezmB3LVBB84I4lroUG/TEd9ihBsaEYDiAA/4=; b=d2On5OsaXdPYM0m+vt72AzBxunhYIxLS81HN8P7e3K/5mqHHp2lxgHmQ62mmSBBG+i SLuequatxrDZT7fjR518qGOLrZf+zbDqPoSUW12So186dR6uk9Dn6o0dmCL4/5p+ljxT Op37Ja8BA3XnIMiG9E0MVYDFAguIc+2RM2M//wXMUJ/1rwn49OqKK5/vW4aTrnp7jzE1 Y/8YblIgFKZWr7CbUBBSLLBIDt5j8y40OAHCXtDuysJfmTCUIGPooI2BFeDlEPdgcE6Y C75KXIiT7S3QjHLIcn/VxHo8jIGBATtYKevULzge9+o6gdCFrkxzxYA2EkRjHiQUYt/B JWIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to; bh=uoj1ozvezmB3LVBB84I4lroUG/TEd9ihBsaEYDiAA/4=; b=EgspzScntcn+/7YgXsGs+mqYFw1fMwVEKRBPBhaA78MkRZJdZSZJqA5P2cSr86mydk YcZE4Xmul78DSEMbG0qT4niroLkiNpCUB4ffGA+gWZL0cg/M6iqOuLblp84iaUI9ozhA i/Emx1WaM9PpJ0yzCiatxInRO5pcZkgBHVEOV6gRmsRyWVtskJxMqvQGZL6CG8sZbURs IMKzETISeDwq+ro3XQwiiJqeLkTcnTCTSCy5VOQbd2NbZeS3MJ1D5jrMKBKgvspxm9TF mKkCR6rYq4zRjH/DBS1vW3t0tlv1t/ZJadiJbtv0zwaEABsjZO2ZHl1xc9yYLu6s/OxU xJAw== X-Gm-Message-State: ALyK8tKXbFobr+lVIEC4b9QXEFbiF+fzGcVmbulqswRDTpGAGWG5OiyIT4C97K39tRBkMA== X-Received: by 10.194.52.74 with SMTP id r10mr19533672wjo.50.1466517121781; Tue, 21 Jun 2016 06:52:01 -0700 (PDT) Original-Received: from [192.168.1.2] ([185.105.173.135]) by smtp.googlemail.com with ESMTPSA id r130sm3104916wmf.20.2016.06.21.06.52.00 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 21 Jun 2016 06:52:00 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 In-Reply-To: <83porb6zpv.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:119879 Archived-At: This is a multi-part message in MIME format. --------------D9D53D7FA1120944BBD3CB51 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit On 06/21/2016 05:30 AM, Eli Zaretskii wrote: > Because (a) I don't want to see that function in our sources, ever, > and (b) you don't have any control on the error message it produces, > which is not appropriate for application-level checks. Please take a look at the attachment. OK to install? I recall John saying we shouldn't push any more changes to emacs-25. --------------D9D53D7FA1120944BBD3CB51 Content-Type: text/x-patch; name="url-http-multibyte.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="url-http-multibyte.diff" diff --git a/lisp/url/url-http.el b/lisp/url/url-http.el index 5832e92..7156e6f 100644 --- a/lisp/url/url-http.el +++ b/lisp/url/url-http.el @@ -275,19 +275,7 @@ url-http-create-request ;; allows us to elide null lines directly, at the cost of making ;; the layout less clear. (setq request - ;; We used to concat directly, but if one of the strings happens - ;; to being multibyte (even if it only contains pure ASCII) then - ;; every string gets converted with `string-MAKE-multibyte' which - ;; turns the 127-255 codes into things like latin-1 accented chars - ;; (it would work right if it used `string-TO-multibyte' instead). - ;; So to avoid the problem we force every string to be unibyte. - (mapconcat - ;; FIXME: Instead of `string-AS-unibyte' we'd want - ;; `string-to-unibyte', so as to properly signal an error if one - ;; of the strings contains a multibyte char. - 'string-as-unibyte - (delq nil - (list + (concat ;; The request (or url-http-method "GET") " " (if using-proxy (url-recreate-url url-http-target-url) real-fname) @@ -365,7 +353,10 @@ url-http-create-request "\r\n" ;; Any data url-http-data)) - "")) + ;; Bug#23750 + (unless (= (string-bytes request) + (length request)) + (error "Multibyte text in HTTP request: %s" request)) (url-http-debug "Request is: \n%s" request) request)) --------------D9D53D7FA1120944BBD3CB51--