all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Cameron Desautels <camdez@gmail.com>
To: Drew Adams <drew.adams@oracle.com>
Cc: 19328@debbugs.gnu.org
Subject: bug#19328: [PATCH] Add mechanism to prompt about unsaved customizations
Date: Tue, 9 Dec 2014 13:47:56 -0600	[thread overview]
Message-ID: <74EB846F-F46E-427B-90BB-E79EC1934F93@gmail.com> (raw)
In-Reply-To: <09009907-c8b9-4279-baa8-5c4be0cdf66b@default>

> FWIW, These are the changes I made to `customize-unsaved':

> ;; 1. By default, ignores preferences in `customize-customized-ignore'.
> ;; 2. Added prefix arg to override `customize-customized-ignore'.
> ;; 3. When not interactive and there are changes, ask for confirmation.
> ;; 4. Always returns `t', so it can be used as a
> ;;    `kill-emacs-query-functions' hook.
> ;; 5. Wrap in `condition-case' and reissue error.

Thank you for sharing that!  I looked through it to see if I'm missing
anything important.  Your code is much more ambitious than the humble
patch I'm offering.  I definitely see the rationale behind your work
on `cus-edit+.el' but I think the important parts of it are orthogonal
to what I've done here.

WRT the five items above, 1 & 2 can be disregarded here because
`customize-customized-ignore' only exists in your library (and is only
necessary because of the elimination of the "changed outside of
Customize" state).

3-5 I cover differently--a new function rather than changing the
behavior of `customize-unsaved'--and this way has the benefit of being
minimally invasive (i.e. shouldn't break anyone else's code).

TLDR I still think it makes sense to merge the patch.

-- 
Cameron Desautels <camdez@gmail.com>






  reply	other threads:[~2014-12-09 19:47 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-09 15:46 bug#19328: [PATCH] Add mechanism to prompt about unsaved customizations Cameron Desautels
2014-12-09 15:54 ` Drew Adams
2014-12-09 16:16   ` Cameron Desautels
2014-12-09 16:24     ` Drew Adams
2014-12-09 17:05       ` Cameron Desautels
2014-12-09 17:46         ` Drew Adams
2014-12-09 19:47           ` Cameron Desautels [this message]
2014-12-09 20:10             ` Drew Adams
2014-12-10 15:32 ` Ted Zlatanov
2014-12-12  1:04   ` Cameron Desautels
2014-12-12  1:40     ` Stefan Monnier
2014-12-12  1:56       ` Cameron Desautels
2014-12-12  2:36         ` Stefan Monnier
2014-12-12  2:39           ` Cameron Desautels
2014-12-13  1:17             ` Ted Zlatanov
2014-12-13  5:55               ` Stefan Monnier
2014-12-13 13:06                 ` Ted Zlatanov
2014-12-13 23:23                   ` Cameron Desautels
2014-12-14 11:54                   ` Ted Zlatanov
2014-12-14 14:02                     ` Stefan Monnier
2014-12-14 16:31                       ` Ted Zlatanov
2016-02-23 11:36                 ` Lars Ingebrigtsen
2014-12-12  2:48       ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=74EB846F-F46E-427B-90BB-E79EC1934F93@gmail.com \
    --to=camdez@gmail.com \
    --cc=19328@debbugs.gnu.org \
    --cc=drew.adams@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.