From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#70988: (read FUNCTION) uses Latin-1 [PATCH] Date: Fri, 17 May 2024 19:08:15 +0200 Message-ID: <74B41A66-5B3C-4A09-A5F4-A389464BDA27@gmail.com> References: <37B5B5D0-9C0B-4E1C-9F3C-6CA647612E08@gmail.com> <86seyhh9uv.fsf@gnu.org> <86le49h6sm.fsf@gnu.org> <8634qghg2j.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5760"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 70988@debbugs.gnu.org, monnier@iro.umontreal.ca To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 17 19:10:33 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s816G-00019H-RW for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 17 May 2024 19:10:32 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s815o-0008He-GE; Fri, 17 May 2024 13:10:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s815j-0008Gw-MP for bug-gnu-emacs@gnu.org; Fri, 17 May 2024 13:09:59 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s815j-0003t4-EM for bug-gnu-emacs@gnu.org; Fri, 17 May 2024 13:09:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s815m-0004DM-BG for bug-gnu-emacs@gnu.org; Fri, 17 May 2024 13:10:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 May 2024 17:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70988 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 70988-submit@debbugs.gnu.org id=B70988.171596576716172 (code B ref 70988); Fri, 17 May 2024 17:10:02 +0000 Original-Received: (at 70988) by debbugs.gnu.org; 17 May 2024 17:09:27 +0000 Original-Received: from localhost ([127.0.0.1]:56239 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s815D-0004Cm-0m for submit@debbugs.gnu.org; Fri, 17 May 2024 13:09:27 -0400 Original-Received: from mail-lf1-f54.google.com ([209.85.167.54]:45306) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s815B-0004Bq-P7 for 70988@debbugs.gnu.org; Fri, 17 May 2024 13:09:26 -0400 Original-Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-51f2ebbd8a7so2795206e87.2 for <70988@debbugs.gnu.org>; Fri, 17 May 2024 10:09:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715965697; x=1716570497; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=cMem+VUmFnLOtC5CHR1mAmg8csBzq41/14DGUnnpirk=; b=YXD7nGYSYRMUK9Fc7oJKw9bwnzRdgJsTB9pnIRR02pImLM10kBWMra+iHf5g4Fn9kE tHN4rTfganiUSN290N0NimXOjIHfIhCnyw3seJjuxbSjejVqaN4GSOL3pY2lMXUBBqQy JNHxWDbAfjZW2itCjV0PfNBHscf92F7+LiU+FqX3xXdObDw4EKvsUrseyBMFFfa7Vtlx e8sBnf1MtLNHo2B2j+RPxiBriXys2qI2Ssj1pPntbAW6aqUOHjVienrx67k9F2ztyR57 Hj14TYKFeHb50ksTiOom0F0DipRW4MWY3Y948nudwijzW3wzAN//mezcEPpXA/SomN9H lOsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715965697; x=1716570497; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=cMem+VUmFnLOtC5CHR1mAmg8csBzq41/14DGUnnpirk=; b=RCinhl2F53NeWRxrlTzKawyBOLg4LwyDaQ12Jxtrj8IYbOrYgn5D1LJ15vIy1kThF4 iGzVehiyqZbVkiSGL+AxMEVj2vhtSq7awlLQ9OUkLcLy9RLGjITglhTSJh7+MMcYZ25M KREV4472CcOGYL+Ig5hFIURxPeZcHBrk7/5nEhok7wGvzWkQybe1BAtDsYWUybxiuW5o SJVbaHQqLPJ/zp0exOoyE+/3flYOWyDc3nLdvf2hqz6d+CyVMcHskbfoFSgK5yW9XB/i LKW/d9A1qN9n3v/RSBeGqNFUwCDX0vQqMDhHLWe/O7sQA925CDxNGZr8ByIGL5JdFtcD Pcjg== X-Gm-Message-State: AOJu0YzQiR2one/UiNx43xWzZln37E4z6U25Uv5FEnPiRdWS0SuEInik s9XxFdR1skB7w4zE6rXTm/EPqD09l3D18FZbvZVu1YyaFBZM8tAD X-Google-Smtp-Source: AGHT+IFd7vD4L5YLK5vKH5BZaodPofsIO7ey8+rtizceDnctrAXF2axv6c8ywN7OITZrC9YChu19WQ== X-Received: by 2002:a05:6512:32ae:b0:523:8a14:9149 with SMTP id 2adb3069b0e04-5238a1491b0mr6251486e87.21.1715965696554; Fri, 17 May 2024 10:08:16 -0700 (PDT) Original-Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se. [80.217.1.132]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-521f38d8b44sm3376307e87.209.2024.05.17.10.08.16 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 17 May 2024 10:08:16 -0700 (PDT) In-Reply-To: <8634qghg2j.fsf@gnu.org> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:285256 Archived-At: 17 maj 2024 kl. 12.45 skrev Eli Zaretskii : >>>>> Is it an accident that the code does the same only _after_ the = call to >>>>> readbyte? >>>>=20 >>>> Yes, I have no reason to believe otherwise. >>>=20 >>> To me, it actually looks as done on purpose. >>=20 >> You could very well be right about that. What I meant is that the = order doesn't matter at all. >=20 > Doesn't it affect what the readbyte call does? No -- the `*multibyte =3D ...` assignment is just an extra return value, = which indicates whether the returned values come from a unibyte or = multibyte source. For any given source (READCHARFUN, in the terminology = of lread.c), the characters will all be unibyte or multibyte, so this = returned `multibyte` flag will typically only be used once by the caller = and saved for future reference. But you are right to question it because lread.c is a royal mess and = many changes have not been made in a clean way. It is unclear whether = it's worth returning the `multibyte` flag at all; it's only used in = special cases.