From: "Mattias Engdegård" <mattias.engdegard@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 70988@debbugs.gnu.org, monnier@iro.umontreal.ca
Subject: bug#70988: (read FUNCTION) uses Latin-1 [PATCH]
Date: Fri, 17 May 2024 19:08:15 +0200 [thread overview]
Message-ID: <74B41A66-5B3C-4A09-A5F4-A389464BDA27@gmail.com> (raw)
In-Reply-To: <8634qghg2j.fsf@gnu.org>
17 maj 2024 kl. 12.45 skrev Eli Zaretskii <eliz@gnu.org>:
>>>>> Is it an accident that the code does the same only _after_ the call to
>>>>> readbyte?
>>>>
>>>> Yes, I have no reason to believe otherwise.
>>>
>>> To me, it actually looks as done on purpose.
>>
>> You could very well be right about that. What I meant is that the order doesn't matter at all.
>
> Doesn't it affect what the readbyte call does?
No -- the `*multibyte = ...` assignment is just an extra return value, which indicates whether the returned values come from a unibyte or multibyte source. For any given source (READCHARFUN, in the terminology of lread.c), the characters will all be unibyte or multibyte, so this returned `multibyte` flag will typically only be used once by the caller and saved for future reference.
But you are right to question it because lread.c is a royal mess and many changes have not been made in a clean way. It is unclear whether it's worth returning the `multibyte` flag at all; it's only used in special cases.
next prev parent reply other threads:[~2024-05-17 17:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-16 18:13 bug#70988: (read FUNCTION) uses Latin-1 [PATCH] Mattias Engdegård
2024-05-16 18:47 ` Eli Zaretskii
2024-05-16 19:45 ` Mattias Engdegård
2024-05-16 19:54 ` Eli Zaretskii
2024-05-17 8:08 ` Mattias Engdegård
2024-05-17 10:45 ` Eli Zaretskii
2024-05-17 17:08 ` Mattias Engdegård [this message]
2024-05-30 15:43 ` Mattias Engdegård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74B41A66-5B3C-4A09-A5F4-A389464BDA27@gmail.com \
--to=mattias.engdegard@gmail.com \
--cc=70988@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.