From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#62994: [PATCH v5] Add support for colored and styled underlines on tty frames Date: Wed, 14 Feb 2024 11:40:34 -0800 Message-ID: <749abb29-48ab-0d72-3031-3b87fe1fce54@gmail.com> References: <20240211180501.695192-1-mohkale@kisara.moe> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22462"; mail-complaints-to="usenet@ciao.gmane.io" To: mohkale@kisara.moe, 62994@debbugs.gnu.org, Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 14 20:43:08 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1raL9v-0005dc-Vj for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Feb 2024 20:43:07 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1raL9Z-0007Xm-T5; Wed, 14 Feb 2024 14:42:45 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1raL9Y-0007XB-L4 for bug-gnu-emacs@gnu.org; Wed, 14 Feb 2024 14:42:44 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1raL9Y-0007p0-Ct for bug-gnu-emacs@gnu.org; Wed, 14 Feb 2024 14:42:44 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1raL9q-0001TP-IS for bug-gnu-emacs@gnu.org; Wed, 14 Feb 2024 14:43:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Feb 2024 19:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62994 X-GNU-PR-Package: emacs Original-Received: via spool by 62994-submit@debbugs.gnu.org id=B62994.17079397235554 (code B ref 62994); Wed, 14 Feb 2024 19:43:02 +0000 Original-Received: (at 62994) by debbugs.gnu.org; 14 Feb 2024 19:42:03 +0000 Original-Received: from localhost ([127.0.0.1]:53147 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1raL8t-0001RU-D1 for submit@debbugs.gnu.org; Wed, 14 Feb 2024 14:42:03 -0500 Original-Received: from mail-pj1-f44.google.com ([209.85.216.44]:52370) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1raL8q-0001Qz-DQ for 62994@debbugs.gnu.org; Wed, 14 Feb 2024 14:42:01 -0500 Original-Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-29041136f73so152641a91.0 for <62994@debbugs.gnu.org>; Wed, 14 Feb 2024 11:41:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707939636; x=1708544436; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=JjEIxjTgJkhYMeO88fFOf9IuIkGs4pKcK+4u4UTXzaI=; b=W6Z+S2DRLHRubvF0dnUVJljxWVGS3lIOMKbuu2cYc+u2AneaLOQ954f6wLjJzySSiN RfMLtmeYNF9QJ5bUV2i4MW69LYyc53jahWI87HDHjR4NL0aAPsz7cq0mkzUBq5O5wrrL vE3iYjp+P21D30RUNIn0E/66cj+kQtbp4rtXvPbW/GJ1+AOJ2l896uNqnuoq5v6680TD ZvMTSMKLnSLSfzaped5LUml+p8yVOowCd6BWDf+GX6LHuD4UMsF+bMRCNXsa9iGGfEcC zlokAcx3LtnQyLEZ1ZrEkr3PQ1WTwCI/bQ+ycvkd7lIWnK1FRPlxKF/+gLvFh4FO1IPL keMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707939636; x=1708544436; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JjEIxjTgJkhYMeO88fFOf9IuIkGs4pKcK+4u4UTXzaI=; b=QuI4CT8E6zLNujYWu1DgGjcUXNqr4vRKq3hJKuidAUGt9rAwVIF31PyeL1WtuILd90 JJajy73DWgmnEaYjdyt+lt6GAKxs30EE07pigQPOCczdZhrCbHNI5UZ2cJFVu8Ce1gNz RpfcCPdfF+WcOZXkt1HSF4WQVD40bykl7dvk2KOde1Tsw1xKtIb95Ei7R34pcgrhqebE aqLjitrz3BgbOIk1bwhDli2NyPp5CTWkkMRBL4YvHjAXV49E0NILtpb5Rosb8E4Z7qlI bZzT7u+t9ACKe1zHWI9EsKyfW6hrRvW4SOcvsoPQF1ymJZYDMI/MEPS9JVKEdAkqtlN9 4b6g== X-Forwarded-Encrypted: i=1; AJvYcCXT0u1jhdrVMKNbX3IjTMj5KJaeXQay2jRbo0Wmqd6ukvhGb6tZWyB4N3QFhOd7YB0J5WYPspyB+1eb0vuiPMrP/SZY234= X-Gm-Message-State: AOJu0YwbJg/oLBkukCmS/QMF79ENY2HX1Lq9m3FWSeg8nV0+5NU73aDG 1vjT/ju5WYS+MX4XjWqttJoExnE76hnPjI1W32+NawRf0BwSQ+dY X-Google-Smtp-Source: AGHT+IFU1IQ6jZdGyFtOap8xCjsgnp77X/tUMjVLGP8xt5QV3f/Q+Ez0CNHUSsb46hd+LM2CiY0xgA== X-Received: by 2002:a17:90a:ac0a:b0:298:d21a:976c with SMTP id o10-20020a17090aac0a00b00298d21a976cmr2629780pjq.17.1707939636156; Wed, 14 Feb 2024 11:40:36 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCXSEmPj1Xk3QxsXUHqsYT7Da8QYtedRTMXj/1dBK3NkmM+D/R8cm6WpmtSA9TeoHNxsEKcUL2DMwv8gWBeZSASFNHedzJ1szrmypFzDYC7ol2/ddQ== Original-Received: from [192.168.1.2] (076-168-148-233.res.spectrum.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id hi20-20020a17090b30d400b00298ca46547fsm1821058pjb.36.2024.02.14.11.40.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Feb 2024 11:40:35 -0800 (PST) Content-Language: en-US In-Reply-To: <20240211180501.695192-1-mohkale@kisara.moe> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:280025 Archived-At: On 2/11/2024 10:05 AM, mohkale@kisara.moe wrote: > @@ -7229,6 +7343,9 @@ syms_of_xfaces (void) > DEFSYM (QCposition, ":position"); > DEFSYM (Qline, "line"); > DEFSYM (Qwave, "wave"); > + DEFSYM (Qdouble, "double"); > + DEFSYM (Qdotted, "dotted"); > + DEFSYM (Qdashed, "dashed"); > DEFSYM (Qreleased_button, "released-button"); > DEFSYM (Qpressed_button, "pressed-button"); > DEFSYM (Qflat_button, "flat-button"); This is very minor, but for consistency with the existing styles ("line" and "wave"), maybe we should use a noun form for the new styles. For example "dots", "dashes", and maybe "double-line"? That would hopefully be easier for programmers to remember, and leaves the door open for some other kind of doubled underline in the future too (e.g. a double wave).