From: Dmitry Gutov <dgutov@yandex.ru>
To: Alan Mackenzie <acm@muc.de>
Cc: emacs-devel@gnu.org
Subject: Re: master 7362554: Widen around c-font-lock-fontify-region. This fixes bug #38049.
Date: Tue, 12 Nov 2019 15:36:08 +0200 [thread overview]
Message-ID: <7497e71d-bab6-fa04-bbc4-f52fadeda16d@yandex.ru> (raw)
In-Reply-To: <20191111203445.GA5135@ACM>
Hi Alan,
On 11.11.2019 22:34, Alan Mackenzie wrote:
> On Mon, Nov 11, 2019 at 18:52:34 +0200, Dmitry Gutov wrote:
>> On 09.11.2019 16:40, Alan Mackenzie wrote:
>>> + (widen)
>
>> Could you try and honor font-lock-dont-widen here?
>
> Difficult. In CC Mode it is sometimes necessary to enlarge a font lock
> region so as to get the context needed to parse some element of the
> buffer. This was what gave rise to the bug.
Did that really happen in the reported scenario? I mean,
font-lock-dont-widen is usually nil, so font-lock will call widen for
you already.
> In all of Emacs, there's just one use of font-lock-dont-widen, in
> rmail.el, and that is almost certainly for a different reason than your
> use of it (which is, I believe, having several major modes in a single
> buffer).
Does RMail use it for quoted pirces of code? If so, it would be similar.
> Could you, perhaps, suggest some alternative to using widen in
> c-font-lock-fontify-region? Some way which would still work for CC Mode
> (including the just fixed bug), but wouldn't adversely affect the
> several major mode code you're maintaining? Would it be possible to
> widen "a bit" rather than widening to the whole buffer? If so, how
> would I determine the bit to widen to?
Not sure what difference the supposed "bit" would make (and thus, how
would mmm-mode determine it). But I think that would depend on your
answer to my first question in this email. Because, I think, normally
you don't "have to" widen at all, font-lock will do that for you.
In mmm-mode context, however, we apply definite boundaries to the region
chunks. Here's an example of some Noweb code:
https://en.wikipedia.org/wiki/Noweb#Example_of_a_simple_noweb_program
The inside of hello.c block would be narrowed to.
Now, I have remembered that CC Mode calls widen from many places
already, so it already is problematic for using in a context like that.
Thus this particular change doesn't change the picture much, and so
please feel free to drop this conversation at any point of time.
next prev parent reply other threads:[~2019-11-12 13:36 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191109144026.20810.76129@vcs0.savannah.gnu.org>
[not found] ` <20191109144027.DDC3720927@vcs0.savannah.gnu.org>
2019-11-11 16:52 ` master 7362554: Widen around c-font-lock-fontify-region. This fixes bug #38049 Dmitry Gutov
2019-11-11 20:34 ` Alan Mackenzie
2019-11-12 13:36 ` Dmitry Gutov [this message]
2019-11-13 21:19 ` Alan Mackenzie
2019-11-13 22:33 ` Dmitry Gutov
2019-11-14 13:42 ` Stefan Monnier
2019-11-14 14:05 ` Dmitry Gutov
2019-11-14 14:29 ` Eli Zaretskii
2019-11-14 14:35 ` Dmitry Gutov
2019-11-14 14:48 ` Eli Zaretskii
2019-11-14 14:50 ` Dmitry Gutov
2019-11-14 16:08 ` Eli Zaretskii
2019-11-14 21:07 ` Dmitry Gutov
2019-11-15 9:31 ` Eli Zaretskii
2019-11-15 10:24 ` Dmitry Gutov
2019-11-15 13:00 ` Eli Zaretskii
2019-11-14 13:49 ` Eli Zaretskii
2019-11-14 14:08 ` Dmitry Gutov
2019-11-14 14:37 ` Dmitry Gutov
2019-11-14 14:55 ` Stefan Monnier
2019-11-14 15:02 ` Dmitry Gutov
2019-11-14 15:33 ` Stefan Monnier
2019-11-14 16:12 ` Eli Zaretskii
2019-11-14 18:51 ` Stefan Monnier
2019-11-14 19:19 ` Eli Zaretskii
2019-11-14 19:48 ` Dmitry Gutov
2019-11-14 19:56 ` Eli Zaretskii
2019-11-14 19:59 ` Dmitry Gutov
2019-11-15 7:34 ` Eli Zaretskii
2019-11-15 7:52 ` Dmitry Gutov
2019-11-14 21:29 ` Stefan Monnier
2019-11-14 21:46 ` Dmitry Gutov
2019-11-15 9:36 ` Eli Zaretskii
2019-11-15 10:26 ` Dmitry Gutov
2019-11-15 23:27 ` Stefan Monnier
2019-11-16 8:02 ` Eli Zaretskii
2019-11-17 0:50 ` Stefan Monnier
2019-11-17 3:33 ` Eli Zaretskii
2019-11-17 7:36 ` Dmitry Gutov
2019-11-17 15:44 ` Eli Zaretskii
2019-11-17 17:59 ` Dmitry Gutov
2019-11-17 18:26 ` Eli Zaretskii
2019-11-17 18:35 ` Dmitry Gutov
2019-11-14 19:58 ` Dmitry Gutov
2019-11-14 21:24 ` Several Major Modes. [Was: master 7362554: Widen around c-font-lock-fontify-region. This fixes bug #38049.] Alan Mackenzie
2019-11-14 22:11 ` Dmitry Gutov
2019-11-15 20:10 ` Several Major Modes Alan Mackenzie
2019-11-15 21:45 ` Dmitry Gutov
2019-11-16 13:10 ` Alan Mackenzie
2019-11-17 12:48 ` Dmitry Gutov
2019-11-17 16:03 ` Alan Mackenzie
2019-11-17 21:56 ` Dmitry Gutov
2019-11-14 13:35 ` master 7362554: Widen around c-font-lock-fontify-region. This fixes bug #38049 Eli Zaretskii
2019-11-15 22:43 ` Dmitry Gutov
2019-11-14 12:02 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7497e71d-bab6-fa04-bbc4-f52fadeda16d@yandex.ru \
--to=dgutov@yandex.ru \
--cc=acm@muc.de \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.