From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.bugs Subject: bug#64347: 30.0.50; Some customize faces shown as edited with -Q Date: Sat, 8 Jul 2023 18:32:15 -0300 Message-ID: <748ccb81-d56c-76aa-d06b-47e4e3807ddb@gmail.com> References: <87jzvmd17f.fsf@gmx.net> <83cz1etpdm.fsf@gnu.org> <2b6de9de-f33f-0547-eaa0-1f9d24f70115@gmail.com> <28fa0831-bb28-b7c1-1535-3a950f6b2545@gmail.com> <83y1jqdeqm.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36456"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Cc: stephen.berman@gmx.net, 64347@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 08 23:33:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qIFYP-0009GD-Q2 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 08 Jul 2023 23:33:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qIFY8-0001Id-CT; Sat, 08 Jul 2023 17:33:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qIFY6-0001Dr-Nm for bug-gnu-emacs@gnu.org; Sat, 08 Jul 2023 17:33:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qIFY6-0004dc-FM for bug-gnu-emacs@gnu.org; Sat, 08 Jul 2023 17:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qIFY5-0007CX-Vm for bug-gnu-emacs@gnu.org; Sat, 08 Jul 2023 17:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 08 Jul 2023 21:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64347 X-GNU-PR-Package: emacs Original-Received: via spool by 64347-submit@debbugs.gnu.org id=B64347.168885194827635 (code B ref 64347); Sat, 08 Jul 2023 21:33:01 +0000 Original-Received: (at 64347) by debbugs.gnu.org; 8 Jul 2023 21:32:28 +0000 Original-Received: from localhost ([127.0.0.1]:45282 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qIFXY-0007Bf-8g for submit@debbugs.gnu.org; Sat, 08 Jul 2023 17:32:28 -0400 Original-Received: from mail-oa1-f41.google.com ([209.85.160.41]:47333) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qIFXW-0007BR-8C for 64347@debbugs.gnu.org; Sat, 08 Jul 2023 17:32:26 -0400 Original-Received: by mail-oa1-f41.google.com with SMTP id 586e51a60fabf-1b056276889so2862942fac.2 for <64347@debbugs.gnu.org>; Sat, 08 Jul 2023 14:32:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688851940; x=1691443940; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8SEgranjN2Evqyd1TyY+MIS6uR7/+cefvfWQNSsfA5s=; b=ORe5+H0nWZSy352Wnl7zhOqtuE/h8iJbblpHyxqn0Asc6lDFRyDa7Q1lnDDTnTFxmC 86m58LeCvYCHjLB85nWTZEAYXyum2UTMIa7QGqV+Zwq9ocGrIUQDy8wUHF2gESMTyBy0 0tojwtr2aly2UGD2pSQLBmZsWGRz4k1hXlqdzgLv9ZQxStjdAuF0s9zYDL8IdRejnJcU O2HNyj0gzJVeWWVq5e6khFjdvglwYkVpBrnN0dbZwCDPzuhGuufGQcGUTFLaLV0kpw7R 3yYiFkFkIrwT3utOecxGScQv7wwPFOmhh1460I0mWMwQAiBTdpx/hGuedmQuMCAiazsM 5pJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688851940; x=1691443940; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8SEgranjN2Evqyd1TyY+MIS6uR7/+cefvfWQNSsfA5s=; b=AZcIDNM/MftUoKj7RMDmPRiDYO2CxLr5LxnR1lFtU2+oc90F8VSM2b0k/o38vpiwsx UCupm9wnYnhRZfH/nH9kW/VCB5LjyHaYubB3BVXzT221+/WFGMiFz7Y35TRTXdOsxMc5 Xni3tL69MYc5srom45gfXdcvmeZQkgR4J2AHXnIF0G2W+zNhwAbTLImAbYUWRAVUG9Kh iCj9FtWlACT8cwYttGiU/6kOsrC0+0qF6lBTrajW9/+lQBHnV9uRtZ+DuZHg7Ey+em0Y wUVNr+BuxH2NG1WlT2uMDkB1aSxJYvZSYF0msUYMA2g3+9d5sJ5hTXtRj6hrIClyurp8 Tqcw== X-Gm-Message-State: ABy/qLb4nftGHBtPNtk2WzI96Pd4Hf6DFMpL6tYRtk756H3HhRYW1biy fcF5N/JM83iSSHF4U1jTsUQ= X-Google-Smtp-Source: APBJJlEE1PeqYNfNtdjyXZxCVPO5HyEj/eaSehxvp8xWa7AtLk351dQGWmBCImGj3jxuWd6llVohpg== X-Received: by 2002:a05:6870:588f:b0:1b0:6539:40fa with SMTP id be15-20020a056870588f00b001b0653940famr10425290oab.19.1688851940369; Sat, 08 Jul 2023 14:32:20 -0700 (PDT) Original-Received: from [192.168.0.234] ([186.127.128.249]) by smtp.gmail.com with ESMTPSA id w4-20020a056830110400b006b87f593877sm2862791otq.37.2023.07.08.14.32.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 08 Jul 2023 14:32:19 -0700 (PDT) Content-Language: en-US In-Reply-To: <83y1jqdeqm.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264799 Archived-At: Eli Zaretskii writes: > Thanks. > > Can you show a patch for the two bugs you've succeeded to identify? Not yet.  I wrote a working post-filter for the :box property, but there are still some faces that show with the EDITED state. Since there are both ways to specify the same information for the :line-width value, there's always a chance of not sending the expected format to face-spec-match-p. Let's say we have (:line-width 1).  Then the pre-filter converts it into (:line-width (1 . 1)), and then the post-filter should convert it back to (:line-width 1), and that works. But if we have (:line-width (1 . 1)), the pre-filter does nothing, and the post-filter will transform it into (:line-width 1), and that way specs won't match. So sometimes we want to post-filter to (:line-width WIDTH) and sometimes to (VWIDTH . HWIDTH) and there's currently not enough information to do that, or at least I missed it. > Did you make any progress with the one bug that's left after the other > two are fixed? I did find that face-attr-match-p uses equal even with properties like :underline and :box that can have plists as values.  But I haven't tried to fix it, because I got frustrated with the post-filter thing.