From: Mauro Aranda <maurooaranda@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: stephen.berman@gmx.net, 64347@debbugs.gnu.org
Subject: bug#64347: 30.0.50; Some customize faces shown as edited with -Q
Date: Sat, 8 Jul 2023 18:32:15 -0300 [thread overview]
Message-ID: <748ccb81-d56c-76aa-d06b-47e4e3807ddb@gmail.com> (raw)
In-Reply-To: <83y1jqdeqm.fsf@gnu.org>
Eli Zaretskii <eliz@gnu.org> writes:
> Thanks.
>
> Can you show a patch for the two bugs you've succeeded to identify?
Not yet. I wrote a working post-filter for the :box property, but
there are still some faces that show with the EDITED state.
Since there are both ways to specify the same information for the
:line-width value, there's always a chance of not sending the expected
format to face-spec-match-p.
Let's say we have (:line-width 1). Then the pre-filter converts it into
(:line-width (1 . 1)), and then the post-filter should convert it back
to (:line-width 1), and that works.
But if we have (:line-width (1 . 1)), the pre-filter does nothing, and
the post-filter will transform it into (:line-width 1), and that way
specs won't match.
So sometimes we want to post-filter to (:line-width WIDTH) and sometimes
to (VWIDTH . HWIDTH) and there's currently not enough information to do
that, or at least I missed it.
> Did you make any progress with the one bug that's left after the other
> two are fixed?
I did find that face-attr-match-p uses equal even with properties like
:underline and :box that can have plists as values. But I haven't tried
to fix it, because I got frustrated with the post-filter thing.
next prev parent reply other threads:[~2023-07-08 21:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-29 10:15 bug#64347: 30.0.50; Some customize faces shown as edited with -Q Stephen Berman
2023-06-29 12:38 ` Eli Zaretskii
2023-06-30 11:33 ` Mauro Aranda
2023-06-30 12:43 ` Drew Adams
2023-06-30 14:05 ` Mauro Aranda
2023-07-08 7:49 ` Eli Zaretskii
2023-07-08 21:32 ` Mauro Aranda [this message]
2023-07-09 5:43 ` Eli Zaretskii
2023-07-09 11:44 ` Mauro Aranda
2023-07-09 12:13 ` Eli Zaretskii
2023-07-09 23:12 ` Mauro Aranda
2023-07-10 12:47 ` Eli Zaretskii
2023-07-10 13:45 ` Mauro Aranda
2023-07-15 20:01 ` Mauro Aranda
2023-07-20 15:45 ` Eli Zaretskii
2023-07-15 20:11 ` Mauro Aranda
2023-07-20 15:49 ` Eli Zaretskii
2023-07-20 18:56 ` Mauro Aranda
2023-07-20 19:09 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=748ccb81-d56c-76aa-d06b-47e4e3807ddb@gmail.com \
--to=maurooaranda@gmail.com \
--cc=64347@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=stephen.berman@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.