Bug report: agenda column mode failure

Bug report: agenda column mode failure

[Hannes Schulz]

Hi everyone,

when I put my agenda in column mode, I would like to change
efforts and the like. 

When I do some action it instantly drops out of column mode.

I'm using  org-mode from git 7.9 (release_7.9-163-gdfe33f).

The same phenomenon occurs with a minimal config:


% ------------- minimal-org.el -----
(setq debug-on-error t
    debug-on-signal nil
    debug-on-quit nil)
(add-to-list 'load-path "~/checkout/git/org-mode/lisp")
(require 'org-install)

% ------------- minimal.org -----
#+PROPERTY: Effort_ALL 0 0:10 0:30 1:00 2:00 3:00 4:00 5:00 6:00 7:00
#+COLUMNS: %40ITEM(Task) %17Effort(Estimated Effort){:} %CLOCKSUM
* Heading
** TODO Task 1
   SCHEDULED: <2012-08-30 Do>
** date
   <2012-08-30 Do>

%------------end------------

I run like this:

$ emacs -Q -l minimal-org.el minimal.org

then I add minimal.org to the agenda files, create the agenda, put it in column
mode, and use shift-right in the effort column.

This yields the following backtrace:

Debugger entered--Lisp error: (error "Marker does not point anywhere")
  goto-char(#<marker in no buffer>)
  (save-excursion (goto-char beg) (setq end (condition-case nil ... ...)) (goto-char end) (while (re-search-backward re beg t) (setq sumpos ... last-level ... level ... val ... valflag ...) (cond ... ... ...)))
  (let* ((re org-outline-regexp-bol) (lmax 30) (lvals ...) (lflag ...) (level 0) (ass ...) (format ...) (printf ...) (fun ...) (calc ...) (beg org-columns-top-level-marker) (inminlevel org-inlinetask-min-level) (last-level org-inlinetask-min-level) val valflag flag end sumpos sum-alist sum str str1 useval) (save-excursion (goto-char beg) (setq end ...) (goto-char end) (while ... ... ...)))
  org-columns-compute("Effort")
  (cond ((equal ... "CLOCKSUM") (org-clock-sum)) ((equal ... "CLOCKSUM_T") (org-clock-sum-today)) ((and ... ... ...) (org-columns-compute ...)))
  (while (setq fm (pop fmt)) (cond (... ...) (... ...) (... ...)))
  (save-restriction (widen) (org-unmodified (remove-text-properties ... ... ...)) (goto-char (point-min)) (org-columns-get-format-and-top-level) (while (setq fm ...) (cond ... ... ...)))
  (save-excursion (save-restriction (widen) (org-unmodified ...) (goto-char ...) (org-columns-get-format-and-top-level) (while ... ...)))
  (save-current-buffer (set-buffer (or ... b)) (save-excursion (save-restriction ... ... ... ... ...)))
  (with-current-buffer (or (buffer-base-buffer b) b) (save-excursion (save-restriction ... ... ... ... ...)))
  (while (setq f (pop files)) (setq b (find-buffer-visiting f)) (with-current-buffer (or ... b) (save-excursion ...)))
  (let ((files org-agenda-contributing-files) (org-columns-begin-marker ...) (org-columns-top-level-marker ...) f fm a b) (while (setq f ...) (setq b ...) (with-current-buffer ... ...)))
  org-agenda-colview-compute((("ITEM" "Task" 40 nil nil nil + nil) ("Effort" "Estimated Effort" 17 ":" add_times nil + nil) ("CLOCKSUM" "CLOCKSUM" nil nil nil nil + nil)))
  (progn (org-agenda-colview-compute org-columns-current-fmt-compiled))
  (if org-agenda-columns-compute-summary-properties (progn (org-agenda-colview-compute org-columns-current-fmt-compiled)))
  (when org-agenda-columns-compute-summary-properties (org-agenda-colview-compute org-columns-current-fmt-compiled))
  (let ((org-columns-time ...) cache maxwidths m p a d fmt) (cond (... ... ...) (... ...) (... ...) (... ... ...)) (setq fmt (or fmt org-columns-default-format)) (org-set-local (quote org-columns-current-fmt) fmt) (org-columns-compile-format fmt) (when org-agenda-columns-compute-summary-properties (org-agenda-colview-compute org-columns-current-fmt-compiled)) (save-excursion (goto-char ...) (while ... ... ...) (when cache ... ... ... ... ... ...)))
  org-agenda-columns()
  call-interactively(org-agenda-columns nil nil)

cheers,

-Hannes

Re: Bug report: agenda column mode failure

[Jacob Riko]

Hi Hannes,

I was about to report the same behavior on a Mac:

On 30.08.2012, at 13:47, Hannes Schulz wrote:

> when I put my agenda in column mode, I would like to change
> efforts and the like. 
> When I do some action it instantly drops out of column mode.
> 
> I'm using  org-mode from git 7.9 (release_7.9-163-gdfe33f).
Here org-version: 7.9 (release_7.9-174-gcdbc2d.dirty)

For the sake of a clean compile (aka by pure chance) I changed 
org-mode/local.mk to point to the current emacs 24.2 (from http://emacsformacosx.com/)
…
# Name of your emacs binary
#EMACS	= emacs
EMACS	= /Applications/Emacs.app/Contents/MacOS/Emacs
…

Now my minimal example works as expected:
--------
#+PROPERTY: Effort_ALL 0 0:10 0:30 1:00 2:00 3:00 4:00 5:00 6:00 7:00
#+COLUMNS: %40ITEM(Task) %17Effort(Estimated Effort){:} %CLOCKSUM(Clock){:}

* Tasks
** TODO was 
   SCHEDULED: <2012-08-30 Thu>
   CLOCK: [2012-08-31 Fri 03:35]--[2012-08-31 Fri 03:44] =>  0:09
   :PROPERTIES:
   :Effort:   1:00
   :END:
---------

I still have to try it on my real org-files though.

Riko



Viele Grüße

Riko Jacob

--  
Riko Jacob                       Tel. +41 44 632 25 73
rjacob@inf.ethz.ch
http://www.inf.ethz.ch/personal/rjacob/

Re: Bug report: agenda column mode failure

[Jacob Riko]

Hi Hannes,

On 31.08.2012, at 03:52, Jacob Riko wrote:
> I was about to report the same behavior on a Mac:

Sorry for the noise, I actually do see the same behavior.
It is just that entering column-view in the file works fine, only a column view on the agenda (C-c C-x C-c) throws the error.

Below are a short and a detailed backtrace.

Riko


Short:

 debug(error (error "Marker does not point anywhere"))
 org-columns-compute("Effort")
 org-agenda-colview-compute((("ITEM" "Task" 40 nil nil nil + nil) ("Effort" "Estimated Effort" 17 ":" add_times nil + nil) ("CLOCKSUM" "Clock" nil ":" add_times nil + nil)))
 org-agenda-columns()
 call-interactively(org-agenda-columns nil nil)

Complete (after C-u M-x org-reload)

Debugger entered--Lisp error: (error "Marker does not point anywhere")
 goto-char(#<marker in no buffer>)
 (save-excursion (goto-char beg) (setq end (condition-case nil (org-end-of-subtree t) (error (point-max)))) (goto-char end) (while (re-search-backward re beg t) (setq sumpos (match-beginning 0) last-level (if (not (or (zerop level) (eq level inminlevel))) level last-level) level (org-outline-level) val (org-entry-get nil property) valflag (and val (string-match "\\S-" val))) (cond ((< level last-level) (setq sum (+ (if (and ... ...) (apply fun ...) 0) (if (aref lvals inminlevel) (apply fun ...) 0)) flag (or (aref lflag last-level) (aref lflag inminlevel)) str (org-columns-number-to-string sum format printf) str1 (org-add-props (copy-sequence str) nil (quote org-computed) t (quote face) (quote bold)) useval (if flag str1 (if valflag val "")) sum-alist (get-text-property sumpos (quote org-summaries))) (if (assoc property sum-alist) (setcdr (assoc property sum-alist) useval) (push (cons property useval) sum-alist) (org-unmodified (add-text-properties sumpos (1+ sumpos) (list ... sum-alist)))) (when (and val (not (equal val ...))) (org-entry-put nil property (if flag str val))) (when (or flag valflag) (push (if flag sum (funcall calc ...)) (aref lvals level)) (aset lflag level t)) (loop for l from (1+ level) to (1- lmax) do (aset lvals l nil) (aset lflag l nil))) ((>= level last-level) (when valflag (push (funcall calc (org-columns-string-to-number val format)) (aref lvals level)) (aset lflag level t))) (t (error "This should not happen")))))
 (let* ((re org-outline-regexp-bol) (lmax 30) (lvals (make-vector lmax nil)) (lflag (make-vector lmax nil)) (level 0) (ass (assoc property org-columns-current-fmt-compiled)) (format (nth 4 ass)) (printf (nth 5 ass)) (fun (nth 6 ass)) (calc (or (nth 7 ass) (quote identity))) (beg org-columns-top-level-marker) (inminlevel org-inlinetask-min-level) (last-level org-inlinetask-min-level) val valflag flag end sumpos sum-alist sum str str1 useval) (save-excursion (goto-char beg) (setq end (condition-case nil (org-end-of-subtree t) (error (point-max)))) (goto-char end) (while (re-search-backward re beg t) (setq sumpos (match-beginning 0) last-level (if (not (or (zerop level) (eq level inminlevel))) level last-level) level (org-outline-level) val (org-entry-get nil property) valflag (and val (string-match "\\S-" val))) (cond ((< level last-level) (setq sum (+ (if ... ... 0) (if ... ... 0)) flag (or (aref lflag last-level) (aref lflag inminlevel)) str (org-columns-number-to-string sum format printf) str1 (org-add-props (copy-sequence str) nil (quote org-computed) t (quote face) (quote bold)) useval (if flag str1 (if valflag val "")) sum-alist (get-text-property sumpos (quote org-summaries))) (if (assoc property sum-alist) (setcdr (assoc property sum-alist) useval) (push (cons property useval) sum-alist) (org-unmodified (add-text-properties sumpos ... ...))) (when (and val (not ...)) (org-entry-put nil property (if flag str val))) (when (or flag valflag) (push (if flag sum ...) (aref lvals level)) (aset lflag level t)) (loop for l from (1+ level) to (1- lmax) do (aset lvals l nil) (aset lflag l nil))) ((>= level last-level) (when valflag (push (funcall calc ...) (aref lvals level)) (aset lflag level t))) (t (error "This should not happen"))))))
 org-columns-compute("Effort")
 (cond ((equal (car fm) "CLOCKSUM") (org-clock-sum)) ((equal (car fm) "CLOCKSUM_T") (org-clock-sum-today)) ((and (nth 4 fm) (setq a (assoc (car fm) org-columns-current-fmt-compiled)) (equal (nth 4 a) (nth 4 fm))) (org-columns-compute (car fm))))
 (while (setq fm (pop fmt)) (cond ((equal (car fm) "CLOCKSUM") (org-clock-sum)) ((equal (car fm) "CLOCKSUM_T") (org-clock-sum-today)) ((and (nth 4 fm) (setq a (assoc (car fm) org-columns-current-fmt-compiled)) (equal (nth 4 a) (nth 4 fm))) (org-columns-compute (car fm)))))
 (save-restriction (widen) (org-unmodified (remove-text-properties (point-min) (point-max) (quote (org-summaries t)))) (goto-char (point-min)) (org-columns-get-format-and-top-level) (while (setq fm (pop fmt)) (cond ((equal (car fm) "CLOCKSUM") (org-clock-sum)) ((equal (car fm) "CLOCKSUM_T") (org-clock-sum-today)) ((and (nth 4 fm) (setq a (assoc (car fm) org-columns-current-fmt-compiled)) (equal (nth 4 a) (nth 4 fm))) (org-columns-compute (car fm))))))
 (save-excursion (save-restriction (widen) (org-unmodified (remove-text-properties (point-min) (point-max) (quote (org-summaries t)))) (goto-char (point-min)) (org-columns-get-format-and-top-level) (while (setq fm (pop fmt)) (cond ((equal (car fm) "CLOCKSUM") (org-clock-sum)) ((equal (car fm) "CLOCKSUM_T") (org-clock-sum-today)) ((and (nth 4 fm) (setq a (assoc ... org-columns-current-fmt-compiled)) (equal (nth 4 a) (nth 4 fm))) (org-columns-compute (car fm)))))))
 (save-current-buffer (set-buffer (or (buffer-base-buffer b) b)) (save-excursion (save-restriction (widen) (org-unmodified (remove-text-properties (point-min) (point-max) (quote (org-summaries t)))) (goto-char (point-min)) (org-columns-get-format-and-top-level) (while (setq fm (pop fmt)) (cond ((equal (car fm) "CLOCKSUM") (org-clock-sum)) ((equal (car fm) "CLOCKSUM_T") (org-clock-sum-today)) ((and (nth 4 fm) (setq a ...) (equal ... ...)) (org-columns-compute (car fm))))))))
 (with-current-buffer (or (buffer-base-buffer b) b) (save-excursion (save-restriction (widen) (org-unmodified (remove-text-properties (point-min) (point-max) (quote (org-summaries t)))) (goto-char (point-min)) (org-columns-get-format-and-top-level) (while (setq fm (pop fmt)) (cond ((equal (car fm) "CLOCKSUM") (org-clock-sum)) ((equal (car fm) "CLOCKSUM_T") (org-clock-sum-today)) ((and (nth 4 fm) (setq a ...) (equal ... ...)) (org-columns-compute (car fm))))))))
 (while (setq f (pop files)) (setq b (find-buffer-visiting f)) (with-current-buffer (or (buffer-base-buffer b) b) (save-excursion (save-restriction (widen) (org-unmodified (remove-text-properties (point-min) (point-max) (quote (org-summaries t)))) (goto-char (point-min)) (org-columns-get-format-and-top-level) (while (setq fm (pop fmt)) (cond ((equal ... "CLOCKSUM") (org-clock-sum)) ((equal ... "CLOCKSUM_T") (org-clock-sum-today)) ((and ... ... ...) (org-columns-compute ...))))))))
 (let ((files org-agenda-contributing-files) (org-columns-begin-marker (make-marker)) (org-columns-top-level-marker (make-marker)) f fm a b) (while (setq f (pop files)) (setq b (find-buffer-visiting f)) (with-current-buffer (or (buffer-base-buffer b) b) (save-excursion (save-restriction (widen) (org-unmodified (remove-text-properties (point-min) (point-max) (quote ...))) (goto-char (point-min)) (org-columns-get-format-and-top-level) (while (setq fm (pop fmt)) (cond (... ...) (... ...) (... ...))))))))
 org-agenda-colview-compute((("ITEM" "Task" 40 nil nil nil + nil) ("Effort" "Estimated Effort" 17 ":" add_times nil + nil) ("CLOCKSUM" "Clock" nil ":" add_times nil + nil)))
 (progn (org-agenda-colview-compute org-columns-current-fmt-compiled))
 (if org-agenda-columns-compute-summary-properties (progn (org-agenda-colview-compute org-columns-current-fmt-compiled)))
 (when org-agenda-columns-compute-summary-properties (org-agenda-colview-compute org-columns-current-fmt-compiled))
 (let ((org-columns-time (time-to-number-of-days (current-time))) cache maxwidths m p a d fmt) (cond ((and (boundp (quote org-agenda-overriding-columns-format)) org-agenda-overriding-columns-format) (setq fmt org-agenda-overriding-columns-format) (org-set-local (quote org-agenda-overriding-columns-format) fmt)) ((setq m (org-get-at-bol (quote org-hd-marker))) (setq fmt (or (org-entry-get m "COLUMNS" t) (with-current-buffer (marker-buffer m) org-columns-default-format)))) ((and (boundp (quote org-columns-current-fmt)) (local-variable-p (quote org-columns-current-fmt)) org-columns-current-fmt) (setq fmt org-columns-current-fmt)) ((setq m (next-single-property-change (point-min) (quote org-hd-marker))) (setq m (get-text-property m (quote org-hd-marker))) (setq fmt (or (org-entry-get m "COLUMNS" t) (with-current-buffer (marker-buffer m) org-columns-default-format))))) (setq fmt (or fmt org-columns-default-format)) (org-set-local (quote org-columns-current-fmt) fmt) (org-columns-compile-format fmt) (when org-agenda-columns-compute-summary-properties (org-agenda-colview-compute org-columns-current-fmt-compiled)) (save-excursion (goto-char (point-min)) (while (not (eobp)) (when (setq m (or (org-get-at-bol (quote org-hd-marker)) (org-get-at-bol (quote org-marker)))) (setq p (org-entry-properties m)) (when (or (not (setq a ...)) (not (string-match "\\S-" ...))) (when (and org-agenda-columns-add-appointments-to-effort-sum (setq d ...)) (setq d (org-minutes-to-hh:mm-string d)) (put-text-property 0 (length d) (quote face) (quote org-warning) d) (push (cons org-effort-property d) p))) (push (cons (org-current-line) p) cache)) (beginning-of-line 2)) (when cache (setq maxwidths (org-columns-get-autowidth-alist fmt cache)) (org-set-local (quote org-columns-current-maxwidths) maxwidths) (org-columns-display-here-title) (when (org-set-local (quote org-columns-flyspell-was-active) (org-bound-and-true-p flyspell-mode)) (flyspell-mode 0)) (mapc (lambda (x) (org-goto-line (car x)) (org-columns-display-here (cdr x))) cache) (when org-agenda-columns-show-summaries (org-agenda-colview-summarize cache)))))
 org-agenda-columns()
 call-interactively(org-agenda-columns nil nil)
 recursive-edit()

Re: Bug report: agenda column mode failure

[Bastien]

Hi Hannes,

Hannes Schulz <schulz@ais.uni-bonn.de> writes:

> when I put my agenda in column mode, I would like to change
> efforts and the like. 
>
> When I do some action it instantly drops out of column mode.

This should be fixed now.  Thanks to you and Jacob for 
reporting this!

-- 
 Bastien

Re: Bug report: agenda column mode failure

[Jacob Riko]

Hi Bastien,

On 31.08.2012, at 08:05, Bastien wrote:
> This should be fixed now.  Thanks to you and Jacob for 
> reporting this!

Seems to work for me.

Thanks!

Riko

Re: Bug report: agenda column mode failure

[Hannes Schulz]

Hi Bastien,

> On 31.08.2012, at 08:05, Bastien wrote:
> > This should be fixed now.  Thanks to you and Jacob for
> > reporting this!
> 
> Seems to work for me.

works for me too, thanks for fixing this so quickly!

A quick question: After playing with minimal configs, I now need to start emacs with 

$ emacs -l ~/.emacs.d/init.el

it seems to have forgotten that it should load init.el automatically. 
Any hint how I can fix this and avoid it next time?

cheers,

 Hannes

Re: Bug report: agenda column mode failure

[Bastien]

Hannes Schulz <schulzh@ais.uni-bonn.de> writes:

> it seems to have forgotten that it should load init.el automatically. 
> Any hint how I can fix this and avoid it next time?

Nope, sorry... maybe you deleted some part of your initial config
inadvertantly? 

-- 
 Bastien