From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#60503: 29.0.60; js-ts-mode has inconsistent features/fontification wrt other ts major-modes Date: Mon, 2 Jan 2023 14:20:33 -0800 Message-ID: <745379A6-A947-49E3-B03F-59BAC8BA726E@gmail.com> References: <8bc28051-fba0-cf5c-f2df-653f7583574e@secure.kjonigsen.net> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3948"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60503-done@debbugs.gnu.org, dancol@dancol.org, jostein@kjonigsen.net To: Theodor Thornhill Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 02 23:21:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pCTBI-0000pX-Re for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 02 Jan 2023 23:21:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pCTB2-0003HD-Ua; Mon, 02 Jan 2023 17:21:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pCTB0-0003Gi-Jj for bug-gnu-emacs@gnu.org; Mon, 02 Jan 2023 17:21:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pCTB0-0003Rv-8L for bug-gnu-emacs@gnu.org; Mon, 02 Jan 2023 17:21:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pCTB0-0005np-3p for bug-gnu-emacs@gnu.org; Mon, 02 Jan 2023 17:21:02 -0500 In-Reply-To: <8bc28051-fba0-cf5c-f2df-653f7583574e@secure.kjonigsen.net> Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Mon, 02 Jan 2023 22:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 60503 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 60503@debbugs.gnu.org, casouri@gmail.com, jostein@kjonigsen.net Original-Received: via spool by 60503-done@debbugs.gnu.org id=D60503.167269804622258 (code D ref 60503); Mon, 02 Jan 2023 22:21:01 +0000 Original-Received: (at 60503-done) by debbugs.gnu.org; 2 Jan 2023 22:20:46 +0000 Original-Received: from localhost ([127.0.0.1]:44255 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCTAj-0005mw-Re for submit@debbugs.gnu.org; Mon, 02 Jan 2023 17:20:46 -0500 Original-Received: from mail-pj1-f54.google.com ([209.85.216.54]:35516) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCTAf-0005ma-Oi for 60503-done@debbugs.gnu.org; Mon, 02 Jan 2023 17:20:44 -0500 Original-Received: by mail-pj1-f54.google.com with SMTP id w4-20020a17090ac98400b002186f5d7a4cso34162699pjt.0 for <60503-done@debbugs.gnu.org>; Mon, 02 Jan 2023 14:20:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=bmXWu1e3S0ne8VhZ+t/FCSpa0+uZd8vDkh+Ml/fdNZ0=; b=lmAhYK0tfFiLN63fTbDhDMea5PN+iFPLnqGL9ZTVxzA0IbbByJior2jQXD9eYxXU0k WFfVHWwjWFGXNy8xy/kKhRd033TAm0h51mAnL3+9V07dq6j+J3iCT41HRG54Us6LkK5+ GS8TCuAkITt5HFdRKjHXNr/dG7yzbMyDF8/98xjde71iTfItVqLto3lIDKR5c+NWrcSH 5rCyA2FOdbGrH+a9zIQeJTWgmM55IdiVR09v0aJMSwBgLvRt8PVd6IBa2rUfRTFdNLIG btLUJi/T73kmJ0hdI+jajUVCpCdw3sDpi/vNzl4AZJzl6LuOKNn2LRH1pO4gKqr6+SOt qpFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bmXWu1e3S0ne8VhZ+t/FCSpa0+uZd8vDkh+Ml/fdNZ0=; b=KS0DlSBQFH83EY7e9JjxMDKu3L7UG7Nw2iFtxaEF7oI3PIzILA7sgk5qglQ3lvZstf uQX8TzOS4krjPaHj0qxEncdGagVcGlzpMpDkKaVyV5ZTM5aquJ4StiOtiXJ/5DFfrh1v NRujvs8JaU3udorrdNujqLjRABQFyi912wfQG6MIpw/Ikj8fHnMwLAzACDaLmhIfyhGp FzshUcE3gMErVm+aUTHiu8AA3i3uThn1GtbGop010jJmFhz8JWm2pmS9yFQPqWbkY6Gh Prx3UjvKkJFcq3ny5QG1ZtEumjYf1UpqhMoI3XGBEYC6UxXcYRkYPYzmmS2Rx+rPlpK4 1UKw== X-Gm-Message-State: AFqh2kqwL90grTQuFJ+vvkIiG9EVoiNQ/wimHo7u88a5ZTgH9/4hh0zF lmFH18/sE2zNPMynruhgBJM= X-Google-Smtp-Source: AMrXdXv2q+jBq6/AAgzVvomtd8/Y/4rs66nQmspDgcXCFruRMBDj04m5AoUi1X9xuPDl9FN2OOXxzQ== X-Received: by 2002:a17:903:3111:b0:192:5c3e:894e with SMTP id w17-20020a170903311100b001925c3e894emr31784688plc.16.1672698035817; Mon, 02 Jan 2023 14:20:35 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id b14-20020a170902650e00b001868d4600b8sm20712517plk.158.2023.01.02.14.20.34 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 Jan 2023 14:20:35 -0800 (PST) X-Mailer: Apple Mail (2.3696.120.41.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252367 Archived-At: Theodor Thornhill writes: > Jostein Kj=C3=B8nigsen writes: > >> js-ts-mode does not adhere to the "standardized" features and=20 >> fontification levels requested in emacs-devel. >> >> It's overall pretty good, but I did find one minor inconsistency = which=20 >> annoyed me enough to (IMO) warrant an update: >> >> js-ts-mode does not highlight incoming parameters in=20 >> functions/methods/arrow-expressions as variables. >> >> Attached is a patch which fixes this issue and makes it much more=20 >> consistent with csharp-ts-mode, tsx-ts-mode and typescript-ts-mode. >> > > Looks good to me :-) > > Theo Great! I applied the patch. Yuan