From: Yuan Fu <casouri@gmail.com>
To: Theodor Thornhill <theo@thornhill.no>
Cc: 60503-done@debbugs.gnu.org, dancol@dancol.org, jostein@kjonigsen.net
Subject: bug#60503: 29.0.60; js-ts-mode has inconsistent features/fontification wrt other ts major-modes
Date: Mon, 2 Jan 2023 14:20:33 -0800 [thread overview]
Message-ID: <745379A6-A947-49E3-B03F-59BAC8BA726E@gmail.com> (raw)
In-Reply-To: <8bc28051-fba0-cf5c-f2df-653f7583574e@secure.kjonigsen.net>
Theodor Thornhill <theo@thornhill.no> writes:
> Jostein Kjønigsen <jostein@secure.kjonigsen.net> writes:
>
>> js-ts-mode does not adhere to the "standardized" features and
>> fontification levels requested in emacs-devel.
>>
>> It's overall pretty good, but I did find one minor inconsistency which
>> annoyed me enough to (IMO) warrant an update:
>>
>> js-ts-mode does not highlight incoming parameters in
>> functions/methods/arrow-expressions as variables.
>>
>> Attached is a patch which fixes this issue and makes it much more
>> consistent with csharp-ts-mode, tsx-ts-mode and typescript-ts-mode.
>>
>
> Looks good to me :-)
>
> Theo
Great! I applied the patch.
Yuan
prev parent reply other threads:[~2023-01-02 22:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-02 20:28 bug#60503: 29.0.60; js-ts-mode has inconsistent features/fontification wrt other ts major-modes Jostein Kjønigsen
2023-01-02 20:57 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-02 22:20 ` Yuan Fu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=745379A6-A947-49E3-B03F-59BAC8BA726E@gmail.com \
--to=casouri@gmail.com \
--cc=60503-done@debbugs.gnu.org \
--cc=dancol@dancol.org \
--cc=jostein@kjonigsen.net \
--cc=theo@thornhill.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.