From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Emanuele Giaquinta Newsgroups: gmane.emacs.devel Subject: Re: support for rxvt-unicode in rxvt.el Date: Wed, 21 Sep 2005 18:43:45 +0200 Message-ID: <74205160509210943718a3746@mail.gmail.com> References: <20050921132431.GA5008@host91-100.pool871.interbusiness.it> <200509211629.j8LGTCKE019350@scanner2.ics.uci.edu> Reply-To: Emanuele Giaquinta NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: sea.gmane.org 1127322301 31485 80.91.229.2 (21 Sep 2005 17:05:01 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 21 Sep 2005 17:05:01 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Sep 21 19:04:52 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1EI7zv-0002HX-3H for ged-emacs-devel@m.gmane.org; Wed, 21 Sep 2005 19:03:07 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EI7zu-0001k5-FD for ged-emacs-devel@m.gmane.org; Wed, 21 Sep 2005 13:03:06 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EI7x1-0000zO-NT for emacs-devel@gnu.org; Wed, 21 Sep 2005 13:00:07 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EI7wz-0000yu-2S for emacs-devel@gnu.org; Wed, 21 Sep 2005 13:00:06 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EI7wa-0008Ru-Qf for emacs-devel@gnu.org; Wed, 21 Sep 2005 12:59:40 -0400 Original-Received: from [64.233.162.200] (helo=zproxy.gmail.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1EI7hF-0003KM-DI for emacs-devel@gnu.org; Wed, 21 Sep 2005 12:43:49 -0400 Original-Received: by zproxy.gmail.com with SMTP id x7so115866nzc for ; Wed, 21 Sep 2005 09:43:46 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=EZoL950af8hLLlUrSQ/Xnsbk1WSkZ3ImUWQ1asKhn+pjh0KTHg9bswoPljXCMI1oSmwjoZYaoa3Kl8FBqzz/FaJSPSvpRr9UsJ5mR3H0tL/GLF+9wTjBXTl2t8Li52NK0sYWsKydm1NX9fSHWXG+VqZVfJ4jwDfSaFH1rF0RRWw= Original-Received: by 10.36.57.15 with SMTP id f15mr4643514nza; Wed, 21 Sep 2005 09:43:46 -0700 (PDT) Original-Received: by 10.36.60.19 with HTTP; Wed, 21 Sep 2005 09:43:45 -0700 (PDT) Original-To: Dan Nicolaescu In-Reply-To: <200509211629.j8LGTCKE019350@scanner2.ics.uci.edu> Content-Disposition: inline X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:43134 Archived-At: On 9/21/05, Dan Nicolaescu wrote: > If these are all the changes you need, then probably you don't need a > new term/rxvt-unicode.el file. In fact this is a patch to rxvt.el. > The up, down, right and left key should be set from the rxvt-unicode term= info > entry, so you don't need those define-keys. So if you just add the > color setting code to rxvt.el then everything should work. Can you > verify that the above is indeed true? > IMHO it is better to avoid code duplication... I perfectly agree with you here; I've already tested it without defining the sequences for the cursor keys, and, as expected, emacs gets them from the terminfo entry. I have added them only for simmetry with the existing code in rxvt.el and xterm.el. If there is no good reason, the existing definitions for the cursor keys in rxvt.el and xterm.el could be deleted.