From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jens Schmidt Newsgroups: gmane.emacs.devel Subject: Re: master 3b1fd42732f: * lisp/loadup.el: Check advice after `rmc.el`; turn error into warning Date: Tue, 12 Dec 2023 22:48:56 +0100 Message-ID: <73d5b60d-afbd-4543-8001-9fe043b4b6ab@vodafonemail.de> References: <170197287539.12661.7539324399514249195@vcs2.savannah.gnu.org> <20231207181435.BCB79C0C6AD@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33313"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird To: emacs-devel@gnu.org, Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Dec 12 22:50:11 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rDAdm-0008Rq-5V for ged-emacs-devel@m.gmane-mx.org; Tue, 12 Dec 2023 22:50:10 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rDAcx-0003wp-7x; Tue, 12 Dec 2023 16:49:19 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rDAcv-0003wT-A4 for emacs-devel@gnu.org; Tue, 12 Dec 2023 16:49:17 -0500 Original-Received: from mr6.vodafonemail.de ([145.253.228.166]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rDAcp-0003pZ-CQ for emacs-devel@gnu.org; Tue, 12 Dec 2023 16:49:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vodafonemail.de; s=vfde-mb-mr2-23sep; t=1702417748; bh=nyTnFDe4WbXlJMstexk7aOtkQoCruJW3S/UOprg0idk=; h=Message-ID:Date:User-Agent:Subject:Content-Language:To:References: From:In-Reply-To:Content-Type:From; b=N+6MMkriMlnybq4yf2J+RFXZkYyPqjjXjTroUAtfh3ZUseDI3aoh+VGOrXcZciTkc 8Ft0l45RLPJDLdXjlHtkXQViVkLzugEgHQ2f0lhyJ1YCz2Cu+n5Uj3BcpzOj4sF+oK B+Hog3tW1MS/onlNrs4EMNbKKGK+8Rn9L0l9t//U= Original-Received: from smtp.vodafone.de (unknown [10.0.0.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mr6.vodafonemail.de (Postfix) with ESMTPS id 4SqXLr2v3Wz1xr2; Tue, 12 Dec 2023 21:49:08 +0000 (UTC) Original-Received: from [192.168.178.41] (port-92-196-55-212.dynamic.as20676.net [92.196.55.212]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp.vodafone.de (Postfix) with ESMTPSA id 4SqXLh4vHwzHnHc; Tue, 12 Dec 2023 21:48:57 +0000 (UTC) Content-Language: de-DE-frami, en-US In-Reply-To: <20231207181435.BCB79C0C6AD@vcs2.savannah.gnu.org> X-purgate-type: clean X-purgate: clean X-purgate-size: 1093 X-purgate-ID: 155817::1702417744-F4FF4693-9AAC9648/0/0 Received-SPF: pass client-ip=145.253.228.166; envelope-from=jschmidt4gnu@vodafonemail.de; helo=mr6.vodafonemail.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:313733 Archived-At: On 2023-12-07 19:14, Stefan Monnier wrote: > branch: master > commit 3b1fd42732f7ca5b2db6ad6e75af1c037e1c54e4 > Author: Stefan Monnier > Commit: Stefan Monnier > > * lisp/loadup.el: Check advice after `rmc.el`; turn error into warning I don't mind the error => warning change, we have been discussing that in a slightly different context, anyway. But when I tried to place that advice-checking-code into loadup.el, I also saw this rmc.el and didn't quite know what to do with it. I thought that Lars might have placed it *inadvertently* after the (load "site-load" t) block, because, um, logically it belongs to before that, doesn't it? First all the core libraries get preloaded (including rmc.el), then any site-specific libraries. So probably TRT here would be to place these paragraphs as follows: 0. (load "leim/leim-list.el" t) 1. (load "emacs-lisp/rmc") 2. Check for advices (on core libs only). 3. (load "site-load" t) 4. "default-directory must be unibyte" What do you think?