From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#70310: flymake in elisp buffer elides warning on a blank first line Date: Tue, 9 Apr 2024 23:10:22 +0300 Message-ID: <73ac4d10-cdcd-4788-9920-3446f1ad13b0@gutov.dev> References: <75492273-AA84-497D-B206-CAADB1A8E013@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13378"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: Spencer Baugh , =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , 70310@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Apr 09 22:11:11 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ruHoD-0003Gb-TU for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Apr 2024 22:11:10 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ruHo0-00033P-PC; Tue, 09 Apr 2024 16:10:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ruHny-00033B-Ft for bug-gnu-emacs@gnu.org; Tue, 09 Apr 2024 16:10:54 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ruHny-00020N-7Q for bug-gnu-emacs@gnu.org; Tue, 09 Apr 2024 16:10:54 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ruHo5-0006uO-Uo for bug-gnu-emacs@gnu.org; Tue, 09 Apr 2024 16:11:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Apr 2024 20:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70310 X-GNU-PR-Package: emacs Original-Received: via spool by 70310-submit@debbugs.gnu.org id=B70310.171269344226470 (code B ref 70310); Tue, 09 Apr 2024 20:11:01 +0000 Original-Received: (at 70310) by debbugs.gnu.org; 9 Apr 2024 20:10:42 +0000 Original-Received: from localhost ([127.0.0.1]:51607 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ruHnm-0006sr-7F for submit@debbugs.gnu.org; Tue, 09 Apr 2024 16:10:42 -0400 Original-Received: from fout6-smtp.messagingengine.com ([103.168.172.149]:39985) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ruHni-0006ro-Mu for 70310@debbugs.gnu.org; Tue, 09 Apr 2024 16:10:40 -0400 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailfout.nyi.internal (Postfix) with ESMTP id 05BD4138029B; Tue, 9 Apr 2024 16:10:25 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Tue, 09 Apr 2024 16:10:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1712693425; x=1712779825; bh=Oq+T2xDbrhlXe1uAoCvL/5ZnNmX2V5x5U3INaE9fY3c=; b= Jm06qI+84jsKSJxfF27g7NwYg3+6uQ8LG7ppHkTEuWmNeCDd1fRPB3w+WoL9m2gH OA1cix313cyWIHWs0XwdbH5rqT6GkT3mP0gRT8W+I3AxQdjxY1TlPF5Cj9RpS8ui lAnuQScvSyG10UXs3+QmFrbCKd7AQeKEbVC3sRcp/vjgUTGYp+bvt10PCGm4irzD 6+EuPkpO65Cl0w1DxXe0V/flIACKnimwcadzyH7HFqLoPv63OMb53+dpaf1WcuEJ k0oZ6yOO5to6/Z/XLalIHQkGrxojxLsuj/SVaQ/QunfZoUr222+sbocHzwP8+GTp GO/EKxTre75DsK3fe7TYMg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1712693425; x= 1712779825; bh=Oq+T2xDbrhlXe1uAoCvL/5ZnNmX2V5x5U3INaE9fY3c=; b=u dbxQMj5y3kC6ZwgtsOTaDZtOeTaHc5qgMKtBkM9M0R/fpC5XV9IcIG5/LhZfndEq EDUJaqDoOlZKZYViqowcEdxx2CFtDH3U7ze84uifofwMSQaGsaEcnkUATvqxVU48 lYFHNm7s7tPHpPldqs8NAB4nInsvk+AeN0tw/beiBk7egR4wci6J3j/MmInNNSGj 3yVZMWhHoKklcIIkIZFJrOtUeVr3OX0nNgS7ojiVPWIrIaBysolBdPpUA9gbig0m OENYettSapmlSnyAtcz2gjBszA7/888R6TdMT/d30Ltumi36ajkm5d8jDOuiiqYU qsWYUuY9nFw3ihnbWLdIQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudehgedgudeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtkeertddtvdejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepgeelfeetkefghfdvhfdtgeevveevteetgeetveegtedthefhudekteehffeu keeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 9 Apr 2024 16:10:23 -0400 (EDT) Content-Language: en-US In-Reply-To: <75492273-AA84-497D-B206-CAADB1A8E013@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:283010 Archived-At: On 09/04/2024 16:45, Mattias Engdegård wrote: > On Emacs master: > > 1. Open an Elisp file. > 2. Enable flymake. > 3. Insert a blank line at the top. > > This should result in a warning about a missing 'lexical-binding' cookie but none is shown. > Making the first line non-empty, even a single space, makes the warning appear. Some brief experiment shows that these lines are relevant, though I'm not sure why, given that the byte-compiler's output is the same, whether the first line is empty or not: diff --git a/lisp/progmodes/elisp-mode.el b/lisp/progmodes/elisp-mode.el index 9b4c3f994cd..bc03130827c 100644 --- a/lisp/progmodes/elisp-mode.el +++ b/lisp/progmodes/elisp-mode.el @@ -2151,8 +2151,8 @@ elisp-flymake--byte-compile-done (point-max))) collect (flymake-make-diagnostic (current-buffer) - (if (= beg end) (1- beg) beg) - end + beg + (if (= beg end) (1+ end) end) level string)))))))