From: martin rudalics <rudalics@gmx.at>
To: 46178@debbugs.gnu.org
Subject: bug#46178: 28.0.50; auto-resize-tool-bars / auto-resize-tab-bars grow-only
Date: Fri, 29 Jan 2021 19:12:02 +0100 [thread overview]
Message-ID: <7369c03a-2d74-11d2-d7f6-4aaf60c20874@gmx.at> (raw)
With emacs -Q run a graphical build with a tab bar or an internal tool
bar (motif, lucid, no toolkit have the latter). Do
(setq auto-resize-tab-bars 'grow-only)
and/or
(setq auto-resize-tool-bars 'grow-only)
Now make the frame very narrow so the tool and/or tab bar wrap(s)
around. Expand the frame again, so the items on the bar(s) occupy one
line only. You will see empty lines below the lines showing the items.
According to the doc-strings of the above options and the Elisp manual
you should now be able to use 'recenter' to get rid of these empty
lines:
If value is ‘grow-only’, the tab-bar’s height is only increased
automatically; to decrease the tab-bar height, use M-x recenter.
However, this doesn't work by default since in the following part of
'recenter'
if (!NILP (redisplay)
&& !NILP (Vrecenter_redisplay)
&& (!EQ (Vrecenter_redisplay, Qtty)
|| !NILP (Ftty_type (selected_frame))))
{
ptrdiff_t i;
/* Invalidate pixel data calculated for all compositions. */
for (i = 0; i < n_compositions; i++)
composition_table[i]->font = NULL;
#if defined (HAVE_WINDOW_SYSTEM)
WINDOW_XFRAME (w)->minimize_tab_bar_window_p = 1;
#endif
#if defined (HAVE_WINDOW_SYSTEM) && ! defined (HAVE_EXT_TOOL_BAR)
WINDOW_XFRAME (w)->minimize_tool_bar_window_p = 1;
#endif
Fredraw_frame (WINDOW_FRAME (w));
SET_FRAME_GARBAGED (WINDOW_XFRAME (w));
Vrecenter_redisplay is by default 'tty' and Ftty_type (selected_frame)
is nil, so the conjunct never becomes true and minimize_tab_bar_window_p
is never set to 1.
So we'd have to mention in the docs of this option that one can regain
these lines only by setting 'recenter-redisplay' to anything but the
default. Better IMHO would be to abolish the never used and completely
useless 'grow-only' value for these options.
martin
next reply other threads:[~2021-01-29 18:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-29 18:12 martin rudalics [this message]
2021-01-29 20:09 ` bug#46178: 28.0.50; auto-resize-tool-bars / auto-resize-tab-bars grow-only Eli Zaretskii
2021-01-30 10:18 ` martin rudalics
2021-01-30 14:17 ` Eli Zaretskii
2021-01-30 15:27 ` martin rudalics
2021-01-30 19:48 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7369c03a-2d74-11d2-d7f6-4aaf60c20874@gmx.at \
--to=rudalics@gmx.at \
--cc=46178@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.