From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#36372: 27.0.50; replace-regexp-in-string skips START first chars in return value [PATCH] Date: Wed, 26 Jun 2019 07:01:04 -0700 (PDT) Message-ID: <732ddb90-5456-45dc-9c79-15d0a0662c28@default> References: <83tvcdlm8x.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="60409"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 36372@debbugs.gnu.org To: Lars Ingebrigtsen , Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jun 26 16:03:01 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hg8Vp-000FQT-N7 for geb-bug-gnu-emacs@m.gmane.org; Wed, 26 Jun 2019 16:03:01 +0200 Original-Received: from localhost ([::1]:40412 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hg8Vo-0004Pu-GW for geb-bug-gnu-emacs@m.gmane.org; Wed, 26 Jun 2019 10:03:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49081) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hg8Uv-0004PR-6P for bug-gnu-emacs@gnu.org; Wed, 26 Jun 2019 10:02:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hg8Ut-00069e-Mb for bug-gnu-emacs@gnu.org; Wed, 26 Jun 2019 10:02:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51306) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hg8Us-00068S-RT for bug-gnu-emacs@gnu.org; Wed, 26 Jun 2019 10:02:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hg8Us-0001SN-KE for bug-gnu-emacs@gnu.org; Wed, 26 Jun 2019 10:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 26 Jun 2019 14:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36372 X-GNU-PR-Package: emacs Original-Received: via spool by 36372-submit@debbugs.gnu.org id=B36372.15615576773281 (code B ref 36372); Wed, 26 Jun 2019 14:02:02 +0000 Original-Received: (at 36372) by debbugs.gnu.org; 26 Jun 2019 14:01:17 +0000 Original-Received: from localhost ([127.0.0.1]:36617 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hg8U9-0000qb-5Q for submit@debbugs.gnu.org; Wed, 26 Jun 2019 10:01:17 -0400 Original-Received: from userp2120.oracle.com ([156.151.31.85]:34474) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hg8U6-0000kp-U1 for 36372@debbugs.gnu.org; Wed, 26 Jun 2019 10:01:15 -0400 Original-Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5QDxKov071047; Wed, 26 Jun 2019 14:01:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=g0JGLG+GFxvPtT9bP4nRH2qBa+aRXqROrFKTA2d4N8w=; b=yF5Qlbr8gGXDh6FZZDvZXE5a89D6wdQxwAepaavpVWSu7pQejmlC81AuGEqOlqYfb70f KkdRBjSsgIhw12Qqpyy5gkKL+Hnu0QVTNr9dKVG+HH0QtCEEatfROvVXYZDp9KAw2imK /VM3qYQcYms6lXJJ9/1wtfhSUkuiY6S409MDaIAC8WBqxRRaV0pJJZRpIMqkxVh/7vps rZsIEUJjXcJYFwoBr/Wk5dXbbFMhQIKMEhk2BkJooB8w2+C5cjd84gg41HgYZ4hWuLXj FI//95D6luOBuUZ6r8cQvhFrRA2ZQBvLXTiGbKMxiS+9bBosg6LBmsgm0229NOEl8mch sg== Original-Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2120.oracle.com with ESMTP id 2t9cyqjf5h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 26 Jun 2019 14:01:07 +0000 Original-Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5QDxtJn174307; Wed, 26 Jun 2019 14:01:06 GMT Original-Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3030.oracle.com with ESMTP id 2t99f4fsrg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 26 Jun 2019 14:01:06 +0000 Original-Received: from abhmp0015.oracle.com (abhmp0015.oracle.com [141.146.116.21]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x5QE15oP020284; Wed, 26 Jun 2019 14:01:05 GMT In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4861.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9299 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906260167 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9299 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906260168 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161493 Archived-At: > So it isn't used in-tree at all. Since it's an (in my opinion) pretty > useless parameter as it's currently implemented, I think we should ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > deprecate the parameter and remove the documentation. >=20 > Then, perhaps, in ten years time we can reintroduce the parameter with > better semantics. :-) 1. Whether it's used in-tree is not sufficient. 2. Whether it is useless "as it's currently implemented" is not sufficient. That's what implementation bugs are about. 3. But I agree that it is likely very rarely used, if at all. (Searched my code and found no matches, as one example.) 3. IF it has a use, when fixed as you see fit, then fix it, and call out the fixed behavior as an incompatible change. In that case, do not deprecate it. (I don't know that it has a use, if fixed, hence "IF".)