From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Merten Newsgroups: gmane.emacs.devel Subject: Re: Re-including rst.el into Emacs repository Date: Mon, 07 May 2012 22:06:46 +0200 Message-ID: <7259.1336421206@theowa.merten-home.homelinux.org> References: <30996.1335792548@eskebo.merten-home.homelinux.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-Trace: dough.gmane.org 1336421228 4157 80.91.229.3 (7 May 2012 20:07:08 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 7 May 2012 20:07:08 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon May 07 22:07:07 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SRUD0-0008RN-An for ged-emacs-devel@m.gmane.org; Mon, 07 May 2012 22:07:02 +0200 Original-Received: from localhost ([::1]:56413 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SRUCz-0000Rp-Gp for ged-emacs-devel@m.gmane.org; Mon, 07 May 2012 16:07:01 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:40922) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SRUCx-0000Rh-2F for emacs-devel@gnu.org; Mon, 07 May 2012 16:07:00 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SRUCu-0007Xq-A7 for emacs-devel@gnu.org; Mon, 07 May 2012 16:06:58 -0400 Original-Received: from moutng.kundenserver.de ([212.227.17.9]:53735) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SRUCu-0007XW-06 for emacs-devel@gnu.org; Mon, 07 May 2012 16:06:56 -0400 Original-Received: from theowa.merten-home.homelinux.org (ip-109-84-0-67.web.vodafone.de [109.84.0.67]) by mrelayeu.kundenserver.de (node=mreu1) with ESMTP (Nemesis) id 0LfWbl-1Rm4iS38qP-00p925; Mon, 07 May 2012 22:06:54 +0200 Original-Received: by theowa.merten-home.homelinux.org (Postfix, from userid 1000) id BC721401D4; Mon, 7 May 2012 22:06:46 +0200 (CEST) Original-Received: from theowa.merten-home.homelinux.org (localhost [127.0.0.1]) by theowa.merten-home.homelinux.org (Postfix) with ESMTP id BA1F77A007 for ; Mon, 7 May 2012 22:06:46 +0200 (CEST) In-reply-to: Comments: In-reply-to Stefan Monnier message dated "Mon, 30 Apr 2012 11:02:38 -0400." X-Mailer: MH-E 8.2; nmh 1.3; GNU Emacs 23.1.1 X-Provags-ID: V02:K0:X4TYCQwT7kf1Fit6TPdNniZWl6R9F93I+Z96rcYiBxN o7Z0jllrI6A2PZhSDCDsIx2AxhqKmX1RIafLSqLB2Fwl3+RgS0 ExdYvy8hiqiuMkdvTRNL8jpqV/8N2tecKkS4QKOlGMX6Y51FlQ bQfbkt5AELLKljCOKEzZOaQDtZG92DS28jlQtOy6F1uMj4xeE7 xTJxV5r5LiFb/QaeRfngJZNQbVVxDi+FeukPvcOe0zOLyPvT+0 r/niutDK8WgPdv8alj0C2q25ogCdePoqu1rxhK5em5ScF9EI/w bAI9fai1uytHungU6MSRO+vjV5ugJ4PrZjPVLbFYYIA+lgxawr a1Ddc+8zu1zOTBgNXUpZpXU79Lcgl9oAxP4ZZ3soYQagCdL8Y4 4CU/TMFl+oWgfZ4Ulnu9iaoHTy0DyNOHpY= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 212.227.17.9 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:150360 Archived-At: --=-=-= Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Hi all! First step is done :-) . Last week (7 days ago) Stefan Monnier wrote: >> May I commit simply the current version to Bazaar or is >> there a better way? Also a review of the current version by you may >> make sense. >=20 > It's basically just a merge, so I don't see any need to do it in more > than a single commit. Just committed. I'd appreciate a thorough review. After that I'd commit a few smaller changes from latest development. > But please try to keep some reference to the > "common ancestor" and "tip" of the branch being merged (that's done > automatically as Bzr metadata when it's a normal merge, but I suspect in > your case the branch from which you merge is external). I did this in the log message including a reference to the Docutils subversion revision. >> According to the GNU Coding Standards I need to write a ChangeLog >> entry. I don't see this makes much sense for such a large patch - at >> least not in the way ChangeLog entries are done according to the GNU >> Coding Standards. So how to construct a ChangeLog entry which complies >> with the standards but makes sense? >=20 > Sometimes following the normal ChangeLog rules leads to surprisingly > manageable results even for large patches. E.g. all new functions are > just listed as "new function" without any explanation of what they do, > so it can stay fairly concise (and even more so for new files, tho > I suspect in your case that won't help). >=20 > But if the normal ChangeLog is large, we usually try to shorten it with > things like "adjust all callers" which saves us from mentioning each one > of the callers when changing a calling convention or a function name. >=20 > Finally, I assume that you do have some kind of ChangeLog already (in > the form of a list of commit messages), so you might want to just > reformat those to fit the ChangeLog conventions and not spend too much > time making them concise: after all, it doesn't hurt much if the commit > message is more verbose than necessary. I worked on this and think I ended up in a pretty good result. I used my result as a log message. >> My work at rst.el also resulted in some new features. Where to put a >> description of these features? I think this will be most interesting >> for a new version of Emacs. >=20 > Put them in etc/NEWS. I did this in the same commit. I hope I did it right. Gr=FC=DFe Stefan --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iQCVAwUBT6grVgnTZgC3zSk5AQJQTgP/YfI+Jpm5mFEvmhv1nQl1LOTBkLWVfzMG 5H0H8uaSaCDd2chAlx1RWt/TrUqyLDoDYTtTgzMQqhoDS1JRKmhnlPxNcYt11Q5S C70RMgp6bx5OGGdXOMyNPdXk0vlY6wyhY8nv9/Qo4QpuxBh5uGIp8Z2lt6VGhZex ur/NMGMV/X8= =Pv/U -----END PGP SIGNATURE----- --=-=-=--