From: Stefan Merten <smerten@oekonux.de>
To: emacs-devel@gnu.org
Subject: Re: Re-including rst.el into Emacs repository
Date: Mon, 07 May 2012 22:06:46 +0200 [thread overview]
Message-ID: <7259.1336421206@theowa.merten-home.homelinux.org> (raw)
In-Reply-To: <jwvwr4x9td1.fsf-monnier+emacs@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 2448 bytes --]
Hi all!
First step is done :-) .
Last week (7 days ago) Stefan Monnier wrote:
>> May I commit simply the current version to Bazaar or is
>> there a better way? Also a review of the current version by you may
>> make sense.
>
> It's basically just a merge, so I don't see any need to do it in more
> than a single commit.
Just committed. I'd appreciate a thorough review.
After that I'd commit a few smaller changes from latest development.
> But please try to keep some reference to the
> "common ancestor" and "tip" of the branch being merged (that's done
> automatically as Bzr metadata when it's a normal merge, but I suspect in
> your case the branch from which you merge is external).
I did this in the log message including a reference to the Docutils
subversion revision.
>> According to the GNU Coding Standards I need to write a ChangeLog
>> entry. I don't see this makes much sense for such a large patch - at
>> least not in the way ChangeLog entries are done according to the GNU
>> Coding Standards. So how to construct a ChangeLog entry which complies
>> with the standards but makes sense?
>
> Sometimes following the normal ChangeLog rules leads to surprisingly
> manageable results even for large patches. E.g. all new functions are
> just listed as "new function" without any explanation of what they do,
> so it can stay fairly concise (and even more so for new files, tho
> I suspect in your case that won't help).
>
> But if the normal ChangeLog is large, we usually try to shorten it with
> things like "adjust all callers" which saves us from mentioning each one
> of the callers when changing a calling convention or a function name.
>
> Finally, I assume that you do have some kind of ChangeLog already (in
> the form of a list of commit messages), so you might want to just
> reformat those to fit the ChangeLog conventions and not spend too much
> time making them concise: after all, it doesn't hurt much if the commit
> message is more verbose than necessary.
I worked on this and think I ended up in a pretty good result. I used
my result as a log message.
>> My work at rst.el also resulted in some new features. Where to put a
>> description of these features? I think this will be most interesting
>> for a new version of Emacs.
>
> Put them in etc/NEWS.
I did this in the same commit. I hope I did it right.
Grüße
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 307 bytes --]
next prev parent reply other threads:[~2012-05-07 20:06 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-30 13:29 Re-including rst.el into Emacs repository Stefan Merten
2012-04-30 13:37 ` Deniz Dogan
2012-04-30 15:02 ` Stefan Monnier
2012-05-07 20:06 ` Stefan Merten [this message]
2012-05-08 1:42 ` Stefan Monnier
2012-05-29 20:30 ` Stefan Merten
2012-05-30 2:36 ` Stefan Monnier
2012-05-30 19:15 ` Stefan Merten
2012-05-31 18:15 ` Glenn Morris
2012-05-31 19:22 ` Leo
2012-06-02 12:16 ` Wrong direction of C-M-a/e in rst-mode (was: Re: Re-including rst.el into Emacs repository) Stefan Merten
2012-06-03 2:08 ` Wrong direction of C-M-a/e in rst-mode Leo
2012-06-02 10:05 ` Using cl in rst.el and elsewhere (was: Re: Re-including rst.el into Emacs repository) Stefan Merten
2012-06-02 19:15 ` Using cl in rst.el and elsewhere Glenn Morris
2012-06-03 3:23 ` Stefan Monnier
2012-06-03 3:57 ` Leo
2012-06-02 19:56 ` Stefan Monnier
2012-06-03 2:21 ` Leo
2012-06-03 3:12 ` Miles Bader
2012-06-03 13:41 ` Stefan Merten
2012-06-03 13:47 ` Pascal J. Bourguignon
2012-06-03 15:15 ` Stefan Monnier
2012-06-03 18:30 ` Richard Stallman
2012-06-04 13:23 ` Stefan Monnier
2012-06-05 19:38 ` Stefan Merten
2012-05-02 16:59 ` Re-including rst.el into Emacs repository Barry Warsaw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7259.1336421206@theowa.merten-home.homelinux.org \
--to=smerten@oekonux.de \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.