From: Yuan Fu <casouri@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel <emacs-devel@gnu.org>, Eli Zaretskii <eliz@gnu.org>
Subject: Re: master c69858b3f0: ; * lisp/treesit.el (treesit-ready-p): Guard against empty buffers.
Date: Tue, 22 Nov 2022 18:18:43 -0800 [thread overview]
Message-ID: <7230A71A-F300-4645-AE57-A1EF60EA5FF8@gmail.com> (raw)
In-Reply-To: <jwvwn7mv3pp.fsf-monnier+emacs@gnu.org>
> On Nov 22, 2022, at 5:51 PM, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
>
>> - (when (> (position-bytes (1- (point-max))) treesit-max-buffer-size)
>> + (when (> (position-bytes (max (point-min) (1- (point-max))))
>> + treesit-max-buffer-size)
>
> I'd expect `treesit-max-buffer-size` to be compared to `buffer-size`
> rather than to buffer positions.
> Is it really that important to count bytes rather than characters?
I’m not sure, I’ll leave Eli to explain his intention :-)
Yuan
next prev parent reply other threads:[~2022-11-23 2:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <166916717199.12853.3816069320355351676@vcs2.savannah.gnu.org>
[not found] ` <20221123013252.46814C004B6@vcs2.savannah.gnu.org>
2022-11-23 1:51 ` master c69858b3f0: ; * lisp/treesit.el (treesit-ready-p): Guard against empty buffers Stefan Monnier
2022-11-23 2:18 ` Yuan Fu [this message]
2022-11-23 12:27 ` Eli Zaretskii
2022-11-23 12:40 ` Stefan Monnier
2022-11-23 13:38 ` Eli Zaretskii
2022-11-23 14:57 ` Stefan Monnier
2022-11-23 15:25 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7230A71A-F300-4645-AE57-A1EF60EA5FF8@gmail.com \
--to=casouri@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.