update to zoom-frame.el for emacs-24?

update to zoom-frame.el for emacs-24?

[Neal Becker]

I'm using zoom-frame.el to bind font resizing to S-mousewheel, which acts like 
many modern window apps.

But on 24.0.92, I see:
enlarge-font: Symbol's function definition is void: frame-update-faces

Suggestions?

Re: update to zoom-frame.el for emacs-24?

[Juanma Barranquero]

On Tue, Dec 20, 2011 at 15:17, Neal Becker <ndbecker2@gmail.com> wrote:

> But on 24.0.92, I see:
> enlarge-font: Symbol's function definition is void: frame-update-faces
>
> Suggestions?

frame-update-faces has been removed, and was previously aliased to
`ignore' since Emacs 21.1.

So just skip calling it if it is not defined, or define an alias yourself:

(unless (fboundp 'frame-update-faces)
  (defalias 'frame-update-faces 'ignore))

    Juanma

Re: update to zoom-frame.el for emacs-24?

[Neal Becker]

Juanma Barranquero wrote:

> On Tue, Dec 20, 2011 at 15:17, Neal Becker <ndbecker2@gmail.com> wrote:
> 
>> But on 24.0.92, I see:
>> enlarge-font: Symbol's function definition is void: frame-update-faces
>>
>> Suggestions?
> 
> frame-update-faces has been removed, and was previously aliased to
> `ignore' since Emacs 21.1.
> 
> So just skip calling it if it is not defined, or define an alias yourself:
> 
> (unless (fboundp 'frame-update-faces)
>   (defalias 'frame-update-faces 'ignore))
> 
> Juanma

Thanks!  I found a copy of emacs 23, and found that C-h f told me the function 
was obsolete.

But I don't think I ever saw a message when using emacs 23 telling me it was 
obsolete.  Is there not a mechanism in emacs to give warnings when functions are 
to be obsoleted?

Re: update to zoom-frame.el for emacs-24?

[Juanma Barranquero]

On Tue, Dec 20, 2011 at 16:05, Neal Becker <ndbecker2@gmail.com> wrote:

> But I don't think I ever saw a message when using emacs 23 telling me it was
> obsolete.  Is there not a mechanism in emacs to give warnings when functions are
> to be obsoleted?

The byte-compiler certainly warns:

  C:\emacs\releases> type test.el
  (frame-update-faces)

  C:\emacs\releases> .\23.3\bin\emacs.exe -Q -batch -f
batch-byte-compile test.el

  In toplevel form:
  test.el:1:2:Warning: `frame-update-faces' is an obsolete function (as of Emacs
      21.1); no longer necessary.
  Wrote c:/emacs/releases/test.elc

    Juanma

Re: update to zoom-frame.el for emacs-24?

[Kevin Rodgers]

On 12/20/11 8:05 AM, Neal Becker wrote:
> Juanma Barranquero wrote:
>
>> On Tue, Dec 20, 2011 at 15:17, Neal Becker<ndbecker2@gmail.com>  wrote:
>>
>>> But on 24.0.92, I see:
>>> enlarge-font: Symbol's function definition is void: frame-update-faces
>>>
>>> Suggestions?
>>
>> frame-update-faces has been removed, and was previously aliased to
>> `ignore' since Emacs 21.1.
>>
>> So just skip calling it if it is not defined, or define an alias yourself:
>>
>> (unless (fboundp 'frame-update-faces)
>>    (defalias 'frame-update-faces 'ignore))
>>
>> Juanma
>
> Thanks!  I found a copy of emacs 23, and found that C-h f told me the function
> was obsolete.
>
> But I don't think I ever saw a message when using emacs 23 telling me it was
> obsolete.  Is there not a mechanism in emacs to give warnings when functions are
> to be obsoleted?

You will be warned if/when you byte compile the code.

-- 
Kevin Rodgers
Denver, Colorado, USA

RE: update to zoom-frame.el for emacs-24?

[Drew Adams]

> I'm using zoom-frame.el to bind font resizing to 
> S-mousewheel, which acts like many modern window apps.
> 
> But on 24.0.92, I see:
> enlarge-font: Symbol's function definition is void: frame-update-faces
> 
> Suggestions?

My crystal ball tells me you are using library zoom-frm.el (not zoom-frame.el),
and that requires library frame-cmds.el, which does use `frame-update-faces'.
But it uses that function only for Emacs releases before 21:

 (when (< emacs-major-version 21) (frame-update-faces frame))  

So you seem to be using an old copy of frame-cmds.el (and perhaps zoom-frm.el as
well?).  You can update to the latest here:
http://www.emacswiki.org/emacs/download/frame-cmds.el
http://www.emacswiki.org/emacs/download/zoom-frm.el