From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Aaron Zeng" Newsgroups: gmane.emacs.bugs Subject: bug#71424: 29.3; auto-revert-use-notify buggy interaction with indirect buffers Date: Sat, 08 Jun 2024 13:06:28 -0400 Message-ID: <718012e2-b09e-40e1-921f-d94c3aadf0d1@app.fastmail.com> References: <87ed98caci.fsf@bcc32.com> <86h6e3ex13.fsf@gnu.org> <01d36245-763b-43e8-93f8-679f176fedd0@app.fastmail.com> <86zfrvbdsz.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15519"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Cyrus-JMAP/3.11.0-alpha0-497-g97f96844c-fm-20240526.001-g97f96844 Cc: 71424@debbugs.gnu.org To: "Eli Zaretskii" , "Michael Albinus" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 08 19:07:59 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sFzXp-0003l4-QY for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 08 Jun 2024 19:07:58 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sFzXg-0005MA-0u; Sat, 08 Jun 2024 13:07:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sFzXf-0005Lf-4R for bug-gnu-emacs@gnu.org; Sat, 08 Jun 2024 13:07:47 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sFzXe-00088p-Sg for bug-gnu-emacs@gnu.org; Sat, 08 Jun 2024 13:07:46 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sFzXt-0003cy-NG for bug-gnu-emacs@gnu.org; Sat, 08 Jun 2024 13:08:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Aaron Zeng" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 08 Jun 2024 17:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71424 X-GNU-PR-Package: emacs Original-Received: via spool by 71424-submit@debbugs.gnu.org id=B71424.171786643413866 (code B ref 71424); Sat, 08 Jun 2024 17:08:01 +0000 Original-Received: (at 71424) by debbugs.gnu.org; 8 Jun 2024 17:07:14 +0000 Original-Received: from localhost ([127.0.0.1]:39353 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFzX7-0003bZ-KB for submit@debbugs.gnu.org; Sat, 08 Jun 2024 13:07:13 -0400 Original-Received: from fhigh5-smtp.messagingengine.com ([103.168.172.156]:46117) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFzX5-0003bK-Oc for 71424@debbugs.gnu.org; Sat, 08 Jun 2024 13:07:12 -0400 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 76A0211400E0; Sat, 8 Jun 2024 13:06:50 -0400 (EDT) Original-Received: from imap46 ([10.202.2.96]) by compute4.internal (MEProxy); Sat, 08 Jun 2024 13:06:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bcc32.com; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1717866410; x=1717952810; bh=mgrFsO066d CdfTEapUrBezJwCwrLlJyiWWCEzhiCGcY=; b=NhkqUzGT0uWkqv/d8MuM307mzN 8g9sR2j4lzd2fQ1kvPyoTqofHllsrBpKBnS1k8jZs2BxFGylK0UdM7fR/K40xbv4 fKCAK3RFm7NZygb6t7GLS1CBLeUn/qmM9HqHAIs1KTtrYPD24k2aHpXUtC0xpt7e BvXnk7CfxXXSCJC3Yjp06AHNSVMNVgOxb0mfgAsJu1RODfG1Qpt/jvNm6RUJZ4N1 j4308gfY1pqinoC0p+t20ps27wB2b+1m29/MCjUNmTt41MtbBtAI62ITIIxIVdaA 3RzfKmW+Imjtssjd3FKb00dNoLE6E0U/Y4EF5BWm6e1fIWGZZtclcEhyC6OA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1717866410; x=1717952810; bh=mgrFsO066dCdfTEapUrBezJwCwrL lJyiWWCEzhiCGcY=; b=iuTEEJXqzO+9o4JGWD+wyAzwf4XBd9MkMv66KNdoQn39 cgmeuTFsuOgoaHCp0Kf8u/15FdnDsDNpnjx9tl7Y5SCa/pJJRIoMC+5Lfc+wlJ+1 i2dR/lLu5kmRBHk9oY0O6PdySCV1EohZVtk6ebP420dvsDVIL3YDCIF5wTnsAQsW 4SRN9YcFzAqMthvp4hGtv9zlw14bf5cbCpT1DDC2xIEZiuDgJpdSFU33+2edcUBm ixC7Sdr5P9cnLcUQrFaykZvlcerwmEf7hWZK/2cJFuY4fSSppgbKnPatGkiuIbhl 6bZXoCOXmyKBiEjNd34ZtF3NYp0QQHqAx90BzjIOYQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrfedtgedggeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftegr rhhonhcukggvnhhgfdcuoeiisegstggtfedvrdgtohhmqeenucggtffrrghtthgvrhhnpe dttdeuhfeujeegjefhvefhfeefhfegjefhtefhgeffleekheegkefgleehgedtjeenucev lhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpeiisegstggtfe dvrdgtohhm X-ME-Proxy: Feedback-ID: iba994645:Fastmail Original-Received: by mailuser.nyi.internal (Postfix, from userid 501) id 17D992A20077; Sat, 8 Jun 2024 13:06:50 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface In-Reply-To: <86zfrvbdsz.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286880 Archived-At: On Sat, Jun 8, 2024, at 12:27, Eli Zaretskii wrote: > diff --git a/lisp/autorevert.el b/lisp/autorevert.el > index a23d536..ab69add 100644 > --- a/lisp/autorevert.el > +++ b/lisp/autorevert.el > @@ -378,8 +378,11 @@ auto-revert-debug > (defun auto-revert-remove-current-buffer (&optional buffer) > "Remove BUFFER from `auto-revert-buffer-list'. > BUFFER defaults to `current-buffer'." > - (setq auto-revert-buffer-list > - (delq (or buffer (current-buffer)) auto-revert-buffer-list))) > + (let ((buf (or buffer (current-buffer)))) > + ;; Don't remove the watch if we are killing an indirect buffer. > + (or (buffer-base-buffer buf) > + (setq auto-revert-buffer-list > + (delq buf auto-revert-buffer-list))))) (take my reply with a grain of salt---I'm not that familiar with this code). I think this will leave killed buffers in auto-revert-buffer-list, which seems wrong to me. > ;;;###autoload > (define-minor-mode auto-revert-mode > @@ -639,7 +642,9 @@ auto-revert-set-timer > > (defun auto-revert-notify-rm-watch () > "Disable file notification for current buffer's associated file." > - (when-let ((desc auto-revert-notify-watch-descriptor)) > + (when-let ((desc > + (and (buffer-base-buffer) > + auto-revert-notify-watch-descriptor))) > (setq auto-revert--buffer-by-watch-descriptor > (assoc-delete-all desc auto-revert--buffer-by-watch-descriptor)) > (ignore-errors Maybe I'm reading the code wrong, but should this be (not (buffer-base-buffer)) instead?