From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: Should project delegate project-find-regexp? Date: Thu, 7 Apr 2022 17:30:21 +0300 Message-ID: <7147b499-0df5-6307-54ee-387f35ef9dcf@yandex.ru> References: <86bkxdf71q.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25041"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 To: Joel Reicher , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Apr 07 16:32:54 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ncTBu-0006PQ-2E for ged-emacs-devel@m.gmane-mx.org; Thu, 07 Apr 2022 16:32:54 +0200 Original-Received: from localhost ([::1]:50884 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ncTBs-0003se-L7 for ged-emacs-devel@m.gmane-mx.org; Thu, 07 Apr 2022 10:32:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36742) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ncT9Z-0001x3-Rm for emacs-devel@gnu.org; Thu, 07 Apr 2022 10:30:31 -0400 Original-Received: from mail-ej1-x62d.google.com ([2a00:1450:4864:20::62d]:41660) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ncT9W-000279-VB for emacs-devel@gnu.org; Thu, 07 Apr 2022 10:30:28 -0400 Original-Received: by mail-ej1-x62d.google.com with SMTP id bh17so11214060ejb.8 for ; Thu, 07 Apr 2022 07:30:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=oolaqzpfedyzLWONRrffZMJtdMxs5iACuv0WB9s3kW0=; b=nRzR2PQEefFReXl5+8rvB/q8S6ltcBnpGQQ1MMaJrj1hW4d+qKYO5axUvnZy8S6lxo +VYcPjzrVnADy/osOKdFUG7cSfSdGomTJfh2ORZrzljKjJENlHu4XZ8nrLou21flxSkq cvUOumB15T9YFO8o4XluXvENzevzjYHolrZzEONdDtg9JMl2FG4IoDMV7Grwi/EcDubN dVnB0yp6kkmeVCvSaDhm/0XERIvUxsTTke+M0IUCNNWpnkt7lB15A6HIafNzrUzM/z74 g28XN8eOvHP2nfx788afhn9zL3t1O+exSpsYFB3Exbc5e7aJ77F7nu6xbicXfvmzPOt/ 1YeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=oolaqzpfedyzLWONRrffZMJtdMxs5iACuv0WB9s3kW0=; b=RqBB1lHmCfgKAHNtGWXvu2c+Jd4wP8dJ98qDGgVgGrI3j7iKbU5fGIMhCnx+d1ySaB pN/n9e4hfgUiW/cN5pb90Gbsmluf93Y8IT//eXQ129gJRaHf4CQoDpEmnCjtu53oAUym tF9nuWcwFtflToMpfZ9088XsQJLfFsqFx7VRLyYlsxyZXeWxppjSRU6063mBNtYUTD6K D+oudI519jQ9TQeBsognl5GewXKdgcwyJ7Pz9WJ177p8GfTRoJM8pwMn64byEoq6rjP2 KMvWgsATpo4/VlMWoz8BLo8/r0tTXKwl0QSsfzcy8BwnIKyTfKvgYRTGWkVVMImGBzKZ r/AQ== X-Gm-Message-State: AOAM530E4MFtUs11L82ZcPK/cswSLGngliRU2IGHvEoi6L9VM5vvoVYU iLlOysKQZBTmAjckSbFVXVk= X-Google-Smtp-Source: ABdhPJwzsFKaTx4+DnLInayCageCdACOHyA6qOJrb8EfzWm7aglErDZnvsZ7Q8dgwloXCrE1/yYnIA== X-Received: by 2002:a17:907:8a05:b0:6e8:441c:358d with SMTP id sc5-20020a1709078a0500b006e8441c358dmr452307ejc.77.1649341823952; Thu, 07 Apr 2022 07:30:23 -0700 (PDT) Original-Received: from [192.168.236.48] ([173.237.64.48]) by smtp.googlemail.com with ESMTPSA id j22-20020a50ed16000000b00419366b2146sm9572337eds.43.2022.04.07.07.30.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Apr 2022 07:30:23 -0700 (PDT) Content-Language: en-US In-Reply-To: <86bkxdf71q.fsf@gmail.com> Received-SPF: pass client-ip=2a00:1450:4864:20::62d; envelope-from=raaahh@gmail.com; helo=mail-ej1-x62d.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287888 Archived-At: On 07.04.2022 14:48, Joel Reicher wrote: > It seems to me that, at least in the case of git, 'git grep' offers a superior implementation to anything offered by the generic implementation of project-find-regexp. Last I checked, there was no way to make 'git grep' search in untracked files. That would be a violation of the contract. And of course we'd have to spend the effort to teach it about user-customized error patterns. If 'git ls-files' + 'xargs rg' gives similar performance, that's probably good enough. Though serializing the list of files back and forth adds its overhead, which is unfortunate.