all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Mattias Engdegård" <mattias.engdegard@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Emacs Devel <emacs-devel@gnu.org>
Subject: Re: master e56e4b345a2: Use timer accessors instead of aref/aset
Date: Tue, 30 Jul 2024 23:01:16 +0200	[thread overview]
Message-ID: <71459340-7F98-4582-AFB3-4F02E993D8F1@gmail.com> (raw)
In-Reply-To: <jwv8qxi912v.fsf-monnier+emacs@gnu.org>

30 juli 2024 kl. 20.43 skrev Stefan Monnier <monnier@iro.umontreal.ca>:

> `vhdl-mode.el` likes to be compatible with XEmacs, so this change might
> be problematic.  I'm not sure if it's still important, but I'll also
> note that, according to my reading of the `timer.el` code, the timer
> objects returned by `run-with-idle-timer` already have their `triggered`
> field set to nil.
> 
> I'm not sure if it's always been the case, but maybe we could make the
> `aset` conditional on `(< emacs-major-version 30)` (or some older version
> number once we investigate since when this is the case)?

Thank you, yes, I agree but kept the original code for XEmacs only. (Even that is a stretch, given that XEmacs users are not very likely to use our version.)

Do modify the code if you find it reckless.




      reply	other threads:[~2024-07-30 21:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <172191126257.28696.12556479493109361955@vcs2.savannah.gnu.org>
     [not found] ` <20240725124103.A15EBC35350@vcs2.savannah.gnu.org>
2024-07-30 18:43   ` master e56e4b345a2: Use timer accessors instead of aref/aset Stefan Monnier
2024-07-30 21:01     ` Mattias Engdegård [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=71459340-7F98-4582-AFB3-4F02E993D8F1@gmail.com \
    --to=mattias.engdegard@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.