From mboxrd@z Thu Jan  1 00:00:00 1970
Path: main.gmane.org!not-for-mail
From: "Eli Zaretskii" <eliz@elta.co.il>
Newsgroups: gmane.emacs.devel
Subject: Re: list-colors-display: filter same adjecent colors
Date: Sat, 06 Mar 2004 10:51:50 +0200
Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org
Message-ID: <7137-Sat06Mar2004105150+0200-eliz@elta.co.il>
References: <20040305234919.33704.qmail@web60305.mail.yahoo.com>
Reply-To: Eli Zaretskii <eliz@elta.co.il>
NNTP-Posting-Host: deer.gmane.org
X-Trace: sea.gmane.org 1078913667 17768 80.91.224.253 (10 Mar 2004 10:14:27 GMT)
X-Complaints-To: usenet@sea.gmane.org
NNTP-Posting-Date: Wed, 10 Mar 2004 10:14:27 +0000 (UTC)
Cc: emacs-devel@gnu.org
Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Wed Mar 10 11:14:15 2004
Return-path: <emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org>
Original-Received: from quimby.gnus.org ([80.91.224.244])
	by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian))
	id 1B10j9-0000K2-00
	for <emacs-devel@deer.gmane.org>; Wed, 10 Mar 2004 11:14:15 +0100
Original-Received: from monty-python.gnu.org ([199.232.76.173])
	by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian))
	id 1B10j8-0005o7-00
	for <emacs-devel@quimby.gnus.org>; Wed, 10 Mar 2004 11:14:15 +0100
Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org)
	by monty-python.gnu.org with esmtp (Exim 4.30)
	id 1B10hk-0006Wj-2M
	for emacs-devel@quimby.gnus.org; Wed, 10 Mar 2004 05:12:48 -0500
Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30)
	id 1AzXZ9-0003pB-Jl
	for emacs-devel@gnu.org; Sat, 06 Mar 2004 03:53:51 -0500
Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30)
	id 1AzXYb-0003db-0D
	for emacs-devel@gnu.org; Sat, 06 Mar 2004 03:53:48 -0500
Original-Received: from [192.114.186.18] (helo=bilbo.inter.net.il)
	by monty-python.gnu.org with esmtp (Exim 4.30) id 1AzXYa-0003Yf-FI
	for emacs-devel@gnu.org; Sat, 06 Mar 2004 03:53:16 -0500
Original-Received: from zaretski (pns03-197-129.inter.net.il [80.230.197.129])
	by bilbo.inter.net.il (MOS 3.4.4-GR) with ESMTP id COK84331;
	Sat, 6 Mar 2004 10:52:57 +0200 (IST)
Original-To: Michael Mauger <mmaug@yahoo.com>
X-Mailer: emacs 21.3.50 (via feedmail 8 I) and Blat ver 1.8.9
In-reply-to: <20040305234919.33704.qmail@web60305.mail.yahoo.com> (message
	from Michael Mauger on Fri, 5 Mar 2004 15:49:19 -0800 (PST))
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Emacs development discussions.  <emacs-devel.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org
Xref: main.gmane.org gmane.emacs.devel:20288
X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:20288

> Date: Fri, 5 Mar 2004 15:49:19 -0800 (PST)
> From: Michael Mauger <mmaug@yahoo.com>
> 
> How does this patch look:

It's okay with me, but I'd suggest to give an explicit example in
this comment:

> +    ;; Identify duplicate colors by the name rather than the color
> +    ;; value.  On w32, logical colors are added to the list that might
> +    ;; have the same value but have different names and meanings.
> +    ;; Detecting duplicates by name insures that all of these logical
> +    ;; colors remain despite similar color values.

I'd mention the special ``system'' colors and why they are important,
just so people could see a specific example.

Thanks.