all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Eli Zaretskii" <eliz@elta.co.il>
Cc: emacs-devel@gnu.org
Subject: Re: list-colors-display: filter same adjecent colors
Date: Sat, 06 Mar 2004 10:51:50 +0200	[thread overview]
Message-ID: <7137-Sat06Mar2004105150+0200-eliz@elta.co.il> (raw)
In-Reply-To: <20040305234919.33704.qmail@web60305.mail.yahoo.com> (message from Michael Mauger on Fri, 5 Mar 2004 15:49:19 -0800 (PST))

> Date: Fri, 5 Mar 2004 15:49:19 -0800 (PST)
> From: Michael Mauger <mmaug@yahoo.com>
> 
> How does this patch look:

It's okay with me, but I'd suggest to give an explicit example in
this comment:

> +    ;; Identify duplicate colors by the name rather than the color
> +    ;; value.  On w32, logical colors are added to the list that might
> +    ;; have the same value but have different names and meanings.
> +    ;; Detecting duplicates by name insures that all of these logical
> +    ;; colors remain despite similar color values.

I'd mention the special ``system'' colors and why they are important,
just so people could see a specific example.

Thanks.

  reply	other threads:[~2004-03-06  8:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-24  3:43 list-colors-display: filter same adjecent colors Michael Mauger
2004-02-24  6:43 ` Eli Zaretskii
2004-03-05 23:49   ` Michael Mauger
2004-03-06  8:51     ` Eli Zaretskii [this message]
2004-04-06  3:08       ` Michael Mauger
2004-04-15 13:18         ` Eli Zaretskii
  -- strict thread matches above, loose matches on Subject: below --
2004-05-18 21:13 Michael Mauger
2004-05-20 17:55 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7137-Sat06Mar2004105150+0200-eliz@elta.co.il \
    --to=eliz@elta.co.il \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.