From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#34949: 27.0.50; Docstring of `vc-deduce-fileset' incomplete Date: Wed, 25 Mar 2020 23:59:46 +0200 Message-ID: <7124e9e5-bf3a-5bba-d9f9-9d0867444e4c@yandex.ru> References: <87sgizy16y.fsf@mail.linkov.net> <1f31a329-eaee-f704-9a58-1b048a6ee636@yandex.ru> <87fteyl64x.fsf@mail.linkov.net> <47fcc86a-a884-0658-d1cb-8666704924e8@yandex.ru> <87o8tkgbe2.fsf@mail.linkov.net> <8736avy640.fsf@mail.linkov.net> <76e52ade-bb44-427a-0910-3fe3cf65bf6d@yandex.ru> <87a751uonw.fsf@mail.linkov.net> <9bab3a53-ec31-3300-132f-dc1e17ee0c53@yandex.ru> <875zfd9lzm.fsf@mail.linkov.net> <87mu8mieve.fsf@mail.linkov.net> <87k13pkxdl.fsf@mail.linkov.net> <207d4e30-aa59-b8eb-c39a-0957757f39eb@yandex.ru> <875zf6cy3w.fsf@mail.linkov.net> <9c39f788-29f1-5a68-c8f3-a4b08ae9ea3b@yandex.ru> <87lfo1dvcf.fsf@mail.linkov.net> <44cda45a-db93-f2c1-626d-9ace68cd6fd1@yandex.ru> <87y2rpqt28.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="44896"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 Cc: Lars Ingebrigtsen , 34949@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Mar 25 23:00:35 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jHE4g-000BaQ-LK for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 25 Mar 2020 23:00:34 +0100 Original-Received: from localhost ([::1]:43844 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jHE4e-0008Hj-Gm for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 25 Mar 2020 18:00:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52477) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jHE4C-0007sq-Ni for bug-gnu-emacs@gnu.org; Wed, 25 Mar 2020 18:00:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jHE4B-00087d-HZ for bug-gnu-emacs@gnu.org; Wed, 25 Mar 2020 18:00:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51962) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jHE4B-00087K-CW for bug-gnu-emacs@gnu.org; Wed, 25 Mar 2020 18:00:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jHE4B-0001Rr-Bp for bug-gnu-emacs@gnu.org; Wed, 25 Mar 2020 18:00:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Mar 2020 22:00:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34949 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 34949-submit@debbugs.gnu.org id=B34949.15851735985518 (code B ref 34949); Wed, 25 Mar 2020 22:00:03 +0000 Original-Received: (at 34949) by debbugs.gnu.org; 25 Mar 2020 21:59:58 +0000 Original-Received: from localhost ([127.0.0.1]:57934 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jHE46-0001Qu-3Q for submit@debbugs.gnu.org; Wed, 25 Mar 2020 17:59:58 -0400 Original-Received: from mail-wm1-f43.google.com ([209.85.128.43]:35690) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jHE44-0001Qg-3Y for 34949@debbugs.gnu.org; Wed, 25 Mar 2020 17:59:56 -0400 Original-Received: by mail-wm1-f43.google.com with SMTP id m3so4926707wmi.0 for <34949@debbugs.gnu.org>; Wed, 25 Mar 2020 14:59:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=yAPfYXlOKknB36V8fhqulHvQhcg8hWye2bQqtfeRT6w=; b=dI4jJ5+wW0yu+P4qI+udEzfklNUVEdJNOPNqp3in+l3EnuF1lQRE56ISJPtg9CMvCD zLKvZBg45IYUFXr46jRbAp1kIZiXJNP4+FvfN2GESVYE17Kx2HCI/16htJfOIu5lsvRj b6tvNR5kQfWCZ2iqdcw1mRheRZ35LTI+dNJso2KIZiQBXK4OKeW+3EgbM21ycXbvyjpH gqj4O1mXXhZX6TPScXJIaZO2mlbfM04ALZPoz7FvpAUgT8I/wf1ZA8kCv74+/GMvLree f0UAd+XKOq6zFbRMIU4Xb2ZIlynic1aTXhIvSQMob2OLD5OsnqCFVXGBz9Mh9Y1cPV8Z //Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=yAPfYXlOKknB36V8fhqulHvQhcg8hWye2bQqtfeRT6w=; b=ISnQym6kQmCNi1dbuEkhzSJ9KUh5Q+haSujc+awRn1BaEPZtJmLbpo+W2VS0I79HH7 M5x3+Zj3ugD22JYvW5owRvWXsIRG9P6fJ+/4uDYs00F+ngVn8+Kg/Pv5QhtvecIM7Z3j R4jlsCpSEQyRxkQrkoUln/nVoNhBMij7vPr2vV9+7B3GHwtG27sqPP9/nF/LNkkVPhr7 BQ9SfxfcFM8g16Rtq6vTnXIQoCc17lpJgDCwZAyvquRx8KfKqsOGLCknY37LaD05yvSO nEG8NjXsUsdPlEtPwER4ZupwNeqwM+o5TtZTjvxx1tzoEA9Hk8BJRhADwe+pniLY3Dbj 1JMQ== X-Gm-Message-State: ANhLgQ0sLcgmhkbkaJG05qca3HEQlPipioXSsPBDS7IoNU23EmjMmzxF U59TxMBBydTkZ7RFjbzuMATZoH4e X-Google-Smtp-Source: ADFU+vv7CJVy72J3uX39dj37wUidiWbUV523oV2Hr/PYPUhnhfOgtet4MXOsqvSpTyO/GDDUyu6ZIw== X-Received: by 2002:a1c:e341:: with SMTP id a62mr5800779wmh.121.1585173589710; Wed, 25 Mar 2020 14:59:49 -0700 (PDT) Original-Received: from [192.168.0.2] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id l8sm582469wmj.2.2020.03.25.14.59.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Mar 2020 14:59:48 -0700 (PDT) In-Reply-To: <87y2rpqt28.fsf@mail.linkov.net> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:177735 Archived-At: On 25.03.2020 00:36, Juri Linkov wrote: > Finally settled with the following patch. LGTM, thank you. > Often this is a minor problem, but given the above, a keybinding > like `* u' should be of a little help. The follow-up patch from the next email look good as well. > - (bindings--define-key map [vc-dir] > - '(menu-item "VC Dir" vc-dir > - :help "Show the VC status of files in a directory")) > + (bindings--define-key map [vc-dir-root] > + '(menu-item "VC Dir" vc-dir-root > + :help "Show the VC status of the repository")) This part, though... Is it intentional? I'm all for it personally, but: - It will need a NEWS entry. - Are we comfortable with changing the menu entry to the new command, but keeping the old key binding pointing to the old command? Looks a bit inconsistent.