From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit Date: Sat, 23 Nov 2019 21:11:15 +0200 Message-ID: <7115df2d-c209-c672-7e92-ff682c4ec8ee@yandex.ru> References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> <83a78pxenu.fsf@gnu.org> <215302ff-8252-1f6c-5f60-aaba01cd615f@yandex.ru> <837e3tx9s8.fsf@gnu.org> <87d0di7959.fsf@linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="176406"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org To: Juri Linkov , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Nov 23 20:12:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iYapH-000jkH-Va for geb-bug-gnu-emacs@m.gmane.org; Sat, 23 Nov 2019 20:12:12 +0100 Original-Received: from localhost ([::1]:60718 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iYapG-00015O-1l for geb-bug-gnu-emacs@m.gmane.org; Sat, 23 Nov 2019 14:12:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46917) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iYap9-000156-3y for bug-gnu-emacs@gnu.org; Sat, 23 Nov 2019 14:12:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iYap8-0005sg-3i for bug-gnu-emacs@gnu.org; Sat, 23 Nov 2019 14:12:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49036) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iYap8-0005sc-0c for bug-gnu-emacs@gnu.org; Sat, 23 Nov 2019 14:12:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iYap7-0001eg-Ql for bug-gnu-emacs@gnu.org; Sat, 23 Nov 2019 14:12:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Nov 2019 19:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38044 X-GNU-PR-Package: emacs Original-Received: via spool by 38044-submit@debbugs.gnu.org id=B38044.15745362876321 (code B ref 38044); Sat, 23 Nov 2019 19:12:01 +0000 Original-Received: (at 38044) by debbugs.gnu.org; 23 Nov 2019 19:11:27 +0000 Original-Received: from localhost ([127.0.0.1]:57857 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iYaoZ-0001dt-Be for submit@debbugs.gnu.org; Sat, 23 Nov 2019 14:11:27 -0500 Original-Received: from mail-wr1-f49.google.com ([209.85.221.49]:43703) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iYaoV-0001de-OJ for 38044@debbugs.gnu.org; Sat, 23 Nov 2019 14:11:24 -0500 Original-Received: by mail-wr1-f49.google.com with SMTP id n1so12566400wra.10 for <38044@debbugs.gnu.org>; Sat, 23 Nov 2019 11:11:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=UI97pS+IbMat4y+V7cfFjM+r8TX4IdBoN5GM56j2soM=; b=Wqzz3qIj7PaNdPWgaezoi+21KglCmIbm80SvDxMkhfr1ZPEpOi7vHfBBK50SAtxgF4 v3u5qgMj69bsLae0g/KQbAsTyTySVDXlg5hoGe9E9DFOGlD/LaUi0RHtIT/LiAMdC1Ay fK4vjt40xLV1cMk+9Vao5jvzNlt7Tl6LkfCXvNHzMXeEkSUSNxvuZ01sy803ojieFAiC JJpS+XLRHlTury0Aa1HG0dICGzz1T9wB0dRa1TavWRaadpsxZd19cDACuDfQZR3E56Ca k0F9dVdPsrLwPapHLzDKro4WDHkN7c6Zrd5nzK6RC5BTuNpWsmQ1piZtbx/h7K8I8XOv MO1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=UI97pS+IbMat4y+V7cfFjM+r8TX4IdBoN5GM56j2soM=; b=typkVpsSr0y1xIbQUrbydFxhOiNjld8LN4QjM5sCm3lqt1xnSnBg+8siy08b7oOSB5 Xh8GUHqlcAv4VxsvdRmfg1NNWJQMxT2AvHWrb5bBU7BBfjYGVd4c+zy1YvTSPP4rlgs8 d2EgqUFpvugJySB2GkBOhAIc5d2bRcaLnTZV+7L2Gfrb7GatcXIzDXYDPi/GD1u4w/Ax QBrLhirj+sSOH9USVF+MtydBg8t5XHKNEllhZG1fZNmgEoVFraGdha70xkKpih/RZqrl pRNOZaOk0YaFUUoA9nDwBMw6L7LJP9mOnVtyjgHSo8895FQtTJYSY8yfMVy5r83x4IfF DfOA== X-Gm-Message-State: APjAAAWSEOVFolqeGJkqeA2krZNfM+mIuQJwW4YWqz27RU+2spnJk+f9 8Xsvj6w8ld04wqVds3Drvmo11WLD X-Google-Smtp-Source: APXvYqyG/ZQGIacQI/g++PgxolUAe5ZFeApXcTuIogyO2q7YHaPzmDsSC3XVcT1xn9IRYd5K2P8LuA== X-Received: by 2002:a5d:634e:: with SMTP id b14mr12319272wrw.255.1574536277704; Sat, 23 Nov 2019 11:11:17 -0800 (PST) Original-Received: from [192.168.0.5] ([212.50.117.215]) by smtp.googlemail.com with ESMTPSA id y67sm2825957wmy.31.2019.11.23.11.11.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 23 Nov 2019 11:11:17 -0800 (PST) In-Reply-To: <87d0di7959.fsf@linkov.net> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172342 Archived-At: On 23.11.2019 20:50, Juri Linkov wrote: > - (list start-revision))) > + (if (eq limit 1) > + (list "-p" start-revision) > + (list start-revision)))) > > +A special case is when the prefix argument is 1, in this case > +it asks for the revision and shows it with its diff." I think that's rather ugly (see my comment about having the arguments to be orthogonal), and it precludes the use of this backend action to print a more extensive commit log (with diffs, that is). > + (when (and (eq limit 1) revision) > + (vc-git-region-history-mode)))) A Git-specific function in vc.el?