From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#15322: VC log buffer scrolls itself Date: Thu, 12 Sep 2013 15:30:04 -0400 Message-ID: <70six9g7nn.fsf@fencepost.gnu.org> References: <55fvtc5z7w.fsf@fencepost.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1379014274 29322 80.91.229.3 (12 Sep 2013 19:31:14 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 12 Sep 2013 19:31:14 +0000 (UTC) Cc: Paul Pogonyshev , 15322@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Sep 12 21:31:16 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VKCbb-0007Oo-OK for geb-bug-gnu-emacs@m.gmane.org; Thu, 12 Sep 2013 21:31:07 +0200 Original-Received: from localhost ([::1]:43540 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VKCbb-0002km-AD for geb-bug-gnu-emacs@m.gmane.org; Thu, 12 Sep 2013 15:31:07 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40533) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VKCbX-0002iu-G1 for bug-gnu-emacs@gnu.org; Thu, 12 Sep 2013 15:31:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VKCbW-00081L-FS for bug-gnu-emacs@gnu.org; Thu, 12 Sep 2013 15:31:03 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:51272) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VKCbW-00081H-CT for bug-gnu-emacs@gnu.org; Thu, 12 Sep 2013 15:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VKCbV-0002QY-WC for bug-gnu-emacs@gnu.org; Thu, 12 Sep 2013 15:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 12 Sep 2013 19:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15322 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 15322-submit@debbugs.gnu.org id=B15322.13790142109261 (code B ref 15322); Thu, 12 Sep 2013 19:31:01 +0000 Original-Received: (at 15322) by debbugs.gnu.org; 12 Sep 2013 19:30:10 +0000 Original-Received: from localhost ([127.0.0.1]:59565 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VKCae-0002Ov-WA for submit@debbugs.gnu.org; Thu, 12 Sep 2013 15:30:09 -0400 Original-Received: from fencepost.gnu.org ([208.118.235.10]:54703 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VKCab-0002OT-P9 for 15322@debbugs.gnu.org; Thu, 12 Sep 2013 15:30:06 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1VKCaa-0000Gu-G0; Thu, 12 Sep 2013 15:30:04 -0400 X-Spook: spies pipeline ANDVT MIT-LL lock picking Israel IDEA NORAD X-Ran: EUq'_4o+R}X$* X-Hue: white X-Attribution: GM In-Reply-To: (Stefan Monnier's message of "Thu, 12 Sep 2013 15:09:01 -0400") User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:78303 Archived-At: Stefan Monnier wrote: > And I think that makes sense. It's natural to select a particular > revision when running vc-print-log from (say) vc-annotate, but for > a plain `C-x v l', the user just wants to see "the log" and presumably > doesn't care about which revision happens to be current. > > IOW, I think we're trying too hard here. *** lisp/vc/vc.el 2013-09-12 06:10:12 +0000 --- lisp/vc/vc.el 2013-09-12 19:28:04 +0000 *************** *** 2299,2305 **** (let* ((vc-fileset (vc-deduce-fileset t)) ;FIXME: Why t? --Stef (backend (car vc-fileset)) (files (cadr vc-fileset)) ! (working-revision (or working-revision (vc-working-revision (car files))))) (vc-print-log-internal backend files working-revision nil limit))) ;;;###autoload --- 2299,2306 ---- (let* ((vc-fileset (vc-deduce-fileset t)) ;FIXME: Why t? --Stef (backend (car vc-fileset)) (files (cadr vc-fileset)) ! ;; (working-revision (or working-revision (vc-working-revision (car files)))) ! ) (vc-print-log-internal backend files working-revision nil limit))) ;;;###autoload