From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#59459: 29.0.50; Compilation warnings without tree-sitter Date: Tue, 22 Nov 2022 15:22:10 -0800 Message-ID: <70E5913F-2B44-4053-A7A3-8DC713607EFB@gmail.com> References: <9FA0FE0E-30D9-47DB-8263-F75567B6F228@gmail.com> <83wn7n18p7.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23255"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59459@debbugs.gnu.org, 59459-done@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 23 00:23:17 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oxcbk-0005nw-RQ for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 23 Nov 2022 00:23:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oxcbY-0007hk-SL; Tue, 22 Nov 2022 18:23:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxcbX-0007h8-9j for bug-gnu-emacs@gnu.org; Tue, 22 Nov 2022 18:23:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oxcbX-0001j8-1A for bug-gnu-emacs@gnu.org; Tue, 22 Nov 2022 18:23:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oxcbW-00020M-Tc for bug-gnu-emacs@gnu.org; Tue, 22 Nov 2022 18:23:02 -0500 Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Nov 2022 23:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 59459 X-GNU-PR-Package: emacs Mail-Followup-To: 59459@debbugs.gnu.org, casouri@gmail.com, casouri@gmail.com Original-Received: via spool by 59459-done@debbugs.gnu.org id=D59459.16691593417605 (code D ref 59459); Tue, 22 Nov 2022 23:23:02 +0000 Original-Received: (at 59459-done) by debbugs.gnu.org; 22 Nov 2022 23:22:21 +0000 Original-Received: from localhost ([127.0.0.1]:52859 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxcar-0001yV-IJ for submit@debbugs.gnu.org; Tue, 22 Nov 2022 18:22:21 -0500 Original-Received: from mail-pl1-f169.google.com ([209.85.214.169]:34313) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxcao-0001xp-7K; Tue, 22 Nov 2022 18:22:19 -0500 Original-Received: by mail-pl1-f169.google.com with SMTP id w4so6313643plp.1; Tue, 22 Nov 2022 15:22:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ihDT6tjXHovJQvBwkPfdvNCm8y0OF9SvZ8n2r1N/qA4=; b=FjVwPqc9+Qw3F/noW4GQ3VzXsJErXwHZrJwclga7KmPnsAdAH6vEEyuJh/qb/MVx/c wtTxpzARjC4wV54oL9IDXi1OfCOqyJ+MDWibJ0miE0uZI+XJFxZ+QlQavONWfBP918u3 6GBMnddz3knmd0vIMk+AzSvfpX1K6btsugO9NBkkJp/YwcXOJm/JA9smaa/3RXAYckn3 Z6Liev0Z1VXKkWdOxHUgeJypS38eRJMeKQqkBusTxI5q/TySam5QB9rgyLQAWkqO7rrs 37sjenKHwisrGqSYq3lU6leB6pAP2Mdqng3WdJZJ1DEEwljIrlJlQVbfLFYJlG2NIiNS NeKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ihDT6tjXHovJQvBwkPfdvNCm8y0OF9SvZ8n2r1N/qA4=; b=10lhhSCe3zkhrxWSdkRg5+yEvN162OfAK4LcflWEaj9zVtRNirjaHtqnK/DFPzjJQC J/dYZDyIO02kiq15L4QvGQ2FTunl8gSsexJW3ri+IzdLOvQjWebxr2bIphVJNeNb0wzs z1zJVY7IqlrOD9WEJFa7zwfa+NfOUxP7nQeZooqh+XO99Chq1ZPz8xXc3weg4+5WsvfD h/9vaIuQ6DZn8M0dtoeNgr/LHgeHUb8r+JnJwttx2Wi9IeJouOiQj16R+S0/q7BSXjVA 7R2fEwNUegLxvVn2/429smN797j8q+I5D620YNn7P8e2qmdkvVdQOAB03DERUiYuDOFE DTWA== X-Gm-Message-State: ANoB5plQRueBJ1CiQ2mBdIeSQUyKLjSn7ePZUJ7l3+6oq1TjqnWMuJ4d yUV55daZguddEHbCc+NrnxoYi+AdQ14icA== X-Google-Smtp-Source: AA0mqf7LJGxHnTmZqJjk451YtjGC93icnhY5GPLKYqBsAWdjhe5/WO5X5G8rFW/Ufof6wMpoyLkFjQ== X-Received: by 2002:a17:902:e807:b0:186:fb90:5774 with SMTP id u7-20020a170902e80700b00186fb905774mr6915259plg.137.1669159332457; Tue, 22 Nov 2022 15:22:12 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id mj24-20020a17090b369800b00214247989dfsm100703pjb.13.2022.11.22.15.22.11 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 Nov 2022 15:22:12 -0800 (PST) In-Reply-To: <83wn7n18p7.fsf@gnu.org> X-Mailer: Apple Mail (2.3696.120.41.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248690 Archived-At: > On Nov 22, 2022, at 4:21 AM, Eli Zaretskii wrote: >=20 >> From: Yuan Fu >> Date: Mon, 21 Nov 2022 14:01:14 -0800 >>=20 >> [Continuing from bug#59426] >>=20 >> Those warnings are due to no-tree-sitter build not having functions >> defined in treesit.c. Eli fixed those warnings by adding >> declare-function=E2=80=99s in every file using those functions. Can = we make it a >> bit nicer for lisp developers? Maybe defining those functions with >> dummies with something like >>=20 >> (defun xxx >> (error =E2=80=99treesit "Tree-sitter not available")) >>=20 >> ? >=20 > I'm not sure this is justified. The cases where a build lacks a very = large > group of primitives references in *.el files are quite rare in our = practice; > about the only two examples I know of are xwidgets.el and treesit.el = (plus > modes which use tree-sitter). It's easy enough (albeit annoying) to = add a > few declare-function's, so unless we are going to have more and more = of > these cases, adding a whole new infrastructure, let alone tricks like = the > above, which will raise a lot of brows, sound excessive to me. If it cannot be easily done with existing tools, then I agree = declare-function is good enough. Thanks, Yuan=