From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#39902: 28.0.50; Marking in dired with active region Date: Wed, 4 Mar 2020 13:07:53 -0800 (PST) Message-ID: <7083e1db-20ca-4227-a6d3-81dc814ba65f@default> References: <87d09suras.fsf@web.de> <7cf8e272-f112-47f5-a851-68c06166a40c@default> <87zhcw14zp.fsf@rub.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="120663"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Michael Heerdegen , 39902@debbugs.gnu.org To: Stephen Berman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Mar 04 22:09:14 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j9bGR-000VG3-F3 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 04 Mar 2020 22:09:11 +0100 Original-Received: from localhost ([::1]:39764 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9bGQ-00040k-HH for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 04 Mar 2020 16:09:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35377) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9bGJ-00040W-63 for bug-gnu-emacs@gnu.org; Wed, 04 Mar 2020 16:09:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j9bGI-0004zp-8Q for bug-gnu-emacs@gnu.org; Wed, 04 Mar 2020 16:09:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35940) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j9bGI-0004yV-3n for bug-gnu-emacs@gnu.org; Wed, 04 Mar 2020 16:09:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j9bGH-0008Ig-Uk for bug-gnu-emacs@gnu.org; Wed, 04 Mar 2020 16:09:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 04 Mar 2020 21:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39902 X-GNU-PR-Package: emacs Original-Received: via spool by 39902-submit@debbugs.gnu.org id=B39902.158335608531837 (code B ref 39902); Wed, 04 Mar 2020 21:09:01 +0000 Original-Received: (at 39902) by debbugs.gnu.org; 4 Mar 2020 21:08:05 +0000 Original-Received: from localhost ([127.0.0.1]:41913 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9bFN-0008HR-GG for submit@debbugs.gnu.org; Wed, 04 Mar 2020 16:08:05 -0500 Original-Received: from userp2120.oracle.com ([156.151.31.85]:51924) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9bFL-0008Gu-6d for 39902@debbugs.gnu.org; Wed, 04 Mar 2020 16:08:04 -0500 Original-Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 024Kx2Yv041251; Wed, 4 Mar 2020 21:07:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=hbXikPwH7/CuQqBIKvYi7wuY73SgYvAXfmZMzh/xkHs=; b=zs9OJMw6oVdc25Hu77kezhZBKG1N0U1qUM1P7MUw9jCUTV4SQ0GTzxwFSGg0O9gGEvHD xHxfrLfm/3RALji/3Ox/YVNekKVeif+raFn6fygmmEhh5recwJtTLvp3yhtZuucbCFlg 7jRHIisDA7YcMouoImdrf0XhuuaxrDArbg+nGF4PgAWH1yXnpKZBMuHK85T1DpFUCU0M 0kaWWG2qKSVpAv2Q50Wlefx5HnoKiqbURygvlRBNzJag2hd2VPdK6UOrQPXXV+oFaXTj /0hCROxJ60AwIWJRXvpnYo3Mg/xwzmZ+Qi9ITFBHcMUUJcs4rcCH0fHlVC+aY7txZXTx Gw== Original-Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2120.oracle.com with ESMTP id 2yghn3cs47-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 04 Mar 2020 21:07:57 +0000 Original-Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 024KwfHv135616; Wed, 4 Mar 2020 21:07:56 GMT Original-Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3030.oracle.com with ESMTP id 2yg1eqtg9g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 04 Mar 2020 21:07:56 +0000 Original-Received: from abhmp0016.oracle.com (abhmp0016.oracle.com [141.146.116.22]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 024L7sHh022361; Wed, 4 Mar 2020 21:07:54 GMT In-Reply-To: <87zhcw14zp.fsf@rub.de> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4966.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9550 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 suspectscore=0 spamscore=0 mlxlogscore=906 malwarescore=0 bulkscore=0 mlxscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2003040136 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9550 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0 spamscore=0 impostorscore=0 mlxscore=0 adultscore=0 mlxlogscore=965 lowpriorityscore=0 priorityscore=1501 bulkscore=0 clxscore=1011 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2003040136 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:176860 Archived-At: > >> (1) Docstring of `dired-mark' says > >> "If the region is active, mark all files in the region." > >> > >> However, the file in the last line of the region is never marked, even > >> if the region spans the whole line of this file. > > > > The problem seems to be that movement doesn't > > put the cursor where you (and `dired-mark') > > expect - the full lines are not selected. >=20 > This is due to the following code in dired-mark: >=20 > =09(dired-mark-files-in-region > =09 (progn (goto-char beg) (line-beginning-position)) > =09 (progn (goto-char end) (line-beginning-position)))))) >=20 > It may be that the second use of line-beginning-position is simply a > mistake, and should be line-end-position (CCing Juri Linkov, who wrote > that code). That's what diredp-mark-region-files in the library > dired+.el uses, which is the inspiration for the dired-mark code > (see bug#10624). Indeed. I looked only at `dired-mark', and saw that Dired+ doesn't substitute anything different for that (`m' etc. are still bound to vanilla `dired-mark'). I agree with you about the bug and proposed fix.=20