From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#8789: 23.3; debug backtrace buffer changes window on step-through Date: Thu, 20 Sep 2012 14:11:30 -0700 Message-ID: <705175AEA01C48549771E311A473EE28@us.oracle.com> References: <4F3CB843.6030401@gmx.at> <4F3D41DD.6080603@gmx.at> <877gzmqwcf.fsf@web.de> <504B4940.9000809@gmx.at> <86wqzznwzv.fsf@web.de> <9BABA419184241F5A7246DC5D9A9EF81@us.oracle.com> <5057A4A3.4010100@gmx.at> <4617F483F2CC446D980DF7194E06BB3A@us.oracle.com> <50581E7F.3040108@gmx.at> <1C1E224E1D674670BEE043B4A35A271F@us.oracle.com> <5059FC9C.8020702@gmx.at> <2D8C133406A54B26AD253EC7EE52C666@us.oracle.com> <505B1F26.20209@gmx.at> <87ehlwzklr.fsf@web.de> <505B51AD.2080908@gmx.at> <91FFA03F2A7341A09E280DD2BCC4A428@us.oracle.com> <83392czgvc.fsf@gnu.org> <87vcf8fnz3.fsf@web.de> <83wqzoxvri.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1348175559 26653 80.91.229.3 (20 Sep 2012 21:12:39 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 20 Sep 2012 21:12:39 +0000 (UTC) Cc: michael_heerdegen@web.de, 8789@debbugs.gnu.org To: "'Eli Zaretskii'" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Sep 20 23:12:42 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TEo34-0006ki-Sy for geb-bug-gnu-emacs@m.gmane.org; Thu, 20 Sep 2012 23:12:39 +0200 Original-Received: from localhost ([::1]:41690 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TEo30-000792-E5 for geb-bug-gnu-emacs@m.gmane.org; Thu, 20 Sep 2012 17:12:34 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:37930) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TEo2w-00078j-Kg for bug-gnu-emacs@gnu.org; Thu, 20 Sep 2012 17:12:31 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TEo2v-00017d-KD for bug-gnu-emacs@gnu.org; Thu, 20 Sep 2012 17:12:30 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:36143) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TEo2v-00017Z-Hg for bug-gnu-emacs@gnu.org; Thu, 20 Sep 2012 17:12:29 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TEo4Q-00046g-Cz for bug-gnu-emacs@gnu.org; Thu, 20 Sep 2012 17:14:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Sep 2012 21:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8789 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 8789-submit@debbugs.gnu.org id=B8789.134817559415725 (code B ref 8789); Thu, 20 Sep 2012 21:14:02 +0000 Original-Received: (at 8789) by debbugs.gnu.org; 20 Sep 2012 21:13:14 +0000 Original-Received: from localhost ([127.0.0.1]:45689 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TEo3d-00045a-VS for submit@debbugs.gnu.org; Thu, 20 Sep 2012 17:13:14 -0400 Original-Received: from rcsinet15.oracle.com ([148.87.113.117]:32884) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TEo3b-00045S-O4 for 8789@debbugs.gnu.org; Thu, 20 Sep 2012 17:13:12 -0400 Original-Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by rcsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q8KLBa1u003203 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 20 Sep 2012 21:11:36 GMT Original-Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q8KLBXYF017356 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 20 Sep 2012 21:11:34 GMT Original-Received: from abhmt112.oracle.com (abhmt112.oracle.com [141.146.116.64]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q8KLBXPh023008; Thu, 20 Sep 2012 16:11:33 -0500 Original-Received: from dradamslap1 (/130.35.178.248) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 20 Sep 2012 14:11:33 -0700 X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <83wqzoxvri.fsf@gnu.org> Thread-Index: Ac2XcefRFciJRWSeT72WFFNpUdUbSAAAN8/w X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:64660 Archived-At: > > 3. But I also think that it should be enough, for this > > problematic mode line enhancement, to simply call a > > duplicate of `file-remote-p' and not `file-remote-p' > > itself, which is used by all kinds of code. > > > > If that duplicate (e.g., `mode-line-file-remote-p') is > > called only by the mode-line code then that should > > greatly reduce, if not eliminate, this problem > > for the debugger. > > This has 2 problems, at least: > > . what if I need to debug mode-line-file-remote-p? Just do it. With the same problems you encounter today - no more and no less. The point is that the number of people who would, today, fall upon this `file-remote-p' sword accidentally _far_ outnumbers the people who will need to debug `mode-line-remote-p'. And those in the latter group will be likely to do so with cognizance of cause. Not so those in the first group. That's the (should-be-obvious) point: `file-remote-p' is called all over the place, by code that has nothing at all to do with the mode line or redisplay. `mode-line-file-remote-p' would have as its raison d'etre to be called only by mode-line code. > . what about calling Lisp from display features other than the mode > line, such as tool-bar buttons and menu items? Hey, I have nothing against your coming up with an elegant, general solution. But while waiting, why not solve the problem at hand? If you later manage to square the circle, then you can rename `mode-line-file-remote-p' back to `file-remote-p'. Easy. > In general, I think this is a slippery slope: before long we will be > duplicating many important functions, and we will have to enforce some > kind of coding standards whereby redisplay features cannot call > "ordinary" functions. I think this is absurd. You are exaggerating. If you have a better, immediate solution, please go for it. Or if you want to revert the change that caused the regression, go for it. But if you just want to wave your hands wildly about this not being the only problem, then I say, again, let's not let the perfect become the enemy of the good. In sum, I do not claim that my suggestion is the only or the best possible solution. Better ideas are welcome. But let's not avoid solving the problem just because there are potentially other, similar problems.