all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Glenn Morris <rgm@gnu.org>
To: Dave Goel <deego3@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: Fixing numerous `message' bugs..
Date: Thu, 06 Dec 2007 14:26:25 -0500	[thread overview]
Message-ID: <6prxj7hge.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <87ve7b6gbe.fsf@marie.gnufans.net> (Dave Goel's message of "Thu,  06 Dec 2007 09:36:21 -0500")



Some mistakes in these changes are revealed by bootstrapping:


Compiling /scratch/gmorris/emacs/cvs/trunk/lisp/./ibuffer.el

In ibuffer-current-buffer:
ibuffer.el:1395:115:Warning: `error' called with 2 args to fill 1
format field(s)

Compiling /scratch/gmorris/emacs/cvs/trunk/lisp/./vc.el

In vc-update:
vc.el:2626:15:Warning: `error' called with 2 args to fill 1 format
field(s)


Compiling /scratch/gmorris/emacs/cvs/trunk/lisp/./gnus/gnus-start.el

In gnus-load:
gnus-start.el:2392:14:Warning: malformed let binding: `(error "Error
in %s line %d" file (count-lines (point-min (point))))'


Also, a changelog entry that starts:

2007-12-06  D. Goel  <deego3@gmail.com>

            * textmodes/reftex.el (reftex-TeX-master-file): Ditto.

is not very informative, IMO, when reading top-to-bottom. I would say
these should look like:

2007-12-06  D. Goel  <deego3@gmail.com>

            * textmodes/reftex.el (reftex-TeX-master-file):
            * textmodes/org.el (org-paste-subtree):
            [...]
            * allout.el (allout-write-file-hook-handler):
            Fix buggy call(s) to `error'.

  reply	other threads:[~2007-12-06 19:26 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-06  0:14 Fixing numerous `message' bugs D. Goel
2007-12-06 10:56 ` David Kastrup
2007-12-06 14:36   ` Dave Goel
2007-12-06 19:26     ` Glenn Morris [this message]
2007-12-06 19:34       ` Dave Goel
2007-12-06 20:21       ` Johan Bockgård
2007-12-07  5:28         ` Glenn Morris
2007-12-07 15:52           ` Dave Goel
2007-12-06 15:53 ` Stefan Monnier
2007-12-06 16:01   ` Dave Goel
2007-12-06 16:49     ` Stefan Monnier
2007-12-06 16:58       ` David Kastrup
2007-12-06 17:19         ` David Kastrup
2007-12-07 17:17         ` Richard Stallman
2007-12-07 17:37           ` David Kastrup
2007-12-07 17:17         ` Richard Stallman
2007-12-07 17:18         ` Richard Stallman
2007-12-07 17:24           ` David Kastrup
2007-12-07 18:00             ` Dave Goel
2007-12-07 18:38               ` Stefan Monnier
2007-12-08  0:56                 ` Glenn Morris
2007-12-08  2:21                   ` Stefan Monnier
2007-12-08 10:55                     ` David Kastrup
2007-12-08 19:15                 ` Richard Stallman
2007-12-10 17:41                   ` Dave Goel
2007-12-10 18:04                     ` Jason Rumney
2007-12-10 19:05                       ` Dave Goel
2007-12-10 19:56                         ` Andreas Schwab
2007-12-10 20:31                           ` Dave Goel
2007-12-10 21:19                             ` David Kastrup
2007-12-10 22:44                               ` Dave Goel
2007-12-10 23:02                                 ` David Kastrup
2007-12-08 19:15             ` Richard Stallman
2007-12-07 17:18 ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6prxj7hge.fsf@fencepost.gnu.org \
    --to=rgm@gnu.org \
    --cc=deego3@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.