From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#23671: 25.0.94; recover-this-file error Date: Wed, 01 Mar 2017 18:31:14 -0500 Message-ID: <6pa894lgl9.fsf@fencepost.gnu.org> References: <87r3ch5epx.fsf@aol.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1488411131 21810 195.159.176.226 (1 Mar 2017 23:32:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 1 Mar 2017 23:32:11 +0000 (UTC) User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) To: 23671-done@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 02 00:32:06 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cjDj2-00051x-HJ for geb-bug-gnu-emacs@m.gmane.org; Thu, 02 Mar 2017 00:32:04 +0100 Original-Received: from localhost ([::1]:49286 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cjDj8-00010x-L7 for geb-bug-gnu-emacs@m.gmane.org; Wed, 01 Mar 2017 18:32:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33853) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cjDj1-0000zf-Jv for bug-gnu-emacs@gnu.org; Wed, 01 Mar 2017 18:32:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cjDj0-0005XO-VM for bug-gnu-emacs@gnu.org; Wed, 01 Mar 2017 18:32:03 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36835) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cjDj0-0005XD-Rp for bug-gnu-emacs@gnu.org; Wed, 01 Mar 2017 18:32:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cjDj0-0000Ts-N6 for bug-gnu-emacs@gnu.org; Wed, 01 Mar 2017 18:32:02 -0500 Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Wed, 01 Mar 2017 23:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 23671 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 23671@debbugs.gnu.org, rgm@gnu.org, nyc4bos@aol.com Original-Received: via spool by 23671-done@debbugs.gnu.org id=D23671.14884110831799 (code D ref 23671); Wed, 01 Mar 2017 23:32:02 +0000 Original-Received: (at 23671-done) by debbugs.gnu.org; 1 Mar 2017 23:31:23 +0000 Original-Received: from localhost ([127.0.0.1]:35033 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cjDiN-0000Sx-HV for submit@debbugs.gnu.org; Wed, 01 Mar 2017 18:31:23 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:42575) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cjDiL-0000Sj-CP for 23671-done@debbugs.gnu.org; Wed, 01 Mar 2017 18:31:21 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cjDiF-00059a-Fo for 23671-done@debbugs.gnu.org; Wed, 01 Mar 2017 18:31:16 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47022) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cjDiF-00059T-Cl for 23671-done@debbugs.gnu.org; Wed, 01 Mar 2017 18:31:15 -0500 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1cjDiE-0006D5-TS; Wed, 01 Mar 2017 18:31:14 -0500 X-Spook: Project Monarch S Key 9705 Samford Road STARLAN Rubin INS X-Ran: x'R-{]7DM!b|0,i"KrY7vl}]fM!b'YI|f`0o'Ur0]#IV3m<$eAFWl6-{P,mVg/Z@$l3 (Live System User's message of "Wed, 01 Jun 2016 07:30:02 -0400") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:130011 Archived-At: Version: 26.1 Live System User wrote: > I saw a message from Emacs that I could recover a file. I switched to > another buffer to check out something but didn't switch back when I > invoked `recover-this-file' and got the error: > > Wrong type argument: stringp, nil commit 8244357 Date: Wed Mar 1 18:29:48 2017 -0500 Small recover-this-file improvement * lisp/files.el (recover-this-file): Explicit error if not visiting a file. (Bug#23671) diff --git a/lisp/files.el b/lisp/files.el index 7c9271e..c7de445 100644 --- a/lisp/files.el +++ b/lisp/files.el @@ -5838,6 +5838,8 @@ an auto-save file." (defun recover-this-file () "Recover the visited file--get contents from its last auto-save file." (interactive) + (or buffer-file-name + (user-error "This buffer is not visiting a file")) (recover-file buffer-file-name)) (defun recover-file (file)