From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Phil Sainty Newsgroups: gmane.emacs.devel Subject: Re: [C source] Inconsistent comments on preprocessor conditionals Date: Sat, 09 Jul 2022 01:33:26 +1200 Message-ID: <6feb2ce2c5e249b74e836edd3ba0c7a0@webmail.orcon.net.nz> References: <87sfnb3h5m.fsf@disroot.org> <8335fb4vc7.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4225"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Orcon Webmail Cc: Akib Azmain Turja , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jul 08 15:53:25 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o9oQ9-0000zY-3a for ged-emacs-devel@m.gmane-mx.org; Fri, 08 Jul 2022 15:53:25 +0200 Original-Received: from localhost ([::1]:39880 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o9oQ8-0001yV-2H for ged-emacs-devel@m.gmane-mx.org; Fri, 08 Jul 2022 09:53:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37658) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9o6z-00073m-6M for emacs-devel@gnu.org; Fri, 08 Jul 2022 09:33:37 -0400 Original-Received: from smtp-4.orcon.net.nz ([60.234.4.59]:34707) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9o6w-0000UI-Ds; Fri, 08 Jul 2022 09:33:36 -0400 Original-Received: from [10.253.37.70] (port=45892 helo=webmail.orcon.net.nz) by smtp-4.orcon.net.nz with esmtpa (Exim 4.90_1) (envelope-from ) id 1o9o6o-0005fD-Hz; Sat, 09 Jul 2022 01:33:26 +1200 Original-Received: from ip-116-251-140-135.kinect.net.nz ([116.251.140.135]) via [10.253.37.253] by webmail.orcon.net.nz with HTTP (HTTP/1.1 POST); Sat, 09 Jul 2022 01:33:26 +1200 In-Reply-To: <8335fb4vc7.fsf@gnu.org> X-Sender: psainty@orcon.net.nz X-GeoIP: -- Received-SPF: pass client-ip=60.234.4.59; envelope-from=psainty@orcon.net.nz; helo=smtp-4.orcon.net.nz X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:291967 Archived-At: On 2022-07-09 00:55, Eli Zaretskii wrote: > You mean, the comment for the #endif line? It doesn't really matter > how you comment that, because both comments tell the same: the > #ifdef'ed conditional block ends here. The differences in this case > are purely stylistic. The "#endif /* not FOO */" version provides the extra information that there *is* an "#else" clause -- which might be helpful if the clauses are spaced very far apart. If "#endif /* FOO */" is then consistently used only for cases with no "#else", some code may be (very) slightly easier for people to parse. (As that was your recommended approach, this is nothing more than a an observation supporting that preference.)