From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Antoine Levitt" Newsgroups: gmane.emacs.bugs Subject: bug#858: Conflict between ERC mode tracking and ibuffer window shrinking Date: Fri, 5 Sep 2008 01:09:37 +0200 Message-ID: <6fa54e4e0809041609t1f38bc9ava23a69d455af50a9@mail.gmail.com> References: <87wshuse77.fsf@cyd.mit.edu> <48BE5A91.2060302@gmx.at> <6fa54e4e0809040714x79114c9ajf63023dc0ae615c@mail.gmail.com> <823akfwmr5.fsf@FILTH.SHOOTYBANGBANG.COM> Reply-To: Antoine Levitt , 858@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_53328_21812674.1220569777940" X-Trace: ger.gmane.org 1220570908 17762 80.91.229.12 (4 Sep 2008 23:28:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 4 Sep 2008 23:28:28 +0000 (UTC) Cc: 858@emacsbugs.donarmstrong.com, mwolson@gnu.org, cyd@stupidchicken.com, keegan.csmith@gmail.com To: "John Paul Wallington" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Sep 05 01:29:22 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KbOG6-0005ti-Nl for geb-bug-gnu-emacs@m.gmane.org; Fri, 05 Sep 2008 01:29:03 +0200 Original-Received: from localhost ([127.0.0.1]:52193 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KbOF6-0002tu-4L for geb-bug-gnu-emacs@m.gmane.org; Thu, 04 Sep 2008 19:28:00 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KbOEl-0002ne-Gd for bug-gnu-emacs@gnu.org; Thu, 04 Sep 2008 19:27:39 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KbOEj-0002mu-HI for bug-gnu-emacs@gnu.org; Thu, 04 Sep 2008 19:27:38 -0400 Original-Received: from [199.232.76.173] (port=36315 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KbOEj-0002mr-Dx for bug-gnu-emacs@gnu.org; Thu, 04 Sep 2008 19:27:37 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:57992) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KbOEh-0002A4-QB for bug-gnu-emacs@gnu.org; Thu, 04 Sep 2008 19:27:37 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m84NRVjw010294; Thu, 4 Sep 2008 16:27:31 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id m84NF3Gx005568; Thu, 4 Sep 2008 16:15:03 -0700 X-Loop: don@donarmstrong.com Resent-From: "Antoine Levitt" Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Thu, 04 Sep 2008 23:15:03 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 858 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 858-submit@emacsbugs.donarmstrong.com id=B858.12205697833818 (code B ref 858); Thu, 04 Sep 2008 23:15:03 +0000 Original-Received: (at 858) by emacsbugs.donarmstrong.com; 4 Sep 2008 23:09:43 +0000 Original-Received: from ik-out-1112.google.com (ik-out-1112.google.com [66.249.90.181]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m84N9cxj003812 for <858@emacsbugs.donarmstrong.com>; Thu, 4 Sep 2008 16:09:40 -0700 Original-Received: by ik-out-1112.google.com with SMTP id c21so155932ika.1 for <858@emacsbugs.donarmstrong.com>; Thu, 04 Sep 2008 16:09:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type:references; bh=NFpCBWjzV9IMIoatld/FPPXUzvRTN/aicjAufIMlKPE=; b=gdETcrOCRG8QiB+4nFaoHgqZx2Fg46XHR7kE4K+qG6yW4BA4Z8qtpOV4VG5fNSdu9K F7iL35JfuAyU/YRXnKI4alxvUd0+XmGegYvpIaL/J9Pyr4jPGdCjLLWkGvch7kjJcu7T QbkYTXlKQMHmHegFuDw1hmwuFNmpcuvD6zXNY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:references; b=Z9dX+F4A5t3tc/ZLkqy+2LYFmg7lJQkJISVBdtw75cI/EQzv/oKjSP8ORJs7CGXszV 7TEvn89WSHjmOQgm0K6xweArrzjn5rCXE0eZPbG5fdzfbA1UzODCHkwXIPA5/X/YU4j+ kyQ9v1mz2zfhGfo+R83EraAcG3T7kzdwc8600= Original-Received: by 10.210.65.17 with SMTP id n17mr12675133eba.80.1220569777956; Thu, 04 Sep 2008 16:09:37 -0700 (PDT) Original-Received: by 10.210.141.18 with HTTP; Thu, 4 Sep 2008 16:09:37 -0700 (PDT) In-Reply-To: <823akfwmr5.fsf@FILTH.SHOOTYBANGBANG.COM> X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Resent-Date: Thu, 04 Sep 2008 19:27:38 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:20173 Archived-At: ------=_Part_53328_21812674.1220569777940 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline My suspicion was wrong, the binding doesn't change anything. I just said that by looking at the comment, but didn't try. Sorry about that. However, (defun erc-scroll-to-bottom (window display-start) nil) removes the bug. The bug should be reproducable with emacs -Q, the ibuffer configuration lines I gave in the first bug report, and scroll-to-bottom mode on. I'm using latest CVS, the bug also happens with a build from july. Best of luck Antoine 2008/9/5 John Paul Wallington > > Hi, > > Hi Antoine, > > > I did some testing, and the bug was not in tracker as I suspected, it's > in > > scrolltobottom, in erc-goodies.el. This should be much easier for you to > > debug: it's only a few lines long. I strongly suspect the part following > > this comment is responsible : > > ;; Temporarily bind resize-mini-windows to nil so that users who > have > > it > > ;; set to a non-nil value will not suffer from premature minibuffer > > ;; shrinkage due to the below recenter call. I have no idea why > this > > ;; works, but it solves the problem, and has no negative side > effects. > > ;; (Fran Litterio, 2003/01/07) > > > > Looks like it does have side effects after all :-) > > Sorry, I'm having difficulties reproducing the bug. > > Could you try getting rid of the code that binds > `resize-mini-windows', perhaps using the function below, and test > whether your suspicion is correct? > > > (defun erc-scroll-to-bottom (window display-start) > "Changed to see whether not let binding `resize-mini-windows' to nil > doesn't cause the bug." > (if (window-live-p window) > (erc-with-selected-window window > (save-restriction > (widen) > (when (and erc-insert-marker > ;; we're editing a line. Scroll. > (> (point) erc-insert-marker)) > (save-excursion > (goto-char (point-max)) > (recenter (or erc-input-line-position -1)) > (sit-for 0))))))) > ------=_Part_53328_21812674.1220569777940 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline
My suspicion was wrong, the binding doesn't change anything. I just said that by looking at the comment, but didn't try. Sorry about that.
However, (defun erc-scroll-to-bottom (window display-start) nil) removes the bug.
The bug should be reproducable with emacs -Q, the ibuffer configuration lines I gave in the first bug report, and scroll-to-bottom mode on. I'm using latest CVS, the bug also happens with a build from july.
Best of luck
Antoine
2008/9/5 John Paul Wallington <jpw@pobox.com>
> Hi,

Hi Antoine,

> I did some testing, and the bug was not in tracker as I suspected, it's in
> scrolltobottom, in erc-goodies.el. This should be much easier for you to
> debug: it's only a few lines long. I strongly suspect the part following
> this comment is responsible :
>       ;; Temporarily bind resize-mini-windows to nil so that users who have
> it
>       ;; set to a non-nil value will not suffer from premature minibuffer
>       ;; shrinkage due to the below recenter call.  I have no idea why this
>       ;; works, but it solves the problem, and has no negative side effects.
>       ;; (Fran Litterio, 2003/01/07)
>
> Looks like it does have side effects after all :-)

Sorry, I'm having difficulties reproducing the bug.

Could you try getting rid of the code that binds
`resize-mini-windows', perhaps using the function below, and test
whether your suspicion is correct?


(defun erc-scroll-to-bottom (window display-start)
 "Changed to see whether not let binding `resize-mini-windows' to nil
doesn't cause the bug."
 (if (window-live-p window)
     (erc-with-selected-window window
       (save-restriction
         (widen)
         (when (and erc-insert-marker
                    ;; we're editing a line. Scroll.
                    (> (point) erc-insert-marker))
           (save-excursion
             (goto-char (point-max))
             (recenter (or erc-input-line-position -1))
             (sit-for 0)))))))

------=_Part_53328_21812674.1220569777940--