From: "Antoine Levitt" <smeuuh@gmail.com>
To: "John Paul Wallington" <jpw@pobox.com>
Cc: 858@emacsbugs.donarmstrong.com, mwolson@gnu.org,
cyd@stupidchicken.com, keegan.csmith@gmail.com
Subject: bug#858: Conflict between ERC mode tracking and ibuffer window shrinking
Date: Fri, 5 Sep 2008 01:09:37 +0200 [thread overview]
Message-ID: <6fa54e4e0809041609t1f38bc9ava23a69d455af50a9@mail.gmail.com> (raw)
In-Reply-To: <823akfwmr5.fsf@FILTH.SHOOTYBANGBANG.COM>
[-- Attachment #1: Type: text/plain, Size: 2017 bytes --]
My suspicion was wrong, the binding doesn't change anything. I just said
that by looking at the comment, but didn't try. Sorry about that.
However, (defun erc-scroll-to-bottom (window display-start) nil) removes the
bug.
The bug should be reproducable with emacs -Q, the ibuffer configuration
lines I gave in the first bug report, and scroll-to-bottom mode on. I'm
using latest CVS, the bug also happens with a build from july.
Best of luck
Antoine
2008/9/5 John Paul Wallington <jpw@pobox.com>
> > Hi,
>
> Hi Antoine,
>
> > I did some testing, and the bug was not in tracker as I suspected, it's
> in
> > scrolltobottom, in erc-goodies.el. This should be much easier for you to
> > debug: it's only a few lines long. I strongly suspect the part following
> > this comment is responsible :
> > ;; Temporarily bind resize-mini-windows to nil so that users who
> have
> > it
> > ;; set to a non-nil value will not suffer from premature minibuffer
> > ;; shrinkage due to the below recenter call. I have no idea why
> this
> > ;; works, but it solves the problem, and has no negative side
> effects.
> > ;; (Fran Litterio, 2003/01/07)
> >
> > Looks like it does have side effects after all :-)
>
> Sorry, I'm having difficulties reproducing the bug.
>
> Could you try getting rid of the code that binds
> `resize-mini-windows', perhaps using the function below, and test
> whether your suspicion is correct?
>
>
> (defun erc-scroll-to-bottom (window display-start)
> "Changed to see whether not let binding `resize-mini-windows' to nil
> doesn't cause the bug."
> (if (window-live-p window)
> (erc-with-selected-window window
> (save-restriction
> (widen)
> (when (and erc-insert-marker
> ;; we're editing a line. Scroll.
> (> (point) erc-insert-marker))
> (save-excursion
> (goto-char (point-max))
> (recenter (or erc-input-line-position -1))
> (sit-for 0)))))))
>
[-- Attachment #2: Type: text/html, Size: 2912 bytes --]
next prev parent reply other threads:[~2008-09-04 23:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-02 16:30 bug#858: Conflict between ERC mode tracking and ibuffer window shrinking Chong Yidong
2008-09-02 16:46 ` Antoine Levitt
2008-09-03 9:36 ` martin rudalics
2008-09-04 14:14 ` Antoine Levitt
2008-09-04 22:48 ` John Paul Wallington
2008-09-04 23:09 ` Antoine Levitt [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-09-01 23:26 Antoine Levitt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6fa54e4e0809041609t1f38bc9ava23a69d455af50a9@mail.gmail.com \
--to=smeuuh@gmail.com \
--cc=858@emacsbugs.donarmstrong.com \
--cc=cyd@stupidchicken.com \
--cc=jpw@pobox.com \
--cc=keegan.csmith@gmail.com \
--cc=mwolson@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.