From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Antoine Levitt" Newsgroups: gmane.emacs.bugs Subject: bug#858: Conflict between ERC mode tracking and ibuffer window shrinking Date: Thu, 4 Sep 2008 16:14:08 +0200 Message-ID: <6fa54e4e0809040714x79114c9ajf63023dc0ae615c@mail.gmail.com> References: <87wshuse77.fsf@cyd.mit.edu> <48BE5A91.2060302@gmx.at> Reply-To: Antoine Levitt , 858@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_44478_9410640.1220537648503" X-Trace: ger.gmane.org 1220539442 25444 80.91.229.12 (4 Sep 2008 14:44:02 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 4 Sep 2008 14:44:02 +0000 (UTC) Cc: Keegan Carruthers-Smith , Chong Yidong , Michael Olson , John Paul Wallington To: "martin rudalics" , 858@emacsbugs.donarmstrong.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Sep 04 16:44:56 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KbG49-0003Q7-Gs for geb-bug-gnu-emacs@m.gmane.org; Thu, 04 Sep 2008 16:44:10 +0200 Original-Received: from localhost ([127.0.0.1]:57971 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KbG3A-0008Bg-76 for geb-bug-gnu-emacs@m.gmane.org; Thu, 04 Sep 2008 10:43:08 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KbFo8-0003e3-Vd for bug-gnu-emacs@gnu.org; Thu, 04 Sep 2008 10:27:37 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KbFo6-0003cX-T5 for bug-gnu-emacs@gnu.org; Thu, 04 Sep 2008 10:27:36 -0400 Original-Received: from [199.232.76.173] (port=42812 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KbFo6-0003c7-B1 for bug-gnu-emacs@gnu.org; Thu, 04 Sep 2008 10:27:34 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:36329) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KbFo6-0004k0-61 for bug-gnu-emacs@gnu.org; Thu, 04 Sep 2008 10:27:34 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m84ERVcE014995; Thu, 4 Sep 2008 07:27:31 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id m84EK4vs011966; Thu, 4 Sep 2008 07:20:04 -0700 X-Loop: don@donarmstrong.com Resent-From: "Antoine Levitt" Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Thu, 04 Sep 2008 14:20:04 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 858 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 858-submit@emacsbugs.donarmstrong.com id=B858.122053765810128 (code B ref 858); Thu, 04 Sep 2008 14:20:04 +0000 Original-Received: (at 858) by emacsbugs.donarmstrong.com; 4 Sep 2008 14:14:18 +0000 Original-Received: from ey-out-2122.google.com (ey-out-2122.google.com [74.125.78.27]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m84EE9oO010122 for <858@emacsbugs.donarmstrong.com>; Thu, 4 Sep 2008 07:14:10 -0700 Original-Received: by ey-out-2122.google.com with SMTP id 4so1429639eyf.13 for <858@emacsbugs.donarmstrong.com>; Thu, 04 Sep 2008 07:14:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type:references; bh=+O6pER7q4zbghVezDxZSrqXvi55HTwTAFfwQsC3QPgY=; b=bwCXi0Ksy7ORumzE8HbROkP1GBbBDUgEjep1Ba5KLmw5gdbG3C8bleCI+z05asX+/a EjDIzfWekUKvBtBswAeyrfioLwAvjnFY23ry2jJ5K6nsAV8KrRUkRGVjOdGpybRftmD3 vCHxAiqKKXPKyZLMaQ/OGMPnZZfHlz9PHWvYo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:references; b=axYAH5iX9OoXBRTmf+2DqQ1UEfQWsyoGyhNRDJrtq5SjA1OwrWUAwv/sTj5gPj/Shf VpAH/L7UXNfxOzlcn05Ta+3duT/S9wZ+eEqqcH7gvhpwE+H8oHSff/oIuN9RXNYiJWvd TPlWZGsw4sQajxVtHEd6H3n7vnh3upNu6C2Qk= Original-Received: by 10.210.109.20 with SMTP id h20mr3494476ebc.129.1220537648512; Thu, 04 Sep 2008 07:14:08 -0700 (PDT) Original-Received: by 10.210.141.18 with HTTP; Thu, 4 Sep 2008 07:14:08 -0700 (PDT) In-Reply-To: <48BE5A91.2060302@gmx.at> X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Resent-Date: Thu, 04 Sep 2008 10:27:36 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:20139 Archived-At: ------=_Part_44478_9410640.1220537648503 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Hi, I did some testing, and the bug was not in tracker as I suspected, it's in scrolltobottom, in erc-goodies.el. This should be much easier for you to debug: it's only a few lines long. I strongly suspect the part following this comment is responsible : ;; Temporarily bind resize-mini-windows to nil so that users who have it ;; set to a non-nil value will not suffer from premature minibuffer ;; shrinkage due to the below recenter call. I have no idea why this ;; works, but it solves the problem, and has no negative side effects. ;; (Fran Litterio, 2003/01/07) Looks like it does have side effects after all :-) 2008/9/3 martin rudalics > CC-ing Keegan because Bug #466 describes another problem with ERC and > windows. > > >> There is a bug when using conjointly these two features. Here are the > >> relevant portions of configuration : > >> > >> ;;make ibuffer resize itself to its buffer size > >> (setq ibuffer-use-other-window t) > >> (setq ibuffer-default-shrink-to-minimum-size t) > >> > >> No specific configuration for erc, just enabling tracker is enough. > >> Then, run erc, and, in any erc buffer, call ibuffer. The screen > >> briefly flashes as an ERC window opens then disappears, and the > >> ibuffer window is reduced to a much smaller size than what it would be > >> outside ERC. I think the issue is erc's hook to > >> window-configuration-change somehow messing with ibuffer, but I'm not > >> experienced enough to find where the bug is. > > Can't offer much insight but processing window-configuration-change > hooks has changed with Emacs 23. So this > > (defun erc-track-modified-channels () > "Hook function for `erc-insert-post-hook' to check if the current > buffer should be added to the modeline as a hidden, modified > channel. Assumes it will only be called when current-buffer > is in `erc-mode'." > (let ((this-channel (or (erc-default-target) > (buffer-name (current-buffer))))) > ... > > might have been broken for some reason. To verify, someone would have > to try with Emacs 22 and 23 inserting just before the `let' something > like > > (unless (eq major-mode 'erc-mode) > (message "Not in erc-mode ...")) > > and look whether it triggers. > > martin > > > > > > ------=_Part_44478_9410640.1220537648503 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline
Hi,
I did some testing, and the bug was not in tracker as I suspected, it's in scrolltobottom, in erc-goodies.el. This should be much easier for you to debug: it's only a few lines long. I strongly suspect the part following this comment is responsible :
      ;; Temporarily bind resize-mini-windows to nil so that users who have it
      ;; set to a non-nil value will not suffer from premature minibuffer
      ;; shrinkage due to the below recenter call.  I have no idea why this
      ;; works, but it solves the problem, and has no negative side effects.
      ;; (Fran Litterio, 2003/01/07)

Looks like it does have side effects after all :-)
2008/9/3 martin rudalics <rudalics@gmx.at>
CC-ing Keegan because Bug #466 describes another problem with ERC and
windows.


>> There is a bug when using conjointly these two features. Here are the
>> relevant portions of configuration :
>>
>> ;;make ibuffer resize itself to its buffer size
>> (setq ibuffer-use-other-window t)
>> (setq ibuffer-default-shrink-to-minimum-size t)
>>
>> No specific configuration for erc, just enabling tracker is enough.
>> Then, run erc, and, in any erc buffer, call ibuffer. The screen
>> briefly flashes as an ERC window opens then disappears, and the
>> ibuffer window is reduced to a much smaller size than what it would be
>> outside ERC. I think the issue is erc's hook to
>> window-configuration-change somehow messing with ibuffer, but I'm not
>> experienced enough to find where the bug is.

Can't offer much insight but processing window-configuration-change
hooks has changed with Emacs 23.  So this

(defun erc-track-modified-channels ()
 "Hook function for `erc-insert-post-hook' to check if the current
buffer should be added to the modeline as a hidden, modified
channel.  Assumes it will only be called when current-buffer
is in `erc-mode'."
 (let ((this-channel (or (erc-default-target)
                         (buffer-name (current-buffer)))))
   ...                

might have been broken for some reason.  To verify, someone would have
to try with Emacs 22 and 23 inserting just before the `let' something
like

(unless (eq major-mode 'erc-mode)
 (message "Not in erc-mode ..."))

and look whether it triggers.

martin






------=_Part_44478_9410640.1220537648503--