From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: Patches for Emacs 25.2 Date: Mon, 7 Nov 2016 02:08:56 +0200 Message-ID: <6f656e32-a44c-f874-3290-f47b8828078e@yandex.ru> References: <877f96t9oc.fsf@gmx.de> <837f96xgp5.fsf@gnu.org> <87zim2rtck.fsf@gmx.de> <9181f38b-8d6c-c61e-90b0-d44a9e048c9e@gmail.com> <87wph6qd1d.fsf@gmx.de> <831szexb54.fsf@gnu.org> <83shrtx5dv.fsf@gnu.org> <752ec49c-da5b-bf86-e31d-294c362c04cb@gmail.com> <877f95deig.fsf@gmx.de> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1478477366 5499 195.159.176.226 (7 Nov 2016 00:09:26 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 7 Nov 2016 00:09:26 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:50.0) Gecko/20100101 Thunderbird/50.0 Cc: Eli Zaretskii , emacs-devel@gnu.org To: Michael Albinus , Nikolay Kudryavtsev Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 07 01:09:22 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c3XUr-0007hD-4f for ged-emacs-devel@m.gmane.org; Mon, 07 Nov 2016 01:09:09 +0100 Original-Received: from localhost ([::1]:49578 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c3XUu-0005ar-4U for ged-emacs-devel@m.gmane.org; Sun, 06 Nov 2016 19:09:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39663) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c3XUl-0005Zg-UJ for emacs-devel@gnu.org; Sun, 06 Nov 2016 19:09:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c3XUi-0004bR-Ac for emacs-devel@gnu.org; Sun, 06 Nov 2016 19:09:03 -0500 Original-Received: from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244]:35291) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c3XUi-0004Xt-2i; Sun, 06 Nov 2016 19:09:00 -0500 Original-Received: by mail-wm0-x244.google.com with SMTP id a20so2989892wme.2; Sun, 06 Nov 2016 16:08:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=3C6Jk7yGNiP6zgm3JkaaxT3T7IzDRY0xgmyfn9laqe0=; b=zcJu7oWpxD7Kmhn60+1iHJS+qLGPYhk/bAc43sijI45uqRoKCrpCSiXObKbzcYoDMd EjEPuJp6g7CqmrQCFdnM+Qz/UP1aM+L7hmbrR7Vwke35I8TTWAIf1y9vq6ay9UhwM2I1 mIUYHkDuFYg8xnFzwQNhzlm2aBWvMfoTyGhJSTSi8+tzy+WhFauSt7QSkZL1Iw96NZxz AVQeoiVLLY0NTFLB6nXKrHFKM6fIhuErfmyFDp6HfJBwoYoJ3nk8bUL6j8VlyrfeqrfM GQqWdEynpR0cZlAoFAJk8FvlhxrOL91hbOMhxJcc69bTAggW2vaz2lWd26T3eiWX7FFr iFjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3C6Jk7yGNiP6zgm3JkaaxT3T7IzDRY0xgmyfn9laqe0=; b=UwK05J8nE54fWbMktACpxlGB3Z0BtqXCWaBGHjx8dqt6gkXoAEazAoDGyzTW8sooeW sViv2d4/SZ6VUPCalGuWFafE8Cn4IsE472Dc7Xxb4ELvD+5KatX+GhZ7ZCJQ2iTWtnPu dy1Yf5Bz8nrDK+oGwd376K0DoldHNdrrLxtiuW5qu8WTiMHxo2ZVtotqA8XEzhFGE+mY yjITe897zRCd07vFLFjTbyVq7SY4sjVSJwVUVfmUXp6iZUuIMseq6hwIR+o7WTSgxb9O d48woRi6DHV7+mrrd+UPL4MCePBYLT1XTXXhdn03qRUzxM6UJ7duq0OF2bTsbvy6unsh bPoA== X-Gm-Message-State: ABUngvfUtKT/6y17Y7y+053SDmqX2qqlEmRr2ryV+bza2nzQV8f6hW5WjQralPKqvkIYqQ== X-Received: by 10.28.183.215 with SMTP id h206mr4392919wmf.60.1478477338646; Sun, 06 Nov 2016 16:08:58 -0800 (PST) Original-Received: from [192.168.1.3] ([185.105.173.41]) by smtp.googlemail.com with ESMTPSA id pd2sm27654453wjb.31.2016.11.06.16.08.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 06 Nov 2016 16:08:58 -0800 (PST) In-Reply-To: <877f95deig.fsf@gmx.de> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::244 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:209231 Archived-At: Hi Michael, On 18.10.2016 15:32, Michael Albinus wrote: > I don't decide whether such a patch shall be applied; it shall be > decided by the vc maintainer. But in case of, the patch could be written > shorter: Thanks. I don't like it (for obvious reason you mentioned yourself), but since it's emacs-25-only, it should be fine, with the following minor concerns: > ! (if (eq system-type 'windows-nt) > ! (if (file-remote-p file1) > ! (with-parsed-tramp-file-name file1 nil > ! (tramp-make-tramp-file-name > ! method user host > ! (tramp-make-tramp-temp-file v))) > ! (make-temp-file "git-msg"))))) Please do not introduce tabs here. > ! (nconc (if msg-file > ! (list > ! "commit" "-F" > ! (or (file-remote-p msg-file 'localname) msg-file)) Can't we move the (file-remote-p ... 'localname) call to the first hunk here? Then the patch will only change one place, and we get rid of the added `or' here.