From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.comp.lib.gnulib.bugs,gmane.emacs.devel Subject: Re: [master b3cf281] Unbreak the MinGW build Date: Fri, 16 Dec 2016 07:43:59 -0800 Organization: UCLA Computer Science Department Message-ID: <6f53d9d5-c352-2bb7-1312-d7e465b63c61@cs.ucla.edu> References: <83eg1887q4.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------E49D717C686B15C252B91FEF" X-Trace: blaine.gmane.org 1481903064 24984 195.159.176.226 (16 Dec 2016 15:44:24 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 16 Dec 2016 15:44:24 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 Cc: Bruno Haible , Gnulib bugs , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: bug-gnulib-bounces+gnu-bug-gnulib=m.gmane.org@gnu.org Fri Dec 16 16:44:20 2016 Return-path: Envelope-to: gnu-bug-gnulib@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cHugF-0005aX-Ii for gnu-bug-gnulib@m.gmane.org; Fri, 16 Dec 2016 16:44:19 +0100 Original-Received: from localhost ([::1]:32910 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cHugJ-0006L6-P5 for gnu-bug-gnulib@m.gmane.org; Fri, 16 Dec 2016 10:44:23 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37990) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cHug5-0006JM-DE for bug-gnulib@gnu.org; Fri, 16 Dec 2016 10:44:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cHug2-0004Op-8S for bug-gnulib@gnu.org; Fri, 16 Dec 2016 10:44:09 -0500 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:55356) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cHug1-0004MQ-V3; Fri, 16 Dec 2016 10:44:06 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 7849C160109; Fri, 16 Dec 2016 07:44:04 -0800 (PST) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id kXLGNrR4Jkuq; Fri, 16 Dec 2016 07:44:03 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 5F468160110; Fri, 16 Dec 2016 07:44:03 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id zjzh0hF0RxW5; Fri, 16 Dec 2016 07:44:03 -0800 (PST) Original-Received: from [192.168.1.9] (unknown [47.153.178.162]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 3A87A16010D; Fri, 16 Dec 2016 07:44:03 -0800 (PST) In-Reply-To: <83eg1887q4.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 131.179.128.68 X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+gnu-bug-gnulib=m.gmane.org@gnu.org Original-Sender: "bug-gnulib" Xref: news.gmane.org gmane.comp.lib.gnulib.bugs:36530 gmane.emacs.devel:210523 Archived-At: This is a multi-part message in MIME format. --------------E49D717C686B15C252B91FEF Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Eli Zaretskii wrote: > I needed this commit to prevent temacs from crashing during dumping. > Don't ask me how including errno.h (both the one from Gnulib and the > MinGW one) could cause this, especially as the preprocessed __fpending > doesn't seem to change a bit as result of that, and it doesn't seem to > even be called during dumping. The facts are stubborn: if I leave > that inclusion in place, I get a crash, removing it fixes the crash. I propagated this fix back to gnulib by installing the attached patch to Gnulib. I'll CC: this to Bruno Haible, who made the recent change to fpending. I don't use MinGW myself. --------------E49D717C686B15C252B91FEF Content-Type: text/x-diff; name="0001-fpending-fix-port-to-MinGW-on-Emacs.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-fpending-fix-port-to-MinGW-on-Emacs.patch" >From 60635cc80e74f7f48cf5f794cc1d3d43d4c4f1e9 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Fri, 16 Dec 2016 07:38:58 -0800 Subject: [PATCH] fpending: fix port to MinGW on Emacs * lib/stdio-impl.h [__MINGW32__]: Do not include errno.h. Problem reported by Eli Zaretskii in: http://lists.gnu.org/archive/html/emacs-devel/2016-12/msg00642.html Is Plan 9 still a valid porting target, anyway? --- ChangeLog | 8 ++++++++ lib/stdio-impl.h | 2 ++ 2 files changed, 10 insertions(+) diff --git a/ChangeLog b/ChangeLog index 5e9e801..dd67dba 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,11 @@ +2016-12-16 Paul Eggert + + fpending: fix port to MinGW on Emacs + * lib/stdio-impl.h [__MINGW32__]: Do not include errno.h. + Problem reported by Eli Zaretskii in: + http://lists.gnu.org/archive/html/emacs-devel/2016-12/msg00642.html + Is Plan 9 still a valid porting target, anyway? + 2016-12-15 Paul Eggert safe-alloc: use xalloc-oversized diff --git a/lib/stdio-impl.h b/lib/stdio-impl.h index 766d693..1972a33 100644 --- a/lib/stdio-impl.h +++ b/lib/stdio-impl.h @@ -26,7 +26,9 @@ # include #endif +#ifndef __MINGW32__ #include /* For detecting Plan9. */ +#endif #if defined __sferror || defined __DragonFly__ || defined __ANDROID__ /* FreeBSD, NetBSD, OpenBSD, DragonFly, Mac OS X, Cygwin, Android */ -- 2.7.4 --------------E49D717C686B15C252B91FEF--