From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#47287: 28.0.50; [PATCH] Add command project-remove-known-project Date: Mon, 22 Mar 2021 13:52:15 +0200 Message-ID: <6f4a0b1d-017d-a22f-3973-e9062c193bc6@yandex.ru> References: <83v99lav45.fsf@gnu.org> <95323A8F-5875-413E-952D-383163B0D1A8@thornhill.no> <4f5e3918-e133-88e4-b5c9-90a81e348497@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15288"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 Cc: 47287@debbugs.gnu.org To: Theodor Thornhill , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 22 12:53:15 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lOJ7R-0003qg-6c for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 22 Mar 2021 12:53:13 +0100 Original-Received: from localhost ([::1]:58750 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lOJ7Q-000139-5G for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 22 Mar 2021 07:53:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57008) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lOJ7I-00011Y-Db for bug-gnu-emacs@gnu.org; Mon, 22 Mar 2021 07:53:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44797) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lOJ7G-00048q-AR for bug-gnu-emacs@gnu.org; Mon, 22 Mar 2021 07:53:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lOJ7G-0003d8-73 for bug-gnu-emacs@gnu.org; Mon, 22 Mar 2021 07:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 Mar 2021 11:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47287 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 47287-submit@debbugs.gnu.org id=B47287.161641394513897 (code B ref 47287); Mon, 22 Mar 2021 11:53:02 +0000 Original-Received: (at 47287) by debbugs.gnu.org; 22 Mar 2021 11:52:25 +0000 Original-Received: from localhost ([127.0.0.1]:56343 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lOJ6f-0003c4-I2 for submit@debbugs.gnu.org; Mon, 22 Mar 2021 07:52:25 -0400 Original-Received: from mail-wr1-f43.google.com ([209.85.221.43]:40856) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lOJ6d-0003bp-QO for 47287@debbugs.gnu.org; Mon, 22 Mar 2021 07:52:24 -0400 Original-Received: by mail-wr1-f43.google.com with SMTP id v11so16343449wro.7 for <47287@debbugs.gnu.org>; Mon, 22 Mar 2021 04:52:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=WdeLvMq+8pFkVfWQHzHZn6abXoquzXzrnt1CHCO1zXc=; b=kA/lDuBeZPBmLNRDWnspgvN8XrfEjHhrG3DoyW4XYmQm+MfyqYHItQC/mEIJBVYhrT G8dR7G7EeNlAsGKOJOl+XpzE7bSYAxhS1WoSCbxobM5NS8T89fiNcwrJJzEG00Jl21u0 HgYa7reaUPFnLagl24a8O7U/ZUPNK/trphpOgJZ68dTnUAlkTNCmi3/s7kKEemNqKY7u QndQdIEpi7XMBeVDAsxa8bkzfdMo8QqMI9Y8K6hBRghBRLFZq1avh6Ce7NGf311O9RFP RytOYlnWYyth6SpyQaoBJaCJYq91OqjqEJhjSQuzZImhO9y3qgxq6xTtUsAnLn/3QtGo atrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=WdeLvMq+8pFkVfWQHzHZn6abXoquzXzrnt1CHCO1zXc=; b=shEfIMAMevRYyn5Fc1ZZw9mizt43eIExZP3ZJYbXqtH1wSGT2ge/GSbtO/FaPs3Dc8 ptfa2ed42o+iODd+/saKK2mYQiPv1btPLmLvEaBVu004pItihOQlLapJSe2A64nW8tLa h0MZSOxeR3e8DlNguP8NSEM8KL/CE5Q189upeEa3arVqW2dHDe/ft06HRqCGZzuSufht Ij0EMC4k0d97MS90tJ+0J8MXaygjJhN52t0nxDK9LWVbBXcnAPeCdoiwKC0gNRrm4H8q G4noLmQ82adB8ukoFa+TegFZSRkJuDHSC1BVu+JUcgCJx5HygVL6KBR2wDf7f9fdsk7D gNQA== X-Gm-Message-State: AOAM530Bsmf7AE4f2xULcYKo0rMuzSqexN0D7w2bFoFrKj8/nIPC6SwF 4e81m2XPb6rhy3OLfGbwTp8AW1aWzGc= X-Google-Smtp-Source: ABdhPJyHRRmd6l1B8YVWEcn7BhP3R0nGhltumY8bI5U2NbY+ld0deMgvJqc4Xn7bNsTMqmssUNVaVQ== X-Received: by 2002:a5d:5192:: with SMTP id k18mr3373399wrv.153.1616413937878; Mon, 22 Mar 2021 04:52:17 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id w6sm19187445wrl.49.2021.03.22.04.52.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Mar 2021 04:52:17 -0700 (PDT) In-Reply-To: Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:202827 Archived-At: On 22.03.2021 09:48, Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: >> It's fine, but it would be better for both function's argument to follow >> projectile-add-known-project (meaning, call it 'project-root'). > See attached patch. Thanks, LGTM. >> Regarding report-message, I figured it would just be a separate >> 'message' call in both caller functions. Apparently that might to this >> message appearing more often (due to the requested project not actually >> appearing in project--list?), but I wonder if we shouldn't replace that >> when-let with a presence assertion instead. > Yeah, we could do that. However, the nice thing now is at least that the > behavior is bundled together, so we don't need to remember to > report. Not sure what is best:) Yeah, ok. >> Anyway, the latter is not a big deal; project--remove-from-project-list >> can be changed at any time later. > Sure! Do the manual later, or now? It's the next step, yes.