bug#15651: 24.3.50; `menu-bar-select-buffer' - Remove it? Move it to msb.el?

bug#15651: 24.3.50; `menu-bar-select-buffer' - Remove it? Move it to msb.el?

[Drew Adams]

`menu-bar-select-buffer' is defined in `menu-bar.el'.  It used to be
used there as well, in function `menu-bar-update-buffers'.

Now, the latter function uses `menu-bar-select-buffer-function' instead
(which makes no use of `menu-bar-select-buffer').  The only place
`menu-bar-select-buffer' is used now is in `msb.el'.

Why not remove `menu-bar-select-buffer' or move it to `msb.el'?



In GNU Emacs 24.3.50.1 (i686-pc-mingw32)
 of 2013-10-09 on LEG570
Bzr revision: 114596 jan.h.d@swipnet.se-20131009185014-vynfyw4o8p5fge54
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --enable-checking 'CFLAGS=-O0 -g3' CPPFLAGS=-DGLYPH_DEBUG=1'

bug#15651: 24.3.50; `menu-bar-select-buffer' - Remove it? Move it to msb.el?

[Lars Ingebrigtsen]

Drew Adams <drew.adams@oracle.com> writes:

> `menu-bar-select-buffer' is defined in `menu-bar.el'.  It used to be
> used there as well, in function `menu-bar-update-buffers'.
>
> Now, the latter function uses `menu-bar-select-buffer-function' instead
> (which makes no use of `menu-bar-select-buffer').  The only place
> `menu-bar-select-buffer' is used now is in `msb.el'.
>
> Why not remove `menu-bar-select-buffer' or move it to `msb.el'?

Well, there may be third party usages of this very important function, I
guess?

(defun menu-bar-select-buffer ()
  (interactive)
  (switch-to-buffer last-command-event))

And it's unclear whether it's used in msb.el.  The only mention is:

(defun msb--make-keymap-menu (raw-menu)
  (let ((end 'menu-bar-select-buffer)
	(mcount 0))

But it could be funcalled afterwards...  the logic is unclear...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#15651: 24.3.50; `menu-bar-select-buffer' - Remove it? Move it to msb.el?

[Lars Ingebrigtsen]

Lars Ingebrigtsen <larsi@gnus.org> writes:

>> Why not remove `menu-bar-select-buffer' or move it to `msb.el'?
>
> Well, there may be third party usages of this very important function, I
> guess?
>
> (defun menu-bar-select-buffer ()
>   (interactive)
>   (switch-to-buffer last-command-event))

So moving it might break something for some users, but I think it's
highly unlikely.  So I've now moved it in Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#15651: 24.3.50; `menu-bar-select-buffer' - Remove it? Move it to msb.el?

[Eli Zaretskii]

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Sun, 30 May 2021 07:49:56 +0200
> Cc: 15651@debbugs.gnu.org
> 
> Lars Ingebrigtsen <larsi@gnus.org> writes:
> 
> >> Why not remove `menu-bar-select-buffer' or move it to `msb.el'?
> >
> > Well, there may be third party usages of this very important function, I
> > guess?
> >
> > (defun menu-bar-select-buffer ()
> >   (interactive)
> >   (switch-to-buffer last-command-event))
> 
> So moving it might break something for some users, but I think it's
> highly unlikely.  So I've now moved it in Emacs 28.

Should it be autoloaded now?  menu-bar.el is preloaded, whereas msb.el
isn't, so 3rd-party packages which expect the function to be available
could be in trouble now.

bug#15651: 24.3.50; `menu-bar-select-buffer' - Remove it? Move it to msb.el?

[Lars Ingebrigtsen]

Eli Zaretskii <eliz@gnu.org> writes:

>> So moving it might break something for some users, but I think it's
>> highly unlikely.  So I've now moved it in Emacs 28.
>
> Should it be autoloaded now?  menu-bar.el is preloaded, whereas msb.el
> isn't, so 3rd-party packages which expect the function to be available
> could be in trouble now.

We could do that, but since the command is so trivial (and undocumented
and uncommented) that I find it unlikely that anybody is using it.

But if that turns out to be the case, we should autoload it.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#15651: 24.3.50; `menu-bar-select-buffer' - Remove it? Move it to msb.el?

[Eli Zaretskii]

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: drew.adams@oracle.com,  15651@debbugs.gnu.org
> Date: Sun, 30 May 2021 11:37:20 +0200
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> So moving it might break something for some users, but I think it's
> >> highly unlikely.  So I've now moved it in Emacs 28.
> >
> > Should it be autoloaded now?  menu-bar.el is preloaded, whereas msb.el
> > isn't, so 3rd-party packages which expect the function to be available
> > could be in trouble now.
> 
> We could do that, but since the command is so trivial (and undocumented
> and uncommented) that I find it unlikely that anybody is using it.
> 
> But if that turns out to be the case, we should autoload it.

I think we should autoload it without waiting for complaints.
Autoloading one function has a negligible cost.

bug#15651: 24.3.50; `menu-bar-select-buffer' - Remove it? Move it to msb.el?

[Lars Ingebrigtsen]

Eli Zaretskii <eliz@gnu.org> writes:

> I think we should autoload it without waiting for complaints.
> Autoloading one function has a negligible cost.

What we wanted to achieve in this bug report was to remove a useless
command from the preloaded namespace, so adding an autoload here doesn't
really help with that.

So instead I reverted the patch, and I made the original command
obsolete and added a private command to msb.el.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no