From: Daniel Mendler <mail@daniel-mendler.de>
To: Robert Pluim <rpluim@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>, 60867@debbugs.gnu.org
Subject: bug#60867: 29.0.60; keymap-set-after does not accept the AFTER=t argument
Date: Thu, 19 Jan 2023 16:38:38 +0100 [thread overview]
Message-ID: <6e8133ff-6cca-efcb-7748-4b983960b36a@daniel-mendler.de> (raw)
In-Reply-To: <87cz7a1r4k.fsf@gmail.com>
On 1/19/23 16:27, Robert Pluim wrote:
>>>>>> On Thu, 19 Jan 2023 12:19:19 +0100, Daniel Mendler <mail@daniel-mendler.de> said:
>
> Daniel> On 1/19/23 12:05, Robert Pluim wrote:
>
> Daniel> My point is that it would be expected from `key-parse' that it is
> Daniel> equally strict as the other keymap functions, otherwise we miss bugs
> Daniel> where `key-parse' wasn't used properly. Furthermore we would avoid all
> Daniel> these `key-valid-p` and `keymap--check' calls, as I mentioned.
>
> `key-parse' should perhaps be renamed to `key--parse' as itʼs very
> much internal.
Yes, that would be another possibility. I also thought about that, but
having key-parse public seems useful for packages. There should be an
official way to convert from the string to the internal key representation.
My only gripe with key-parse in its current form is really that it is
not strict enough. Another possibility in case we don't want to
introduce a NOERROR/LAX argument:
key-parse (strict) calls key-valid-p and key--parse-lax
kbd calls key--parse-lax
> Daniel> Of course `kbd' should stay as lax as it has always been.
>
> Daniel> It is mostly used internally. There are only 9 call sites in the Emacs code.
>
> >> Iʼll make
> >> that change locally and see what happens. (Update: it did not go well,
> >> there are test-suite failures).
>
> Daniel> This is hardly an argument. You should check all the call sites and
> Daniel> adjust accordingly. In particular `kbd' must pass 'noerror. I would
> Daniel> expect this to be a pretty small patch given the small number of call sites.
>
> The test suite shows what peopleʼs assumptions are, so such failures
> are valuable. It may be enough to use 'noerror in `kbd', indeed, but I
> havenʼt checked that yet. Or maybe the test suite needs adjusting.
Yes, of course. But I assume that in this case the failure is not coming
from direct calls to key-parse but from calls to kbd etc. The key-parse
itself doesn't seem to be really tested in the Emacs test suite.
I also maintain a test suite as part of the Compat package for newly
introduced APIs. There I also have tests, which could be upstreamed to
the Emacs test suite if there is interest, since some functions lack
tests there. See
https://github.com/emacs-compat/compat/blob/master/compat-tests.el
Daniel
next prev parent reply other threads:[~2023-01-19 15:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 18:20 bug#60867: 29.0.60; keymap-set-after does not accept the AFTER=t argument Daniel Mendler
2023-01-17 17:13 ` Robert Pluim
2023-01-17 17:18 ` Daniel Mendler
2023-01-18 8:36 ` Robert Pluim
2023-01-18 10:29 ` Daniel Mendler
2023-01-19 9:55 ` Robert Pluim
2023-01-19 10:08 ` Daniel Mendler
2023-01-19 10:16 ` Robert Pluim
2023-01-19 10:39 ` Daniel Mendler
2023-01-19 11:05 ` Robert Pluim
2023-01-19 11:19 ` Daniel Mendler
2023-01-19 15:27 ` Robert Pluim
2023-01-19 15:38 ` Daniel Mendler [this message]
2023-01-19 10:23 ` Eli Zaretskii
2023-01-19 10:40 ` Robert Pluim
2023-01-19 11:27 ` Eli Zaretskii
2023-01-19 15:20 ` Robert Pluim
2023-01-20 16:11 ` Robert Pluim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e8133ff-6cca-efcb-7748-4b983960b36a@daniel-mendler.de \
--to=mail@daniel-mendler.de \
--cc=60867@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=rpluim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.