all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#26528: dired-do-chmod complains about . .. but works
@ 2017-04-15 23:46 積丹尼 Dan Jacobson
  2017-04-17  6:44 ` Paul Eggert
  0 siblings, 1 reply; 2+ messages in thread
From: 積丹尼 Dan Jacobson @ 2017-04-15 23:46 UTC (permalink / raw)
  To: 26528

M runs the command dired-do-chmod
which complains
'dired-get-filename: Cannot operate on ‘.’ or ‘..’'
but thankfully works anyway.





^ permalink raw reply	[flat|nested] 2+ messages in thread

* bug#26528: dired-do-chmod complains about . .. but works
  2017-04-15 23:46 bug#26528: dired-do-chmod complains about . .. but works 積丹尼 Dan Jacobson
@ 2017-04-17  6:44 ` Paul Eggert
  0 siblings, 0 replies; 2+ messages in thread
From: Paul Eggert @ 2017-04-17  6:44 UTC (permalink / raw)
  To: 積丹尼 Dan Jacobson; +Cc: 26528-done

[-- Attachment #1: Type: text/plain, Size: 149 bytes --]

Thanks, I installed a patch into master to fix this.

http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=47122295521c63febe9fc64680430812da3a3acf

[-- Attachment #2: 0001-dired-M-should-not-complain-about-.-and.txt --]
[-- Type: text/plain, Size: 1509 bytes --]

From 05a989de24c39fd2c6e7e67eebd5db4864ad809e Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Sun, 16 Apr 2017 23:36:26 -0700
Subject: [PATCH] =?UTF-8?q?dired=20=E2=80=98M=E2=80=99=20should=20not=20co?=
 =?UTF-8?q?mplain=20about=20=E2=80=98.=E2=80=99=20and=20=E2=80=98..?=
 =?UTF-8?q?=E2=80=99?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* lisp/dired-aux.el (dired-do-redisplay):
Allow redisplay of ‘.’ and ‘..’ (Bug#26528).
---
 lisp/dired-aux.el | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el
index d7ca052..ec07f9b 100644
--- a/lisp/dired-aux.el
+++ b/lisp/dired-aux.el
@@ -1266,12 +1266,14 @@ dired-do-redisplay
     ;; message much faster than making dired-map-over-marks show progress
     (dired-uncache
      (if (consp dired-directory) (car dired-directory) dired-directory))
-    (dired-map-over-marks (let ((fname (dired-get-filename))
+    (dired-map-over-marks (let ((fname (dired-get-filename nil t))
 				;; Postpone readin hook till we map
 				;; over all marked files (Bug#6810).
 				(dired-after-readin-hook nil))
-			    (message "Redisplaying... %s" fname)
-			    (dired-update-file-line fname))
+			    (if (not fname)
+				(error "No file on this line")
+			      (message "Redisplaying... %s" fname)
+			      (dired-update-file-line fname)))
 			  arg)
     (run-hooks 'dired-after-readin-hook)
     (dired-move-to-filename)
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-04-17  6:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-15 23:46 bug#26528: dired-do-chmod complains about . .. but works 積丹尼 Dan Jacobson
2017-04-17  6:44 ` Paul Eggert

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.