From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#67034: 30.0.50; Make `derived-mode-p` take a single arg Date: Sat, 11 Nov 2023 02:04:29 +0200 Message-ID: <6ded2256-4537-3a51-8ecd-ab3bd5a862d1@gutov.dev> References: <96367d39-4861-41e6-9383-a9a18efa0678@daniel-mendler.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1545"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 To: Daniel Mendler , 67034@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 11 01:05:36 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r1bVH-00009O-IW for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 11 Nov 2023 01:05:36 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r1bV5-00057x-G4; Fri, 10 Nov 2023 19:05:23 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r1bV4-00057g-4c for bug-gnu-emacs@gnu.org; Fri, 10 Nov 2023 19:05:22 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r1bV3-0001Vc-Sa for bug-gnu-emacs@gnu.org; Fri, 10 Nov 2023 19:05:21 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r1bVh-0004Gr-RS for bug-gnu-emacs@gnu.org; Fri, 10 Nov 2023 19:06:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 11 Nov 2023 00:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67034 X-GNU-PR-Package: emacs Original-Received: via spool by 67034-submit@debbugs.gnu.org id=B67034.169966111816361 (code B ref 67034); Sat, 11 Nov 2023 00:06:01 +0000 Original-Received: (at 67034) by debbugs.gnu.org; 11 Nov 2023 00:05:18 +0000 Original-Received: from localhost ([127.0.0.1]:51053 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r1bV0-0004Fo-9c for submit@debbugs.gnu.org; Fri, 10 Nov 2023 19:05:18 -0500 Original-Received: from out2-smtp.messagingengine.com ([66.111.4.26]:36881) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r1bUy-0004Fa-PH for 67034@debbugs.gnu.org; Fri, 10 Nov 2023 19:05:17 -0500 Original-Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 99B825C0218; Fri, 10 Nov 2023 19:04:31 -0500 (EST) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Fri, 10 Nov 2023 19:04:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1699661071; x=1699747471; bh=YQ1oKE6xVLJ3SZiua+KSMvjqEcBYK/Mvoe3 aj5mXTv8=; b=H7YqLWiSaOIHSY8q5VTfJDdRGxZI2wvcIvknjy+olgqMV3nlABi xfn/VfpzcbXxMMS4Hrs+XLtoVkhjgGDdVuQr2oHdp7AHV1CmNJCDYCQsUwU0qlui bdYAPkQ6HWEX6ttXAeAz8ROTX3D0Nq+J6qs8Yuh4fGdGu6DnliCZsVNx9C6IgsAw chvAK27u6bAJTgD4KTT+4KmiLdAlkDpXD8Eez96Zkq/4IJPIaeLQ/9yXGhTxhFya kI0UCVMB6vqypdT5bP14N1lVcHF/CwZ51+Gj8DAAk+XMH+5zh2acc6ahObpgpbsq sVLXj9nAr2FHDNomrHDjhwJL3PVR0doyVdA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1699661071; x= 1699747471; bh=YQ1oKE6xVLJ3SZiua+KSMvjqEcBYK/Mvoe3aj5mXTv8=; b=H ufGdRniQrmhK5ukZCrIJw1McZFAiAHOg5VvDJ9WaF4NLpk6DFJd+Olr1kTgeMm4l DgSXvQBmvIWZ1i+h3n46Gl3P8LQzdxRUGf7zidhijhm0ar0L7KQjp3Tqevkjab1l 6C9sBtTn4s6rHXMTq2ileW9XLRL3YSMpiIEP1dR7u8w4lTP1AliIrKO5xHg/Duva MTY6RuemQVFAdGP3dw6IrWuPWaW+Guj4dVBId9LOXo4lf4ebhnh5NzNXNDwSbYVU +2PvjP6LF/F3hOx9tSCduEVbJp2JdnIIFWYjOdbuUaI8oJbQ4CkKCQEZzMh1Bj91 DbdsJaFcl9zsamvXJNeAg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedruddvgedgudeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefkffggfgfuvfhfhfgjtgfgsehtje ertddtfeejnecuhfhrohhmpeffmhhithhrhicuifhuthhovhcuoegumhhithhrhiesghhu thhovhdruggvvheqnecuggftrfgrthhtvghrnhepgeehtdehudejieetuedttdejkeehje etueekheffuddtjeeuvdefveeuveeiuddunecuvehluhhsthgvrhfuihiivgeptdenucfr rghrrghmpehmrghilhhfrhhomhepughmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 10 Nov 2023 19:04:30 -0500 (EST) Content-Language: en-US In-Reply-To: <96367d39-4861-41e6-9383-a9a18efa0678@daniel-mendler.de> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274123 Archived-At: On 10/11/2023 14:18, Daniel Mendler wrote: > There are also multiple call sites with apply, but these would be > arguably nicer if derived-mode-p takes a list argument as proposed. > Still, do the benefits of this change outweigh the required changes? I've also found some call sites with multiple arguments (one of them being sml-mode 6.12) and also uses with (apply #'derived-mode-p some-user-option-list-of-modes). But those are indeed in the minority. I wonder if this extra allocation of &rest makes any difference in any benchmark, though.