all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dmitry@gutov.dev>
To: Daniel Mendler <mail@daniel-mendler.de>, 67034@debbugs.gnu.org
Subject: bug#67034: 30.0.50; Make `derived-mode-p` take a single arg
Date: Sat, 11 Nov 2023 02:04:29 +0200	[thread overview]
Message-ID: <6ded2256-4537-3a51-8ecd-ab3bd5a862d1@gutov.dev> (raw)
In-Reply-To: <96367d39-4861-41e6-9383-a9a18efa0678@daniel-mendler.de>

On 10/11/2023 14:18, Daniel Mendler wrote:
> There are also multiple call sites with apply, but these would be
> arguably nicer if derived-mode-p takes a list argument as proposed.
> Still, do the benefits of this change outweigh the required changes?

I've also found some call sites with multiple arguments (one of them 
being sml-mode 6.12) and also uses with (apply #'derived-mode-p 
some-user-option-list-of-modes). But those are indeed in the minority.

I wonder if this extra allocation of &rest makes any difference in any 
benchmark, though.





  reply	other threads:[~2023-11-11  0:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-10  3:58 bug#67034: 30.0.50; Make `derived-mode-p` take a single arg Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-10 12:18 ` Daniel Mendler
2023-11-11  0:04   ` Dmitry Gutov [this message]
2023-11-11  9:08     ` Daniel Mendler
2023-11-16 22:38   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-16 22:28 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-17  8:24   ` Eli Zaretskii
2023-11-17 21:18     ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-23 17:00       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6ded2256-4537-3a51-8ecd-ab3bd5a862d1@gutov.dev \
    --to=dmitry@gutov.dev \
    --cc=67034@debbugs.gnu.org \
    --cc=mail@daniel-mendler.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.