Re: Undo mode

[Gregory Heytings <gregory@heytings.org>]

[-- Attachment #1: Type: text/plain, Size: 261 bytes --]


>> I respectfully suggest to go back to that original design.
>
> We haven't yet decided to change the design
>

Going back to the original design is not changing the design, it's 
restoring the menu item as it was originally meant to be.  See attached 
patch.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Fix-Undelete-Frame-menu-item.patch --]
[-- Type: text/x-diff; name=Fix-Undelete-Frame-menu-item.patch, Size: 1732 bytes --]

From 9b025659fdbca5a0fe9ae38a05dbc13ec05a1c8a Mon Sep 17 00:00:00 2001
From: Gregory Heytings <gregory@heytings.org>
Date: Fri, 21 Jan 2022 09:47:02 +0000
Subject: [PATCH] Fix Undelete Frame menu item

* lisp/menu-bar.el (menu-bar-file-menu): Re-add the "Enable Frame Undeletion"
menu item, and restore the "Undelete Frame" menu item.
---
 lisp/menu-bar.el | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/lisp/menu-bar.el b/lisp/menu-bar.el
index d1ca16dbf6..3a630912a9 100644
--- a/lisp/menu-bar.el
+++ b/lisp/menu-bar.el
@@ -108,16 +108,15 @@ menu-bar-file-menu
     (bindings--define-key menu [separator-tab]
       menu-bar-separator)
 
-    (bindings--define-key menu [undelete-frame-mode]
-      '(menu-item "Allow Undeleting Frames" undelete-frame-mode
-                  :help "Allow frames to be restored after deletion"
-                  :button (:toggle . undelete-frame-mode)))
-
     (bindings--define-key menu [undelete-last-deleted-frame]
       '(menu-item "Undelete Frame" undelete-frame
-                  :visible (and undelete-frame-mode
-                                (car undelete-frame--deleted-frames))
+                  :visible undelete-frame-mode
+                  :enable undelete-frame--deleted-frames
                   :help "Undelete the most recently deleted frame"))
+    (bindings--define-key menu [enable-undelete-frame-mode]
+      '(menu-item "Enable Frame Undeletion" undelete-frame-mode
+                  :visible (null undelete-frame-mode)
+                  :help "Enable frame undeletion for this session"))
 
     ;; Don't use delete-frame as event name because that is a special
     ;; event.
-- 
2.34.1