From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit Date: Mon, 25 Nov 2019 02:12:42 +0200 Message-ID: <6d316d96-0c2b-27e8-f538-a7909a127b7a@yandex.ru> References: <87ftj5at1q.fsf@gnus.org> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> <83a78pxenu.fsf@gnu.org> <215302ff-8252-1f6c-5f60-aaba01cd615f@yandex.ru> <837e3tx9s8.fsf@gnu.org> <87d0di7959.fsf@linkov.net> <7115df2d-c209-c672-7e92-ff682c4ec8ee@yandex.ru> <87mucm43ja.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="211599"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 Cc: stephen.berman@gmx.net, 38044@debbugs.gnu.org, larsi@gnus.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 25 13:50:14 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iZDog-000sn7-6P for geb-bug-gnu-emacs@m.gmane.org; Mon, 25 Nov 2019 13:50:10 +0100 Original-Received: from localhost ([::1]:43218 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZDoe-0005In-TY for geb-bug-gnu-emacs@m.gmane.org; Mon, 25 Nov 2019 07:50:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36374) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZDoY-0005Ie-SJ for bug-gnu-emacs@gnu.org; Mon, 25 Nov 2019 07:50:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iZDoX-0007PK-PY for bug-gnu-emacs@gnu.org; Mon, 25 Nov 2019 07:50:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41764) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iZDoX-0007PG-Lt for bug-gnu-emacs@gnu.org; Mon, 25 Nov 2019 07:50:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iZDoX-0005H1-KH for bug-gnu-emacs@gnu.org; Mon, 25 Nov 2019 07:50:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 25 Nov 2019 12:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38044 X-GNU-PR-Package: emacs Original-Received: via spool by 38044-submit@debbugs.gnu.org id=B38044.157468618520246 (code B ref 38044); Mon, 25 Nov 2019 12:50:01 +0000 Original-Received: (at 38044) by debbugs.gnu.org; 25 Nov 2019 12:49:45 +0000 Original-Received: from localhost ([127.0.0.1]:47737 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZDoG-0005GU-TB for submit@debbugs.gnu.org; Mon, 25 Nov 2019 07:49:45 -0500 Original-Received: from mail-wr1-f45.google.com ([209.85.221.45]:46901) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZDoE-0005GH-F8 for 38044@debbugs.gnu.org; Mon, 25 Nov 2019 07:49:43 -0500 Original-Received: by mail-wr1-f45.google.com with SMTP id z7so14433374wrl.13 for <38044@debbugs.gnu.org>; Mon, 25 Nov 2019 04:49:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=vt9nMtT+/79rlmn2XNHH+derGSyJTe4piMDu2nHG5lc=; b=tu8SUDF9nqpPVZ2UF1NHyZyqoMGBHrVta/8QLm1G1rupv26bM1MyX4KW+uqeKqPvkJ NyJkaxYTitQbprldtXUCfLGa1+87ngoN2G5uSAdzpxt5FRFWpihva8a2L231809MsUZ/ zjMPvZWlb0Ygy4m7RLGE8+WL4vMB+Z8TQmvpSfhXy7Bkbdjmw93/AbC2T2my5j811UK/ ZyVL+UfyrOX0tGA9oPZU3ejBoQbvLJFU0WG0ZMCboiHYs3h3VOjhns5q/Jgl7BdJ0VIt 8PwijohUAFJbdA3r9bob08tu6WtcY+oYIRjtnETTPyh7JlUoCoq4Ljw65Adp0o2TrWE+ L8Ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=vt9nMtT+/79rlmn2XNHH+derGSyJTe4piMDu2nHG5lc=; b=X3XO/DPJgyjAwt6ITELABpBpMjy/aw1ZbhSE+IGvdrRd6CCHCJuC13jHHLutoAmHAG 8R6gD/+2xzH7MIKqJdrqzi+MMdYQmXPBADOr86Dc7/wAZ59teBt/KuHTGVjiwCEEkJpx WxCBsMN9uzB+oJoRUG3EtSgbkibCZTPdQLnWmjeFUTf/kwpAAF9mBkfzVpxxmzxz4sCd 1Hy8EDXAsLT9RaqYIjYIG+faWX6kCWiV/9Xo2e46UqUcUnY8CeGDX2brKRBLNo99uE/t J8SXiBS/tZQTt8dKVmED5KYP50/lpOH6iN+pCwFGGFHCZHzDsZt4RQgokmUoX0tdfvlG bJVQ== X-Gm-Message-State: APjAAAV9MYuBTxSXXuTZ8slJg/C1d+AjwgWxw1WLxpqmMSnGjf1QrN3N X5pEclMHhp0ncJriVzk1sPyuNBWx X-Google-Smtp-Source: APXvYqwLVO+oQJJ1pJ+40yQhtMK6FdRYkSoyrANxYc8F80KDVlqp446DZ1TMus1/M+0+MeoYRVTt9Q== X-Received: by 2002:a5d:4810:: with SMTP id l16mr13205427wrq.127.1574640764831; Sun, 24 Nov 2019 16:12:44 -0800 (PST) Original-Received: from [192.168.0.5] ([212.50.117.215]) by smtp.googlemail.com with ESMTPSA id j67sm6838998wmb.43.2019.11.24.16.12.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 24 Nov 2019 16:12:43 -0800 (PST) In-Reply-To: <87mucm43ja.fsf@mail.linkov.net> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172361 Archived-At: On 24.11.2019 0:43, Juri Linkov wrote: > I rewrote the patch to make it more flexible, so now the function > can check 'vc-log-view-type' for the value 'with-diff'. Generally, an explicit argument is better than an implicit one. So what's the idea here? Gracefully degrading to just showing a log entry when the backend doesn't support the WITH-DIFF feature? (BTW, the print-revision approach seems better for graceful degradation, but I'm tired of arguing for that). I think it would work, but for that all backends need support for region-history-mode anyway. The caller function doesn't have a way to check the lack of support. So I guess the "proper" choice here is to extract region-history-mode is a way that doesn't need redefinition by all backends. Or a shortcut: catch the vc-not-supported error and call backend's log-view-mode instead.