From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#58464: 28.1; browse-url-emacs doesn't work for local files on Windows Date: Thu, 13 Oct 2022 09:40:54 -0700 Organization: UCLA Computer Science Department Message-ID: <6cc4566c-00f8-8fa1-4dcd-411539972f87@cs.ucla.edu> References: <82k055fsos.fsf@gmail.com> <87y1tlcn7u.fsf@gnus.org> <83czaxchgp.fsf@gnu.org> <87mta1b2p9.fsf@gnus.org> <83sfjtazln.fsf@gnu.org> <87edvdays6.fsf@gnus.org> <83leplavfs.fsf@gnu.org> <871qrdavc6.fsf@gnus.org> <83ilkpauuz.fsf@gnu.org> <87r0zc88fn.fsf@gnus.org> <83wn949fui.fsf@gnu.org> <8735bs7yg0.fsf@gnus.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------UK72F7ZguBDonr0lPriy3DNd" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10819"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Cc: pquessev@gmail.com, 58464@debbugs.gnu.org To: Lars Ingebrigtsen , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 13 18:43:42 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oj1J7-0002cA-7b for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Oct 2022 18:43:41 +0200 Original-Received: from localhost ([::1]:49604 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oj1J4-0001YZ-CS for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Oct 2022 12:43:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36274) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oj1HY-0000I7-FT for bug-gnu-emacs@gnu.org; Thu, 13 Oct 2022 12:42:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35721) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oj1HW-0007yW-Ly for bug-gnu-emacs@gnu.org; Thu, 13 Oct 2022 12:42:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oj1HW-0006wE-G6 for bug-gnu-emacs@gnu.org; Thu, 13 Oct 2022 12:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Oct 2022 16:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58464 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 58464-submit@debbugs.gnu.org id=B58464.166567926426593 (code B ref 58464); Thu, 13 Oct 2022 16:42:02 +0000 Original-Received: (at 58464) by debbugs.gnu.org; 13 Oct 2022 16:41:04 +0000 Original-Received: from localhost ([127.0.0.1]:34799 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oj1Ga-0006uq-1Z for submit@debbugs.gnu.org; Thu, 13 Oct 2022 12:41:04 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:38560) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oj1GX-0006uB-2X for 58464@debbugs.gnu.org; Thu, 13 Oct 2022 12:41:03 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id BC581160056; Thu, 13 Oct 2022 09:40:55 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id ZbiLc4yaW8uW; Thu, 13 Oct 2022 09:40:55 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id DBF98160075; Thu, 13 Oct 2022 09:40:54 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.9.2 zimbra.cs.ucla.edu DBF98160075 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=78364E5A-2AF3-11ED-87FA-8298ECA2D365; t=1665679254; bh=tHs27crzXoSp8n1Iz3YfZ/5AqfDZ+1bE3Dqrn+ieFl0=; h=Content-Type:Message-ID:Date:MIME-Version:To:From:Subject; b=BDpj3+9qjIj5ReS1kHIhN1ynpbFC/VtFizIlvZ0q87cF7fmzJtK5d1n+E6jcweVbX sYQ2DxUst9GrP7ah62LI8bzV048H2ax43SXFHW04GoRSNNqHy5TtG4s/jPz5J6cHUs 9TRarhaDE1yxFSPPAOtNYHVKWVrCO1mRRT4g/E/Q= X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id TG6MgT1gAo6F; Thu, 13 Oct 2022 09:40:54 -0700 (PDT) Original-Received: from [192.168.1.9] (cpe-172-91-119-151.socal.res.rr.com [172.91.119.151]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id A7F5C160056; Thu, 13 Oct 2022 09:40:54 -0700 (PDT) Content-Language: en-US In-Reply-To: <8735bs7yg0.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:245330 Archived-At: This is a multi-part message in MIME format. --------------UK72F7ZguBDonr0lPriy3DNd Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2022-10-13 04:30, Lars Ingebrigtsen wrote: > Eli Zaretskii writes: > >> Thanks. But this part: >> >> - if (NILP (handler) && !NILP (visit) && current_buffer->modtime.tv_nsec < 0) >> + if (save_errno != 0) >> >> might cause us signal an error when VISIT is nil, something that >> didn't happen before. We should be OK there. If VISIT is nil, SAVE_ERRNO must be zero. >> (I also am not sure it is 100% reliable to rely on save_errno being >> non-zero whenever we encounter an error, especially in the >> file-handlers case.) Should be OK here too. In the file-handlers case, SAVE_ERRNO is zero. I installed the attached to help document and check this. --------------UK72F7ZguBDonr0lPriy3DNd Content-Type: text/x-patch; charset=UTF-8; name="0001-Improve-checks-for-recent-File-exists-fixup.patch" Content-Disposition: attachment; filename="0001-Improve-checks-for-recent-File-exists-fixup.patch" Content-Transfer-Encoding: base64 RnJvbSAxMGY1NTk3NWQzNGRkNzI5OWY3MmZkZjhkOTNmZDhjYmUyZTQxZTI1IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBUaHUsIDEzIE9jdCAyMDIyIDA5OjMzOjQ2IC0wNzAwClN1YmplY3Q6IFtQQVRD SF0gSW1wcm92ZSBjaGVja3MgZm9yIHJlY2VudCAiRmlsZSBleGlzdHMiIGZpeHVwCgoqIHNy Yy9maWxlaW8uYyAoRmluc2VydF9maWxlX2NvbnRlbnRzKTogQWRkIGFuIGFzc2VydGlvbiAo YnVnIzQyNDMxKS4KLS0tCiBzcmMvZmlsZWlvLmMgfCAxICsKIDEgZmlsZSBjaGFuZ2VkLCAx IGluc2VydGlvbigrKQoKZGlmZiAtLWdpdCBhL3NyYy9maWxlaW8uYyBiL3NyYy9maWxlaW8u YwppbmRleCA0OTU1M2YzYzkxLi5iOWE1N2RkNTgwIDEwMDY0NAotLS0gYS9zcmMvZmlsZWlv LmMKKysrIGIvc3JjL2ZpbGVpby5jCkBAIC01MDAzLDYgKzUwMDMsNyBAQCBiZWNhdXNlICgx KSBpdCBwcmVzZXJ2ZXMgc29tZSBtYXJrZXIgcG9zaXRpb25zIChpbiB1bmNoYW5nZWQgcG9y dGlvbnMKICAgaWYgKHNhdmVfZXJybm8gIT0gMCkKICAgICB7CiAgICAgICAvKiBTaWduYWwg YW4gZXJyb3IgaWYgdmlzaXRpbmcgYSBmaWxlIHRoYXQgY291bGQgbm90IGJlIG9wZW5lZC4g ICovCisgICAgICBlYXNzZXJ0ICghTklMUCAodmlzaXQpICYmIE5JTFAgKGhhbmRsZXIpKTsK ICAgICAgIHJlcG9ydF9maWxlX2Vycm5vICgiT3BlbmluZyBpbnB1dCBmaWxlIiwgb3JpZ19m aWxlbmFtZSwgc2F2ZV9lcnJubyk7CiAgICAgfQogCi0tIAoyLjM0LjEKCg== --------------UK72F7ZguBDonr0lPriy3DNd--