From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#26628: [PATCH] Fix memory leak of cwd string in emacsclient Date: Wed, 31 May 2017 23:30:53 -0700 Organization: UCLA Computer Science Department Message-ID: <6cc3d07a-0387-8d88-4bc2-e127f86b97f7@cs.ucla.edu> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------5237B341C12D132202C7D6D5" X-Trace: blaine.gmane.org 1496298731 29203 195.159.176.226 (1 Jun 2017 06:32:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 1 Jun 2017 06:32:11 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 Cc: Anders Waldenborg , 26628@debbugs.gnu.org To: npostavs@users.sourceforge.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jun 01 08:32:07 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dGJeR-0007OU-HJ for geb-bug-gnu-emacs@m.gmane.org; Thu, 01 Jun 2017 08:32:07 +0200 Original-Received: from localhost ([::1]:35562 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dGJeX-0005Et-0U for geb-bug-gnu-emacs@m.gmane.org; Thu, 01 Jun 2017 02:32:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41246) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dGJeP-0005Eo-OK for bug-gnu-emacs@gnu.org; Thu, 01 Jun 2017 02:32:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dGJeM-00013N-FS for bug-gnu-emacs@gnu.org; Thu, 01 Jun 2017 02:32:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45648) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dGJeM-00013H-Bz for bug-gnu-emacs@gnu.org; Thu, 01 Jun 2017 02:32:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dGJeL-0005oO-N0 for bug-gnu-emacs@gnu.org; Thu, 01 Jun 2017 02:32:01 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 Jun 2017 06:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26628 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch fixed Original-Received: via spool by 26628-submit@debbugs.gnu.org id=B26628.149629866422276 (code B ref 26628); Thu, 01 Jun 2017 06:32:01 +0000 Original-Received: (at 26628) by debbugs.gnu.org; 1 Jun 2017 06:31:04 +0000 Original-Received: from localhost ([127.0.0.1]:48325 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dGJdP-0005nE-M3 for submit@debbugs.gnu.org; Thu, 01 Jun 2017 02:31:03 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:40574) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dGJdN-0005mf-PT for 26628@debbugs.gnu.org; Thu, 01 Jun 2017 02:31:02 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id BBF421600C7; Wed, 31 May 2017 23:30:55 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id k9Pud1R25FA4; Wed, 31 May 2017 23:30:54 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 2B9BD1600A7; Wed, 31 May 2017 23:30:54 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 9UwLgb0ACQap; Wed, 31 May 2017 23:30:54 -0700 (PDT) Original-Received: from [192.168.1.9] (unknown [47.153.188.248]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 0B9E81600D1; Wed, 31 May 2017 23:30:54 -0700 (PDT) Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:133128 Archived-At: This is a multi-part message in MIME format. --------------5237B341C12D132202C7D6D5 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Generally speaking we don't bother freeing storage just before program ex= it=20 merely to pacify AddressSanitizer, as that makes the program less efficie= nt and=20 is contrary to the goal of leak checking which is to increase efficiency.= Here,=20 though, we can free storage earlier, and this might have a point since th= e=20 storage can get reused. So I installed the attached further patch. > I'm aware that I can set ASAN_OPTIONS=3Ddetect_leaks=3D0 in the environ= ment It might not hurt to do that, if only to prevent our hassling with false = alarms. --------------5237B341C12D132202C7D6D5 Content-Type: text/plain; charset=UTF-8; name="0001-Free-cwd-when-no-longer-needed.txt" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-Free-cwd-when-no-longer-needed.txt" RnJvbSA4NzdlODA4NDQwZDRiYzJlNjJkNmZiNTA5ZGVmZWU5MWEzZmRjODk1IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBXZWQsIDMxIE1heSAyMDE3IDIyOjM4OjA0IC0wNzAwClN1YmplY3Q6IFtQQVRD SF0gRnJlZSBjd2Qgd2hlbiBubyBsb25nZXIgbmVlZGVkCk1JTUUtVmVyc2lvbjogMS4wCkNv bnRlbnQtVHlwZTogdGV4dC9wbGFpbjsgY2hhcnNldD1VVEYtOApDb250ZW50LVRyYW5zZmVy LUVuY29kaW5nOiA4Yml0CgoqIGxpYi1zcmMvZW1hY3NjbGllbnQuYyAobWFpbik6IERvbuKA mXQgZGFsbHkgd2hlbiBmcmVlaW5nIGN3ZC4KLS0tCiBsaWItc3JjL2VtYWNzY2xpZW50LmMg fCA1ICsrLS0tCiAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9u cygtKQoKZGlmZiAtLWdpdCBhL2xpYi1zcmMvZW1hY3NjbGllbnQuYyBiL2xpYi1zcmMvZW1h Y3NjbGllbnQuYwppbmRleCAzYTA3MTVmLi44ODI4Yjc2IDEwMDY0NAotLS0gYS9saWItc3Jj L2VtYWNzY2xpZW50LmMKKysrIGIvbGliLXNyYy9lbWFjc2NsaWVudC5jCkBAIC0yMDgsNyAr MjA4LDcgQEAgY2hhciAqZ2V0X2N1cnJlbnRfZGlyX25hbWUgKHZvaWQpOwogLyogUmV0dXJu IHRoZSBjdXJyZW50IHdvcmtpbmcgZGlyZWN0b3J5LiAgUmV0dXJucyBOVUxMIG9uIGVycm9y cy4KICAgIEFueSBvdGhlciByZXR1cm5lZCB2YWx1ZSBtdXN0IGJlIGZyZWVkIHdpdGggZnJl ZS4gIFRoaXMgaXMgdXNlZAogICAgb25seSB3aGVuIGdldF9jdXJyZW50X2Rpcl9uYW1lIGlz IG5vdCBkZWZpbmVkIG9uIHRoZSBzeXN0ZW0uICAqLwotY2hhcioKK2NoYXIgKgogZ2V0X2N1 cnJlbnRfZGlyX25hbWUgKHZvaWQpCiB7CiAgIGNoYXIgKmJ1ZjsKQEAgLTE3MDIsNiArMTcw Miw3IEBAIG1haW4gKGludCBhcmdjLCBjaGFyICoqYXJndikKICAgaWYgKHRyYW1wX3ByZWZp eCkKICAgICBxdW90ZV9hcmd1bWVudCAoZW1hY3Nfc29ja2V0LCB0cmFtcF9wcmVmaXgpOwog ICBxdW90ZV9hcmd1bWVudCAoZW1hY3Nfc29ja2V0LCBjd2QpOworICBmcmVlIChjd2QpOwog ICBzZW5kX3RvX2VtYWNzIChlbWFjc19zb2NrZXQsICIvIik7CiAgIHNlbmRfdG9fZW1hY3Mg KGVtYWNzX3NvY2tldCwgIiAiKTsKIApAQCAtMTk0NSw4ICsxOTQ2LDYgQEAgbWFpbiAoaW50 IGFyZ2MsIGNoYXIgKiphcmd2KQogICBpZiAocmwgPCAwKQogICAgIGV4aXRfc3RhdHVzID0g RVhJVF9GQUlMVVJFOwogCi0gIGZyZWUgKGN3ZCk7ICAgICAgICAgICAgICAgICAgIC8qIEtl ZXAgbGVhayBjaGVja2VycyBoYXBweS4gICovCi0KICAgQ0xPU0VfU09DS0VUIChlbWFjc19z b2NrZXQpOwogICByZXR1cm4gZXhpdF9zdGF0dXM7CiB9Ci0tIAoyLjcuNAoK --------------5237B341C12D132202C7D6D5--